linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@suse.de>
To: linuxppc-dev@lists.ozlabs.org
Cc: arnd@arndb.de, geoff@infradead.org, alistair@popple.id.au,
	scottwood@freescale.com, agust@denx.de, linux@roeck-us.net
Subject: [PATCH v2 16/20] powerpc/powermac: Use pm_power_off rather than ppc_md.power_off
Date: Mon, 13 Oct 2014 16:01:24 +0200	[thread overview]
Message-ID: <1413208888-49211-17-git-send-email-agraf@suse.de> (raw)
In-Reply-To: <1413208888-49211-1-git-send-email-agraf@suse.de>

The generic power off callback is pm_power_off. Use that one rather than
the powerpc specific ppc_md.power_off.

Signed-off-by: Alexander Graf <agraf@suse.de>

---

v1 -> v2:

  - write pm_power_off in probe function
---
 arch/powerpc/platforms/powermac/setup.c | 147 ++++++++++++++++----------------
 1 file changed, 74 insertions(+), 73 deletions(-)

diff --git a/arch/powerpc/platforms/powermac/setup.c b/arch/powerpc/platforms/powermac/setup.c
index b127a29..1b03bc1 100644
--- a/arch/powerpc/platforms/powermac/setup.c
+++ b/arch/powerpc/platforms/powermac/setup.c
@@ -274,6 +274,78 @@ static void __init l2cr_init(void)
 }
 #endif
 
+#ifdef CONFIG_ADB_CUDA
+static void cuda_restart(void)
+{
+	struct adb_request req;
+
+	cuda_request(&req, NULL, 2, CUDA_PACKET, CUDA_RESET_SYSTEM);
+	for (;;)
+		cuda_poll();
+}
+
+static void cuda_shutdown(void)
+{
+	struct adb_request req;
+
+	cuda_request(&req, NULL, 2, CUDA_PACKET, CUDA_POWERDOWN);
+	for (;;)
+		cuda_poll();
+}
+
+#else
+#define cuda_restart()
+#define cuda_shutdown()
+#endif
+
+#ifndef CONFIG_ADB_PMU
+#define pmu_restart()
+#define pmu_shutdown()
+#endif
+
+#ifndef CONFIG_PMAC_SMU
+#define smu_restart()
+#define smu_shutdown()
+#endif
+
+static void pmac_restart(char *cmd)
+{
+	switch (sys_ctrler) {
+	case SYS_CTRLER_CUDA:
+		cuda_restart();
+		break;
+	case SYS_CTRLER_PMU:
+		pmu_restart();
+		break;
+	case SYS_CTRLER_SMU:
+		smu_restart();
+		break;
+	default: ;
+	}
+}
+
+static void pmac_power_off(void)
+{
+	switch (sys_ctrler) {
+	case SYS_CTRLER_CUDA:
+		cuda_shutdown();
+		break;
+	case SYS_CTRLER_PMU:
+		pmu_shutdown();
+		break;
+	case SYS_CTRLER_SMU:
+		smu_shutdown();
+		break;
+	default: ;
+	}
+}
+
+static void
+pmac_halt(void)
+{
+	pmac_power_off();
+}
+
 static void __init pmac_setup_arch(void)
 {
 	struct device_node *cpu, *ic;
@@ -382,78 +454,6 @@ void __init_refok note_bootable_part(dev_t dev, int part, int goodness)
 	current_root_goodness = goodness;
 }
 
-#ifdef CONFIG_ADB_CUDA
-static void cuda_restart(void)
-{
-	struct adb_request req;
-
-	cuda_request(&req, NULL, 2, CUDA_PACKET, CUDA_RESET_SYSTEM);
-	for (;;)
-		cuda_poll();
-}
-
-static void cuda_shutdown(void)
-{
-	struct adb_request req;
-
-	cuda_request(&req, NULL, 2, CUDA_PACKET, CUDA_POWERDOWN);
-	for (;;)
-		cuda_poll();
-}
-
-#else
-#define cuda_restart()
-#define cuda_shutdown()
-#endif
-
-#ifndef CONFIG_ADB_PMU
-#define pmu_restart()
-#define pmu_shutdown()
-#endif
-
-#ifndef CONFIG_PMAC_SMU
-#define smu_restart()
-#define smu_shutdown()
-#endif
-
-static void pmac_restart(char *cmd)
-{
-	switch (sys_ctrler) {
-	case SYS_CTRLER_CUDA:
-		cuda_restart();
-		break;
-	case SYS_CTRLER_PMU:
-		pmu_restart();
-		break;
-	case SYS_CTRLER_SMU:
-		smu_restart();
-		break;
-	default: ;
-	}
-}
-
-static void pmac_power_off(void)
-{
-	switch (sys_ctrler) {
-	case SYS_CTRLER_CUDA:
-		cuda_shutdown();
-		break;
-	case SYS_CTRLER_PMU:
-		pmu_shutdown();
-		break;
-	case SYS_CTRLER_SMU:
-		smu_shutdown();
-		break;
-	default: ;
-	}
-}
-
-static void
-pmac_halt(void)
-{
-	pmac_power_off();
-}
-
 /* 
  * Early initialization.
  */
@@ -632,6 +632,8 @@ static int __init pmac_probe(void)
 	smu_cmdbuf_abs = memblock_alloc_base(4096, 4096, 0x80000000UL);
 #endif /* CONFIG_PMAC_SMU */
 
+	pm_power_off = pmac_power_off;
+
 	return 1;
 }
 
@@ -663,7 +665,6 @@ define_machine(powermac) {
 	.get_irq		= NULL,	/* changed later */
 	.pci_irq_fixup		= pmac_pci_irq_fixup,
 	.restart		= pmac_restart,
-	.power_off		= pmac_power_off,
 	.halt			= pmac_halt,
 	.time_init		= pmac_time_init,
 	.get_boot_time		= pmac_get_boot_time,
-- 
1.8.1.4

  parent reply	other threads:[~2014-10-13 14:01 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-13 14:01 [PATCH v2 00/20] powerpc: Convert power off logic to pm_power_off Alexander Graf
2014-10-13 14:01 ` [PATCH v2 01/20] powerpc: Support override of pm_power_off Alexander Graf
2014-10-13 14:01 ` [PATCH v2 02/20] powerpc/xmon: Support either ppc_md.power_off or pm_power_off Alexander Graf
2014-10-13 14:01 ` [PATCH v2 03/20] powerpc/47x: Use pm_power_off rather than ppc_md.power_off Alexander Graf
2014-10-13 14:01 ` [PATCH v2 04/20] powerpc/52xx/efika: " Alexander Graf
2014-10-13 14:01 ` [PATCH v2 05/20] powerpc/mpc8349emitx: " Alexander Graf
2014-10-13 14:01 ` [PATCH v2 06/20] powerpc/corenet: " Alexander Graf
2014-10-13 14:01 ` [PATCH v2 07/20] powerpc/85xx/sgy_cts1000: " Alexander Graf
2014-10-13 14:01 ` [PATCH v2 08/20] powerpc/celleb: " Alexander Graf
2014-10-13 14:01 ` [PATCH v2 09/20] powerpc/cell/qpace: " Alexander Graf
2014-10-13 14:01 ` [PATCH v2 10/20] powerpc/cell: " Alexander Graf
2014-10-13 14:01 ` [PATCH v2 11/20] powerpc/chrp: " Alexander Graf
2014-10-13 14:01 ` [PATCH v2 12/20] powerpc/6xx/gamecube: " Alexander Graf
2014-10-13 14:01 ` [PATCH v2 13/20] powerpc/6xx/linkstation: " Alexander Graf
2014-10-13 14:01 ` [PATCH v2 14/20] powerpc/6xx/wii: " Alexander Graf
2014-10-13 14:01 ` [PATCH v2 15/20] powerpc/maple: " Alexander Graf
2014-10-13 14:01 ` Alexander Graf [this message]
2014-10-13 14:01 ` [PATCH v2 17/20] powerpc/powernv: " Alexander Graf
2014-10-13 14:01 ` [PATCH v2 18/20] powerpc/ps3: " Alexander Graf
2014-10-13 14:01 ` [PATCH v2 19/20] powerpc/pseries: " Alexander Graf
2014-10-13 14:01 ` [PATCH v2 20/20] powerpc: Remove ppc_md.power_off Alexander Graf
2014-10-13 15:47 ` [PATCH v2 00/20] powerpc: Convert power off logic to pm_power_off Guenter Roeck
2014-10-13 15:54 ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1413208888-49211-17-git-send-email-agraf@suse.de \
    --to=agraf@suse.de \
    --cc=agust@denx.de \
    --cc=alistair@popple.id.au \
    --cc=arnd@arndb.de \
    --cc=geoff@infradead.org \
    --cc=linux@roeck-us.net \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=scottwood@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).