linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: linuxppc-dev@ozlabs.org, Dave Airlie <airlied@linux.ie>,
	Linux PCI <linux-pci@vger.kernel.org>,
	Anton Blanchard <anton@au1.ibm.com>, Takashi Iwai <tiwai@suse.de>,
	Yijing Wang <wangyijing@huawei.com>,
	Brian King <brking@linux.vnet.ibm.com>,
	Alex Deucher <alexdeucher@gmail.com>
Subject: Re: [PATCH v3 4/7] sound/radeon: Add quirk for broken 64-bit MSI
Date: Thu, 16 Oct 2014 09:55:32 +1100	[thread overview]
Message-ID: <1413413732.11213.27.camel@pasglop> (raw)
In-Reply-To: <20141015221914.GD15225@google.com>

On Wed, 2014-10-15 at 16:19 -0600, Bjorn Helgaas wrote:
>   PCI/MSI: Add device flag indicating that 64-bit MSIs don't work
> 
> I'd be happy to merge it, but given what I know now, I would wait and merge
> it during the v3.19 merge window.  It sounds like it's more urgent than
> that and should be merged earlier, but from the changelogs, it looks like
> we're just replacing the powerpc-specific quirk with a more generic one.
> 
> So I assume you'll merge it via powerpc unless I hear otherwise.

Either way works but it's easy to keep it all in one series in one tree.

The urgency is that the current powerpc quirk works only with one specific
card (ie, one device ID for gfx and one for audio) and misses the DMA limitation
of the sound driver (which is a somewhat orthogonal issue but the patch for it is
in the series).

Any other radeon card causes the machine to crash at boot (the driver doesn't
recover well from the EEH error triggered by the bad MSI address and the world
falls over from there).

So I want this to go back into distros.

Cheers,
Ben.

  reply	other threads:[~2014-10-15 22:56 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-07  4:38 [PATCH v3 4/7] sound/radeon: Add quirk for broken 64-bit MSI Benjamin Herrenschmidt
2014-10-07 23:47 ` Alex Deucher
2014-10-07 23:49   ` Benjamin Herrenschmidt
2014-10-08  0:18     ` Alex Deucher
2014-10-08  5:28   ` Benjamin Herrenschmidt
2014-10-08  6:23     ` Alex Deucher
2014-10-08  6:59     ` Takashi Iwai
2014-10-13 20:11     ` Benjamin Herrenschmidt
2014-10-13 20:39       ` Alex Deucher
2014-10-13 20:46       ` Bjorn Helgaas
2014-10-15 22:19     ` Bjorn Helgaas
2014-10-15 22:55       ` Benjamin Herrenschmidt [this message]
2014-11-11 21:12         ` Bjorn Helgaas
2014-11-12  2:23           ` Michael Ellerman
2014-11-12  4:06             ` Benjamin Herrenschmidt
2014-11-12  4:09               ` Bjorn Helgaas
2014-11-13  5:19               ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1413413732.11213.27.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=airlied@linux.ie \
    --cc=alexdeucher@gmail.com \
    --cc=anton@au1.ibm.com \
    --cc=bhelgaas@google.com \
    --cc=brking@linux.vnet.ibm.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=tiwai@suse.de \
    --cc=wangyijing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).