From: Michael Neuling <mikey@neuling.org>
To: Anton Blanchard <anton@samba.org>
Cc: mikey@neuling.org, paulus@samba.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/pseries: Quieten relocation on exceptions warning
Date: Mon, 20 Oct 2014 10:03:18 +1100 [thread overview]
Message-ID: <1413759798.8865.117.camel@ale.ozlabs.ibm.com> (raw)
In-Reply-To: <1413755489-28682-1-git-send-email-anton@samba.org>
> The hypervisor returns H_P2 if relocation on exceptions are
> not supported. If we get this, just print a lower priority
> informational message.
Can you add something about why this is needed? Something about
h_set_mode being available so we can enable LE but not supporting any of
the other calls like AIL?
Mikey
> Signed-off-by: Anton Blanchard <anton@samba.org>
> ---
> arch/powerpc/platforms/pseries/setup.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>=20
> diff --git a/arch/powerpc/platforms/pseries/setup.c b/arch/powerpc/platfo=
rms/pseries/setup.c
> index 125c589..fcc9227 100644
> --- a/arch/powerpc/platforms/pseries/setup.c
> +++ b/arch/powerpc/platforms/pseries/setup.c
> @@ -499,7 +499,11 @@ static void __init pSeries_setup_arch(void)
> =20
> if (firmware_has_feature(FW_FEATURE_SET_MODE)) {
> long rc;
> - if ((rc =3D pSeries_enable_reloc_on_exc()) !=3D H_SUCCESS) {
> +
> + rc =3D pSeries_enable_reloc_on_exc();
> + if (rc =3D=3D H_P2) {
> + pr_info("Relocation on exceptions not supported\n");
> + } else if (rc !=3D H_SUCCESS) {
> pr_warn("Unable to enable relocation on exceptions: "
> "%ld\n", rc);
> }
next prev parent reply other threads:[~2014-10-19 23:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-19 21:51 [PATCH] powerpc/pseries: Quieten relocation on exceptions warning Anton Blanchard
2014-10-19 23:03 ` Michael Neuling [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-11-02 21:34 Anton Blanchard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1413759798.8865.117.camel@ale.ozlabs.ibm.com \
--to=mikey@neuling.org \
--cc=anton@samba.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).