From: "Ian Munsie" <imunsie@au1.ibm.com>
To: mpe <mpe@ellerman.id.au>
Cc: cbe-oss-dev <cbe-oss-dev@lists.ozlabs.org>,
mikey <mikey@neuling.org>, arnd <arnd@arndb.de>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
greg <greg@kroah.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
linuxppc-dev <linuxppc-dev@ozlabs.org>, anton <anton@samba.org>,
imunsie <imunsie@au1.ibm.com>, jk <jk@ozlabs.org>
Subject: [PATCH v2 3/4] powerpc/copro: Use appropriate ESID mask in copro_calculate_slb
Date: Tue, 28 Oct 2014 14:25:29 +1100 [thread overview]
Message-ID: <1414466730-15591-4-git-send-email-imunsie@au.ibm.com> (raw)
In-Reply-To: <1414466730-15591-1-git-send-email-imunsie@au.ibm.com>
From: Ian Munsie <imunsie@au1.ibm.com>
This patch makes copro_calculate_slb mask the ESID by the correct mask
for 1T vs 256M segments.
This has no effect by itself as the extra bits were ignored, but it
makes debugging the segment table entries easier and means that we can
directly compare the ESID values for duplicates without needing to worry
about masking in the comparison.
This will be used to simplify a comparison in the following patch.
Signed-off-by: Ian Munsie <imunsie@au1.ibm.com>
---
arch/powerpc/mm/copro_fault.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/powerpc/mm/copro_fault.c b/arch/powerpc/mm/copro_fault.c
index 0f9939e..5a236f0 100644
--- a/arch/powerpc/mm/copro_fault.c
+++ b/arch/powerpc/mm/copro_fault.c
@@ -99,8 +99,6 @@ int copro_calculate_slb(struct mm_struct *mm, u64 ea, struct copro_slb *slb)
u64 vsid;
int psize, ssize;
- slb->esid = (ea & ESID_MASK) | SLB_ESID_V;
-
switch (REGION_ID(ea)) {
case USER_REGION_ID:
pr_devel("%s: 0x%llx -- USER_REGION_ID\n", __func__, ea);
@@ -133,6 +131,7 @@ int copro_calculate_slb(struct mm_struct *mm, u64 ea, struct copro_slb *slb)
vsid |= mmu_psize_defs[psize].sllp |
((ssize == MMU_SEGSIZE_1T) ? SLB_VSID_B_1T : 0);
+ slb->esid = (ea & (ssize == MMU_SEGSIZE_1T ? ESID_MASK_1T : ESID_MASK)) | SLB_ESID_V;
slb->vsid = vsid;
return 0;
--
2.1.1
next prev parent reply other threads:[~2014-10-28 3:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-28 3:25 [PATCH v2] CXL: Fix PSL error due to duplicate segment table entries Ian Munsie
2014-10-28 3:25 ` [PATCH v2 1/4] CXL: Disable secondary hash in segment table Ian Munsie
2014-10-28 8:12 ` Aneesh Kumar K.V
2014-10-28 3:25 ` [PATCH v2 2/4] CXL: Refactor cxl_load_segment and find_free_sste Ian Munsie
2014-10-28 8:13 ` Aneesh Kumar K.V
2014-10-28 3:25 ` Ian Munsie [this message]
2014-10-28 8:13 ` [PATCH v2 3/4] powerpc/copro: Use appropriate ESID mask in copro_calculate_slb Aneesh Kumar K.V
2014-10-28 3:25 ` [PATCH v2 4/4] CXL: Fix PSL error due to duplicate segment table entries Ian Munsie
2014-10-28 8:16 ` Aneesh Kumar K.V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1414466730-15591-4-git-send-email-imunsie@au.ibm.com \
--to=imunsie@au1.ibm.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=anton@samba.org \
--cc=arnd@arndb.de \
--cc=cbe-oss-dev@lists.ozlabs.org \
--cc=greg@kroah.com \
--cc=jk@ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mikey@neuling.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).