From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 74B4B1A0063 for ; Wed, 29 Oct 2014 14:04:26 +1100 (AEDT) Message-ID: <1414551853.7417.1.camel@concordia> Subject: Re: [PATCH] drivers: depend on instead of select BACKLIGHT_CLASS_DEVICE and ACPI_VIDEO From: Michael Ellerman To: Randy Dunlap Date: Wed, 29 Oct 2014 14:04:13 +1100 In-Reply-To: <544FFC91.9040104@infradead.org> References: <1413580403-16225-1-git-send-email-jani.nikula@intel.com> <54476492.6090105@ti.com> <87a94hu3j0.fsf@intel.com> <544E44E9.4040208@ti.com> <544FFC91.9040104@infradead.org> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Cc: linux-fbdev@vger.kernel.org, linux-usb@vger.kernel.org, Daniel Drake , Jens Frederich , Jani Nikula , Greg Kroah-Hartman , Jon Nettleton , Jingoo Han , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, platform-driver-x86@vger.kernel.org, Bryan Wu , David Airlie , Tomi Valkeinen , Laurent Pinchart , Daniel Vetter , Darren Hart , Lee Jones , linuxppc-dev@lists.ozlabs.org, Jean-Christophe Plagniol-Villard List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 2014-10-28 at 13:29 -0700, Randy Dunlap wrote: > On 10/27/14 06:13, Tomi Valkeinen wrote: > > I also think the 'depends on BACKLIGHT_CLASS_DEVICE || > > BACKLIGHT_CLASS_DEVICE=n' pattern is quite... interesting (i.e. sounds > > like a hack to me =). > > It does exactly what is needed and it is used in many places in kernel > Kconfig files. Is there any reason you can't do: depends on BACKLIGHT_CLASS_DEVICE != m cheers