From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Anton Blanchard <anton@samba.org>
Cc: paulus@samba.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/pseries: Quieten ibm,pcie-link-speed-stats warning
Date: Fri, 31 Oct 2014 17:27:59 +1100 [thread overview]
Message-ID: <1414736879.28356.51.camel@pasglop> (raw)
In-Reply-To: <1414731901-2096-1-git-send-email-anton@samba.org>
On Fri, 2014-10-31 at 16:05 +1100, Anton Blanchard wrote:
> The ibm,pcie-link-speed-stats isn't mandatory, so we shouldn't print
> a high priority error message when missing. One example where we see
> this is QEMU.
>
> Reduce it to pr_info.
I would reduce it even further to pr_dbg.
Cheers,
Ben.
> Signed-off-by: Anton Blanchard <anton@samba.org>
> ---
> arch/powerpc/platforms/pseries/pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/platforms/pseries/pci.c b/arch/powerpc/platforms/pseries/pci.c
> index 67e4859..57dd7a0 100644
> --- a/arch/powerpc/platforms/pseries/pci.c
> +++ b/arch/powerpc/platforms/pseries/pci.c
> @@ -134,7 +134,7 @@ int pseries_root_bridge_prepare(struct pci_host_bridge *bridge)
> of_node_put(pdn);
>
> if (rc) {
> - pr_err("no ibm,pcie-link-speed-stats property\n");
> + pr_info("no ibm,pcie-link-speed-stats property\n");
> return 0;
> }
>
next prev parent reply other threads:[~2014-10-31 6:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-31 5:05 [PATCH] powerpc/pseries: Quieten ibm,pcie-link-speed-stats warning Anton Blanchard
2014-10-31 6:27 ` Benjamin Herrenschmidt [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-11-02 21:18 Anton Blanchard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1414736879.28356.51.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=anton@samba.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).