* [PATCH] powerpc/pseries: Quieten ibm,pcie-link-speed-stats warning
@ 2014-10-31 5:05 Anton Blanchard
2014-10-31 6:27 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 3+ messages in thread
From: Anton Blanchard @ 2014-10-31 5:05 UTC (permalink / raw)
To: benh, paulus, mpe; +Cc: linuxppc-dev
The ibm,pcie-link-speed-stats isn't mandatory, so we shouldn't print
a high priority error message when missing. One example where we see
this is QEMU.
Reduce it to pr_info.
Signed-off-by: Anton Blanchard <anton@samba.org>
---
arch/powerpc/platforms/pseries/pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/pseries/pci.c b/arch/powerpc/platforms/pseries/pci.c
index 67e4859..57dd7a0 100644
--- a/arch/powerpc/platforms/pseries/pci.c
+++ b/arch/powerpc/platforms/pseries/pci.c
@@ -134,7 +134,7 @@ int pseries_root_bridge_prepare(struct pci_host_bridge *bridge)
of_node_put(pdn);
if (rc) {
- pr_err("no ibm,pcie-link-speed-stats property\n");
+ pr_info("no ibm,pcie-link-speed-stats property\n");
return 0;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] powerpc/pseries: Quieten ibm,pcie-link-speed-stats warning
2014-10-31 5:05 [PATCH] powerpc/pseries: Quieten ibm,pcie-link-speed-stats warning Anton Blanchard
@ 2014-10-31 6:27 ` Benjamin Herrenschmidt
0 siblings, 0 replies; 3+ messages in thread
From: Benjamin Herrenschmidt @ 2014-10-31 6:27 UTC (permalink / raw)
To: Anton Blanchard; +Cc: paulus, linuxppc-dev
On Fri, 2014-10-31 at 16:05 +1100, Anton Blanchard wrote:
> The ibm,pcie-link-speed-stats isn't mandatory, so we shouldn't print
> a high priority error message when missing. One example where we see
> this is QEMU.
>
> Reduce it to pr_info.
I would reduce it even further to pr_dbg.
Cheers,
Ben.
> Signed-off-by: Anton Blanchard <anton@samba.org>
> ---
> arch/powerpc/platforms/pseries/pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/platforms/pseries/pci.c b/arch/powerpc/platforms/pseries/pci.c
> index 67e4859..57dd7a0 100644
> --- a/arch/powerpc/platforms/pseries/pci.c
> +++ b/arch/powerpc/platforms/pseries/pci.c
> @@ -134,7 +134,7 @@ int pseries_root_bridge_prepare(struct pci_host_bridge *bridge)
> of_node_put(pdn);
>
> if (rc) {
> - pr_err("no ibm,pcie-link-speed-stats property\n");
> + pr_info("no ibm,pcie-link-speed-stats property\n");
> return 0;
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] powerpc/pseries: Quieten ibm,pcie-link-speed-stats warning
@ 2014-11-02 21:18 Anton Blanchard
0 siblings, 0 replies; 3+ messages in thread
From: Anton Blanchard @ 2014-11-02 21:18 UTC (permalink / raw)
To: benh, paulus, mpe; +Cc: linuxppc-dev
The ibm,pcie-link-speed-stats isn't mandatory, so we shouldn't print
a high priority error message when missing. One example where we see
this is QEMU.
Reduce it to pr_debug.
Signed-off-by: Anton Blanchard <anton@samba.org>
---
arch/powerpc/platforms/pseries/pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/pseries/pci.c b/arch/powerpc/platforms/pseries/pci.c
index 67e4859..fe16a50 100644
--- a/arch/powerpc/platforms/pseries/pci.c
+++ b/arch/powerpc/platforms/pseries/pci.c
@@ -134,7 +134,7 @@ int pseries_root_bridge_prepare(struct pci_host_bridge *bridge)
of_node_put(pdn);
if (rc) {
- pr_err("no ibm,pcie-link-speed-stats property\n");
+ pr_debug("no ibm,pcie-link-speed-stats property\n");
return 0;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-11-02 21:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-31 5:05 [PATCH] powerpc/pseries: Quieten ibm,pcie-link-speed-stats warning Anton Blanchard
2014-10-31 6:27 ` Benjamin Herrenschmidt
-- strict thread matches above, loose matches on Subject: below --
2014-11-02 21:18 Anton Blanchard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).