linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Paul Bolle <pebolle@tiscali.nl>
To: Scott Wood <scottwood@freescale.com>
Cc: linux-kernel@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: powerpc/8xx: Remove Kconfig symbol FADS
Date: Fri, 07 Nov 2014 09:48:43 +0100	[thread overview]
Message-ID: <1415350123.4390.43.camel@x220> (raw)
In-Reply-To: <20141107035008.GA25204@home.buserror.net>

On Thu, 2014-11-06 at 21:50 -0600, Scott Wood wrote:
> On Wed, Sep 24, 2014 at 10:06:19AM +0200, Paul Bolle wrote: 
> > Another cleanup might be to remove MPC8XXFADS (or "FADS") from the "8xx
> > Machine Type" choice. Is there any reason left to pick "FADS" as a
> > machine type?
> 
> Nothing references MPC8XXFADS, so yes, it can be removed.

I'll try to look into this. For the (verbose) reasons below I'll do that
in a separate patch, if I ever get that far. What follows is mostly a
note to self.

MPC8XXFADS is indeed not referenced anywhere. But it's one of the
entries in the "8xx Machine Type" choice. And it's common for choice
blocks the have a "none of the above" entry. Ie, an entry that allows to
configure nothing. There's a chance MPC8XXFADS is currently used for
that role. (This is easier to determine for people that - unlike me -
know what all the symbols in this choice mean. To me they 're basically
random strings.)

Actually, there's an obscure "optional" Kconfig keyword that appears to
be added to take care of this use case. It's currently used exactly
twice in the tree, in smaller architectures: once in arch/avr32/ and
once in arch/sh/. This implies this "optional" keyword is used very
little. I'll have to look carefully to see whether it works as
advertised.


Paul Bolle

  reply	other threads:[~2014-11-07  8:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-24  8:06 [PATCH] powerpc/8xx: Remove Kconfig symbol FADS Paul Bolle
2014-11-07  3:50 ` Scott Wood
2014-11-07  8:48   ` Paul Bolle [this message]
2014-11-08  0:22     ` Scott Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1415350123.4390.43.camel@x220 \
    --to=pebolle@tiscali.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=paulus@samba.org \
    --cc=scottwood@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).