From: Michael Ellerman <mpe@ellerman.id.au>
To: Guenter Roeck <linux@roeck-us.net>
Cc: benh@au1.ibm.com, michaele@au1.ibm.com,
linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org,
Neelesh Gupta <neelegup@linux.vnet.ibm.com>,
linuxppc-dev@lists.ozlabs.org, jdelvare@suse.de
Subject: Re: [PATCH v2] hwmon: (ibmpowernv) Use platform 'id_table' to probe the device
Date: Mon, 10 Nov 2014 10:04:57 +1100 [thread overview]
Message-ID: <1415574297.29291.3.camel@concordia> (raw)
In-Reply-To: <20141105142149.GA23212@roeck-us.net>
On Wed, 2014-11-05 at 06:21 -0800, Guenter Roeck wrote:
> On Wed, Nov 05, 2014 at 04:45:14PM +0530, Neelesh Gupta wrote:
> > The current driver probe() function assumes the sensor device to be
> > alwary present and gets executed every time if the driver is loaded,
> > but the appropriate hardware could not be present.
> >
> > So, move the platform device creation as part of platform init code
> > and use the 'id_table' to check if the device present or not.
> >
> > Signed-off-by: Neelesh Gupta <neelegup@linux.vnet.ibm.com>
>
> Looks good. We'll need an ack from one of the powerpc maintainers to proceed.
Looks OK to me.
Acked-by: Michael Ellerman <mpe@ellerman.id.au>
cheers
next prev parent reply other threads:[~2014-11-09 23:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20141105110848.6183.55611.stgit@localhost.localdomain>
2014-11-05 14:21 ` [PATCH v2] hwmon: (ibmpowernv) Use platform 'id_table' to probe the device Guenter Roeck
2014-11-09 23:04 ` Michael Ellerman [this message]
2014-11-11 18:37 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415574297.29291.3.camel@concordia \
--to=mpe@ellerman.id.au \
--cc=benh@au1.ibm.com \
--cc=jdelvare@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lm-sensors@lm-sensors.org \
--cc=michaele@au1.ibm.com \
--cc=neelegup@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).