[PATCH] DT: add MDIO node for FMan node

[PATCH] DT: add MDIO node for FMan node

[shh.xie]

From: Shaohui Xie <Shaohui.Xie@freescale.com>

This binding is for FMan MDIO, it covers FMan v2 & FMan v3.

Signed-off-by: Shaohui Xie <Shaohui.Xie@freescale.com>
---
based on http://patchwork.ozlabs.org/patch/390351/
for 'next' of git://git.kernel.org/pub/scm/linux/kernel/git/scottwood/linux.git

 .../devicetree/bindings/powerpc/fsl/fman.txt       | 69 ++++++++++++++++++++++
 1 file changed, 69 insertions(+)

diff --git a/Documentation/devicetree/bindings/powerpc/fsl/fman.txt b/Documentation/devicetree/bindings/powerpc/fsl/fman.txt
index da8e5f2..83c2f14 100644
--- a/Documentation/devicetree/bindings/powerpc/fsl/fman.txt
+++ b/Documentation/devicetree/bindings/powerpc/fsl/fman.txt
@@ -7,6 +7,7 @@ CONTENTS
   - FMan MURAM Node
   - FMan dTSEC/XGEC/mEMAC Node
   - FMan IEEE 1588 Node
+  - FMan MDIO Node
   - Example
 
 =============================================================================
@@ -352,6 +353,67 @@ ptp-timer@fe000 {
 };
 
 =============================================================================
+FMan MDIO Node
+
+DESCRIPTION
+
+The MDIO is a bus to which the PHY devices are connected.
+
+PROPERTIES
+
+- compatible
+		Usage: required
+		Value type: <stringlist>
+		Definition: A standard property.
+		Must include "fsl,fman-mdio" for 1 Gb/s MDIO from FMan v2.
+		Must include "fsl,fman-xmdio" for 10 Gb/s MDIO from FMan v2.
+		Must include "fsl,fman-memac-mdio" for 1/10 Gb/s MDIO from
+		FMan v3.
+
+- reg
+		Usage: required
+		Value type: <prop-encoded-array>
+		Definition: A standard property.
+
+- bus-frequency
+		Usage: optional
+		Value type: <u32>
+		Definition: Default MDIO bus clock speed.
+
+- interrupts
+		Usage: optional
+		Value type: <prop-encoded-array>
+		Definition: MDIO controller event interrupts.
+
+- type
+		Usage: required for FMan v3
+		Value type: <stringlist>
+		Definition: A standard property.
+		FMan v3 has internal MDIO for internal PCS(Physical Coding
+		Sublayer) PHYs and external MDIO for external PHYs.
+		The settings and programming routines for internal/external
+		MDIO are different. Must include "internal" for internal MDIO,
+		must include "external" for external MDIO.
+
+EXAMPLE
+
+Example for FMan v2:
+
+mdio@f1000 {
+	compatible = "fsl,fman-xmdio";
+	reg = <0xf1000 0x1000>;
+};
+
+Example for FMan v3:
+
+mdio@fd000 {
+	compatible = "fsl,fman-memac-mdio";
+	reg = <0xfd000 0x1000>;
+	bus-frequency = <2500000>;
+	type = "external";
+};
+
+=============================================================================
 Example
 
 fman@400000 {
@@ -526,4 +588,11 @@ fman@400000 {
 		compatible = "fsl,fman-ptp-timer";
 		reg = <0xfe000 0x1000>;
 	};
+
+	mdio@fd000 {
+		compatible = "fsl,fman-memac-mdio";
+		reg = <0xfd000 0x1000>;
+		bus-frequency = <2500000>;
+		type = "external";
+	};
 };
-- 
1.8.4.1

RE: [PATCH] DT: add MDIO node for FMan node

[Shaohui Xie]

Ping.

Best Regards,=20
Shaohui Xie

> -----Original Message-----
> From: shh.xie@gmail.com [mailto:shh.xie@gmail.com]
> Sent: Tuesday, November 04, 2014 7:57 PM
> To: linuxppc-dev@lists.ozlabs.org; devicetree@vger.kernel.org; Wood
> Scott-B07421
> Cc: Medve Emilian-EMMEDVE1; Xie Shaohui-B21989
> Subject: [PATCH] DT: add MDIO node for FMan node
>=20
> From: Shaohui Xie <Shaohui.Xie@freescale.com>
>=20
> This binding is for FMan MDIO, it covers FMan v2 & FMan v3.
>=20
> Signed-off-by: Shaohui Xie <Shaohui.Xie@freescale.com>
> ---
> based on http://patchwork.ozlabs.org/patch/390351/
> for 'next' of
> git://git.kernel.org/pub/scm/linux/kernel/git/scottwood/linux.git
>=20
>  .../devicetree/bindings/powerpc/fsl/fman.txt       | 69
> ++++++++++++++++++++++
>  1 file changed, 69 insertions(+)
>=20
> diff --git a/Documentation/devicetree/bindings/powerpc/fsl/fman.txt
> b/Documentation/devicetree/bindings/powerpc/fsl/fman.txt
> index da8e5f2..83c2f14 100644
> --- a/Documentation/devicetree/bindings/powerpc/fsl/fman.txt
> +++ b/Documentation/devicetree/bindings/powerpc/fsl/fman.txt
> @@ -7,6 +7,7 @@ CONTENTS
>    - FMan MURAM Node
>    - FMan dTSEC/XGEC/mEMAC Node
>    - FMan IEEE 1588 Node
> +  - FMan MDIO Node
>    - Example
>=20
>=20
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> =3D=3D=3D=3D
> @@ -352,6 +353,67 @@ ptp-timer@fe000 {
>  };
>=20
>=20
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> =3D=3D=3D=3D
> +FMan MDIO Node
> +
> +DESCRIPTION
> +
> +The MDIO is a bus to which the PHY devices are connected.
> +
> +PROPERTIES
> +
> +- compatible
> +		Usage: required
> +		Value type: <stringlist>
> +		Definition: A standard property.
> +		Must include "fsl,fman-mdio" for 1 Gb/s MDIO from FMan v2.
> +		Must include "fsl,fman-xmdio" for 10 Gb/s MDIO from FMan v2.
> +		Must include "fsl,fman-memac-mdio" for 1/10 Gb/s MDIO from
> +		FMan v3.
> +
> +- reg
> +		Usage: required
> +		Value type: <prop-encoded-array>
> +		Definition: A standard property.
> +
> +- bus-frequency
> +		Usage: optional
> +		Value type: <u32>
> +		Definition: Default MDIO bus clock speed.
> +
> +- interrupts
> +		Usage: optional
> +		Value type: <prop-encoded-array>
> +		Definition: MDIO controller event interrupts.
> +
> +- type
> +		Usage: required for FMan v3
> +		Value type: <stringlist>
> +		Definition: A standard property.
> +		FMan v3 has internal MDIO for internal PCS(Physical Coding
> +		Sublayer) PHYs and external MDIO for external PHYs.
> +		The settings and programming routines for internal/external
> +		MDIO are different. Must include "internal" for internal MDIO,
> +		must include "external" for external MDIO.
> +
> +EXAMPLE
> +
> +Example for FMan v2:
> +
> +mdio@f1000 {
> +	compatible =3D "fsl,fman-xmdio";
> +	reg =3D <0xf1000 0x1000>;
> +};
> +
> +Example for FMan v3:
> +
> +mdio@fd000 {
> +	compatible =3D "fsl,fman-memac-mdio";
> +	reg =3D <0xfd000 0x1000>;
> +	bus-frequency =3D <2500000>;
> +	type =3D "external";
> +};
> +
> +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> =3D=3D=3D=3D=3D
>  Example
>=20
>  fman@400000 {
> @@ -526,4 +588,11 @@ fman@400000 {
>  		compatible =3D "fsl,fman-ptp-timer";
>  		reg =3D <0xfe000 0x1000>;
>  	};
> +
> +	mdio@fd000 {
> +		compatible =3D "fsl,fman-memac-mdio";
> +		reg =3D <0xfd000 0x1000>;
> +		bus-frequency =3D <2500000>;
> +		type =3D "external";
> +	};
>  };
> --
> 1.8.4.1

Re: [PATCH] DT: add MDIO node for FMan node

[Scott Wood]

On Tue, 2014-11-04 at 19:56 +0800, shh.xie@gmail.com wrote:
> From: Shaohui Xie <Shaohui.Xie@freescale.com>
> 
> This binding is for FMan MDIO, it covers FMan v2 & FMan v3.
> 
> Signed-off-by: Shaohui Xie <Shaohui.Xie@freescale.com>
> ---
> based on http://patchwork.ozlabs.org/patch/390351/
> for 'next' of git://git.kernel.org/pub/scm/linux/kernel/git/scottwood/linux.git

Are there any other FMan pieces that are missing from the above patch?

>  .../devicetree/bindings/powerpc/fsl/fman.txt       | 69 ++++++++++++++++++++++
>  1 file changed, 69 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/powerpc/fsl/fman.txt b/Documentation/devicetree/bindings/powerpc/fsl/fman.txt
> index da8e5f2..83c2f14 100644
> --- a/Documentation/devicetree/bindings/powerpc/fsl/fman.txt
> +++ b/Documentation/devicetree/bindings/powerpc/fsl/fman.txt
> @@ -7,6 +7,7 @@ CONTENTS
>    - FMan MURAM Node
>    - FMan dTSEC/XGEC/mEMAC Node
>    - FMan IEEE 1588 Node
> +  - FMan MDIO Node
>    - Example
>  
>  =============================================================================
> @@ -352,6 +353,67 @@ ptp-timer@fe000 {
>  };
>  
>  =============================================================================
> +FMan MDIO Node
> +
> +DESCRIPTION
> +
> +The MDIO is a bus to which the PHY devices are connected.
> +
> +PROPERTIES
> +
> +- compatible
> +		Usage: required
> +		Value type: <stringlist>
> +		Definition: A standard property.
> +		Must include "fsl,fman-mdio" for 1 Gb/s MDIO from FMan v2.
> +		Must include "fsl,fman-xmdio" for 10 Gb/s MDIO from FMan v2.
> +		Must include "fsl,fman-memac-mdio" for 1/10 Gb/s MDIO from
> +		FMan v3.
> +
> +- reg
> +		Usage: required
> +		Value type: <prop-encoded-array>
> +		Definition: A standard property.
> +
> +- bus-frequency
> +		Usage: optional
> +		Value type: <u32>
> +		Definition: Default MDIO bus clock speed.

Use clocks/clock-names

> +- interrupts
> +		Usage: optional
> +		Value type: <prop-encoded-array>
> +		Definition: MDIO controller event interrupts.

One interrupt or multiple?

> +
> +- type
> +		Usage: required for FMan v3
> +		Value type: <stringlist>
> +		Definition: A standard property.

What standard is "type" defined in?

> +		FMan v3 has internal MDIO for internal PCS(Physical Coding
> +		Sublayer) PHYs and external MDIO for external PHYs.
> +		The settings and programming routines for internal/external
> +		MDIO are different. Must include "internal" for internal MDIO,
> +		must include "external" for external MDIO.

I assume fman v2 is always internal?  How about a boolean
"fsl,fman-internal-phy" property instead?

> +
> +EXAMPLE
> +
> +Example for FMan v2:
> +
> +mdio@f1000 {
> +	compatible = "fsl,fman-xmdio";
> +	reg = <0xf1000 0x1000>;
> +};
> +
> +Example for FMan v3:
> +
> +mdio@fd000 {
> +	compatible = "fsl,fman-memac-mdio";
> +	reg = <0xfd000 0x1000>;
> +	bus-frequency = <2500000>;
> +	type = "external";
> +};
> +
> +=============================================================================
>  Example
>  
>  fman@400000 {
> @@ -526,4 +588,11 @@ fman@400000 {
>  		compatible = "fsl,fman-ptp-timer";
>  		reg = <0xfe000 0x1000>;
>  	};
> +
> +	mdio@fd000 {
> +		compatible = "fsl,fman-memac-mdio";
> +		reg = <0xfd000 0x1000>;
> +		bus-frequency = <2500000>;
> +		type = "external";
> +	};
>  };

The rest of the example is fman v2; don't mix an fman v3 node in with
that.

-Scott

RE: [PATCH] DT: add MDIO node for FMan node

[Shaohui Xie]

PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBXb29kIFNjb3R0LUIwNzQyMQ0K
PiBTZW50OiBUdWVzZGF5LCBOb3ZlbWJlciAxMSwgMjAxNCA4OjIzIEFNDQo+IFRvOiBzaGgueGll
QGdtYWlsLmNvbQ0KPiBDYzogbGludXhwcGMtZGV2QGxpc3RzLm96bGFicy5vcmc7IGRldmljZXRy
ZWVAdmdlci5rZXJuZWwub3JnOyBNZWR2ZQ0KPiBFbWlsaWFuLUVNTUVEVkUxOyBYaWUgU2hhb2h1
aS1CMjE5ODkNCj4gU3ViamVjdDogUmU6IFtQQVRDSF0gRFQ6IGFkZCBNRElPIG5vZGUgZm9yIEZN
YW4gbm9kZQ0KPiANCj4gT24gVHVlLCAyMDE0LTExLTA0IGF0IDE5OjU2ICswODAwLCBzaGgueGll
QGdtYWlsLmNvbSB3cm90ZToNCj4gPiBGcm9tOiBTaGFvaHVpIFhpZSA8U2hhb2h1aS5YaWVAZnJl
ZXNjYWxlLmNvbT4NCj4gPg0KPiA+IFRoaXMgYmluZGluZyBpcyBmb3IgRk1hbiBNRElPLCBpdCBj
b3ZlcnMgRk1hbiB2MiAmIEZNYW4gdjMuDQo+ID4NCj4gPiBTaWduZWQtb2ZmLWJ5OiBTaGFvaHVp
IFhpZSA8U2hhb2h1aS5YaWVAZnJlZXNjYWxlLmNvbT4NCj4gPiAtLS0NCj4gPiBiYXNlZCBvbiBo
dHRwOi8vcGF0Y2h3b3JrLm96bGFicy5vcmcvcGF0Y2gvMzkwMzUxLw0KPiA+IGZvciAnbmV4dCcg
b2YNCj4gPiBnaXQ6Ly9naXQua2VybmVsLm9yZy9wdWIvc2NtL2xpbnV4L2tlcm5lbC9naXQvc2Nv
dHR3b29kL2xpbnV4LmdpdA0KPiANCj4gQXJlIHRoZXJlIGFueSBvdGhlciBGTWFuIHBpZWNlcyB0
aGF0IGFyZSBtaXNzaW5nIGZyb20gdGhlIGFib3ZlIHBhdGNoPw0KW1MuSF0gSSdtIGFkZGluZyBJ
Z2FsIGZvciB0aGlzIGNvbW1lbnQuDQoNCj4gDQo+ID4gIC4uLi9kZXZpY2V0cmVlL2JpbmRpbmdz
L3Bvd2VycGMvZnNsL2ZtYW4udHh0ICAgICAgIHwgNjkNCj4gKysrKysrKysrKysrKysrKysrKysr
Kw0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgNjkgaW5zZXJ0aW9ucygrKQ0KPiA+DQo+ID4gZGlmZiAt
LWdpdCBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9wb3dlcnBjL2ZzbC9mbWFu
LnR4dA0KPiA+IGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3Bvd2VycGMvZnNs
L2ZtYW4udHh0DQo+ID4gaW5kZXggZGE4ZTVmMi4uODNjMmYxNCAxMDA2NDQNCj4gPiAtLS0gYS9E
b2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcG93ZXJwYy9mc2wvZm1hbi50eHQNCj4g
PiArKysgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcG93ZXJwYy9mc2wvZm1h
bi50eHQNCj4gPiBAQCAtNyw2ICs3LDcgQEAgQ09OVEVOVFMNCj4gPiAgICAtIEZNYW4gTVVSQU0g
Tm9kZQ0KPiA+ICAgIC0gRk1hbiBkVFNFQy9YR0VDL21FTUFDIE5vZGUNCj4gPiAgICAtIEZNYW4g
SUVFRSAxNTg4IE5vZGUNCj4gPiArICAtIEZNYW4gTURJTyBOb2RlDQo+ID4gICAgLSBFeGFtcGxl
DQo+ID4NCj4gPg0KPiA+ID09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCj4gPiA9PT09PT09IEBAIC0zNTIsNiArMzUz
LDY3IEBAIHB0cC10aW1lckBmZTAwMCB7ICB9Ow0KPiA+DQo+ID4NCj4gPiA9PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
DQo+ID4gPT09PT09PQ0KPiA+ICtGTWFuIE1ESU8gTm9kZQ0KPiA+ICsNCj4gPiArREVTQ1JJUFRJ
T04NCj4gPiArDQo+ID4gK1RoZSBNRElPIGlzIGEgYnVzIHRvIHdoaWNoIHRoZSBQSFkgZGV2aWNl
cyBhcmUgY29ubmVjdGVkLg0KPiA+ICsNCj4gPiArUFJPUEVSVElFUw0KPiA+ICsNCj4gPiArLSBj
b21wYXRpYmxlDQo+ID4gKwkJVXNhZ2U6IHJlcXVpcmVkDQo+ID4gKwkJVmFsdWUgdHlwZTogPHN0
cmluZ2xpc3Q+DQo+ID4gKwkJRGVmaW5pdGlvbjogQSBzdGFuZGFyZCBwcm9wZXJ0eS4NCj4gPiAr
CQlNdXN0IGluY2x1ZGUgImZzbCxmbWFuLW1kaW8iIGZvciAxIEdiL3MgTURJTyBmcm9tIEZNYW4g
djIuDQo+ID4gKwkJTXVzdCBpbmNsdWRlICJmc2wsZm1hbi14bWRpbyIgZm9yIDEwIEdiL3MgTURJ
TyBmcm9tIEZNYW4gdjIuDQo+ID4gKwkJTXVzdCBpbmNsdWRlICJmc2wsZm1hbi1tZW1hYy1tZGlv
IiBmb3IgMS8xMCBHYi9zIE1ESU8gZnJvbQ0KPiA+ICsJCUZNYW4gdjMuDQo+ID4gKw0KPiA+ICst
IHJlZw0KPiA+ICsJCVVzYWdlOiByZXF1aXJlZA0KPiA+ICsJCVZhbHVlIHR5cGU6IDxwcm9wLWVu
Y29kZWQtYXJyYXk+DQo+ID4gKwkJRGVmaW5pdGlvbjogQSBzdGFuZGFyZCBwcm9wZXJ0eS4NCj4g
PiArDQo+ID4gKy0gYnVzLWZyZXF1ZW5jeQ0KPiA+ICsJCVVzYWdlOiBvcHRpb25hbA0KPiA+ICsJ
CVZhbHVlIHR5cGU6IDx1MzI+DQo+ID4gKwkJRGVmaW5pdGlvbjogRGVmYXVsdCBNRElPIGJ1cyBj
bG9jayBzcGVlZC4NCj4gDQo+IFVzZSBjbG9ja3MvY2xvY2stbmFtZXMNCltTLkhdIFRoZSBNRElP
IHVzZXMgRm1hbiBjbG9jayBhbmQgZGl2aWRlcyBpdCB0byBhIHByb3BlciB2YWx1ZSB3aGljaCBp
cyBzcGVjaWZpZWQgYnkgdGhpcyBwcm9wZXJ0eS4NCg0KPiANCj4gPiArLSBpbnRlcnJ1cHRzDQo+
ID4gKwkJVXNhZ2U6IG9wdGlvbmFsDQo+ID4gKwkJVmFsdWUgdHlwZTogPHByb3AtZW5jb2RlZC1h
cnJheT4NCj4gPiArCQlEZWZpbml0aW9uOiBNRElPIGNvbnRyb2xsZXIgZXZlbnQgaW50ZXJydXB0
cy4NCj4gDQo+IE9uZSBpbnRlcnJ1cHQgb3IgbXVsdGlwbGU/DQpbUy5IXSBPbmUgZm9yIDEgR2Iv
cywgb25lIGZvciAxMCBHYi9zLg0KDQo+IA0KPiA+ICsNCj4gPiArLSB0eXBlDQo+ID4gKwkJVXNh
Z2U6IHJlcXVpcmVkIGZvciBGTWFuIHYzDQo+ID4gKwkJVmFsdWUgdHlwZTogPHN0cmluZ2xpc3Q+
DQo+ID4gKwkJRGVmaW5pdGlvbjogQSBzdGFuZGFyZCBwcm9wZXJ0eS4NCj4gDQo+IFdoYXQgc3Rh
bmRhcmQgaXMgInR5cGUiIGRlZmluZWQgaW4/DQpbUy5IXSBJdCdzIHRvIGRpZmZlcmVudGlhdGUg
YmV0d2VlbiB0aGUgaW50ZXJuYWwgYW5kIGV4dGVybmFsIE1ESU8sIEknbSBub3QgcXVpdGUgc3Vy
ZSBhYm91dCBuYW1pbmcgaXQsIG9yIHdoYXQgY291bGQgYmUgYmV0dGVyIHdheSB0byBkaWZmZXJl
bnRpYXRlIHRoZSBNRElPcz8NCg0KPiANCj4gPiArCQlGTWFuIHYzIGhhcyBpbnRlcm5hbCBNRElP
IGZvciBpbnRlcm5hbCBQQ1MoUGh5c2ljYWwgQ29kaW5nDQo+ID4gKwkJU3VibGF5ZXIpIFBIWXMg
YW5kIGV4dGVybmFsIE1ESU8gZm9yIGV4dGVybmFsIFBIWXMuDQo+ID4gKwkJVGhlIHNldHRpbmdz
IGFuZCBwcm9ncmFtbWluZyByb3V0aW5lcyBmb3IgaW50ZXJuYWwvZXh0ZXJuYWwNCj4gPiArCQlN
RElPIGFyZSBkaWZmZXJlbnQuIE11c3QgaW5jbHVkZSAiaW50ZXJuYWwiIGZvciBpbnRlcm5hbCBN
RElPLA0KPiA+ICsJCW11c3QgaW5jbHVkZSAiZXh0ZXJuYWwiIGZvciBleHRlcm5hbCBNRElPLg0K
PiANCj4gSSBhc3N1bWUgZm1hbiB2MiBpcyBhbHdheXMgaW50ZXJuYWw/ICBIb3cgYWJvdXQgYSBi
b29sZWFuICJmc2wsZm1hbi0NCj4gaW50ZXJuYWwtcGh5IiBwcm9wZXJ0eSBpbnN0ZWFkPw0KW1Mu
SF0gQm90aCBGbWFuIHYyICYgdjMgaGF2ZSBpbnRlcm5hbC9leHRlcm5hbCBNRElPLCBGbWFuIHYy
IHVzZXMgaW50ZXJuYWwgTURJTyBmb3IgVEJJIG9wZXJhdGlvbnMgdG8gc2V0IHRoZSBTR01JSSBQ
SFksIA0KVGhlIFRCSSBpbXBsZW1lbnRzIHRyYW5zbWl0L3JlY2VpdmUgcG9ydGlvbnMgb2YgUENT
LCBpdCdzIG5vdCB1c2VkIGluIExpbnV4LiBUaGUgUENTIG9uIEZtYW4gVjMgYXJlIG5vdCBqdXN0
IGZvciBTR01JSSwgaXQgaGFzIG1vcmUgaW1wbGVtZW50YXRpb25zLCBpdCdzIHVzZWQgaW4gTGlu
dXguDQoNCj4gDQo+ID4gKw0KPiA+ICtFWEFNUExFDQo+ID4gKw0KPiA+ICtFeGFtcGxlIGZvciBG
TWFuIHYyOg0KPiA+ICsNCj4gPiArbWRpb0BmMTAwMCB7DQo+ID4gKwljb21wYXRpYmxlID0gImZz
bCxmbWFuLXhtZGlvIjsNCj4gPiArCXJlZyA9IDwweGYxMDAwIDB4MTAwMD47DQo+ID4gK307DQo+
ID4gKw0KPiA+ICtFeGFtcGxlIGZvciBGTWFuIHYzOg0KPiA+ICsNCj4gPiArbWRpb0BmZDAwMCB7
DQo+ID4gKwljb21wYXRpYmxlID0gImZzbCxmbWFuLW1lbWFjLW1kaW8iOw0KPiA+ICsJcmVnID0g
PDB4ZmQwMDAgMHgxMDAwPjsNCj4gPiArCWJ1cy1mcmVxdWVuY3kgPSA8MjUwMDAwMD47DQo+ID4g
Kwl0eXBlID0gImV4dGVybmFsIjsNCj4gPiArfTsNCj4gPiArDQo+ID4gKz09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0K
PiA+ICs9PT09PT09PQ0KPiA+ICBFeGFtcGxlDQo+ID4NCj4gPiAgZm1hbkA0MDAwMDAgew0KPiA+
IEBAIC01MjYsNCArNTg4LDExIEBAIGZtYW5ANDAwMDAwIHsNCj4gPiAgCQljb21wYXRpYmxlID0g
ImZzbCxmbWFuLXB0cC10aW1lciI7DQo+ID4gIAkJcmVnID0gPDB4ZmUwMDAgMHgxMDAwPjsNCj4g
PiAgCX07DQo+ID4gKw0KPiA+ICsJbWRpb0BmZDAwMCB7DQo+ID4gKwkJY29tcGF0aWJsZSA9ICJm
c2wsZm1hbi1tZW1hYy1tZGlvIjsNCj4gPiArCQlyZWcgPSA8MHhmZDAwMCAweDEwMDA+Ow0KPiA+
ICsJCWJ1cy1mcmVxdWVuY3kgPSA8MjUwMDAwMD47DQo+ID4gKwkJdHlwZSA9ICJleHRlcm5hbCI7
DQo+ID4gKwl9Ow0KPiA+ICB9Ow0KPiANCj4gVGhlIHJlc3Qgb2YgdGhlIGV4YW1wbGUgaXMgZm1h
biB2MjsgZG9uJ3QgbWl4IGFuIGZtYW4gdjMgbm9kZSBpbiB3aXRoDQo+IHRoYXQuDQpbUy5IXSBP
Sy4gV2lsbCBmaXggaXQuDQoNClRoYW5rcyENClNoYW9odWkNCiANCg0K

Re: [PATCH] DT: add MDIO node for FMan node

[Scott Wood]

On Tue, 2014-11-11 at 04:32 -0600, Xie Shaohui-B21989 wrote:
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Tuesday, November 11, 2014 8:23 AM
> > To: shh.xie@gmail.com
> > Cc: linuxppc-dev@lists.ozlabs.org; devicetree@vger.kernel.org; Medve
> > Emilian-EMMEDVE1; Xie Shaohui-B21989
> > Subject: Re: [PATCH] DT: add MDIO node for FMan node
> > 
> > On Tue, 2014-11-04 at 19:56 +0800, shh.xie@gmail.com wrote:
> > > From: Shaohui Xie <Shaohui.Xie@freescale.com>
> > >
> > > This binding is for FMan MDIO, it covers FMan v2 & FMan v3.
> > >
> > > Signed-off-by: Shaohui Xie <Shaohui.Xie@freescale.com>
> > > ---
> > > based on http://patchwork.ozlabs.org/patch/390351/
> > > for 'next' of
> > > git://git.kernel.org/pub/scm/linux/kernel/git/scottwood/linux.git
> > 
> > Are there any other FMan pieces that are missing from the above patch?
> [S.H] I'm adding Igal for this comment.
> 
> > 
> > >  .../devicetree/bindings/powerpc/fsl/fman.txt       | 69
> > ++++++++++++++++++++++
> > >  1 file changed, 69 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/powerpc/fsl/fman.txt
> > > b/Documentation/devicetree/bindings/powerpc/fsl/fman.txt
> > > index da8e5f2..83c2f14 100644
> > > --- a/Documentation/devicetree/bindings/powerpc/fsl/fman.txt
> > > +++ b/Documentation/devicetree/bindings/powerpc/fsl/fman.txt
> > > @@ -7,6 +7,7 @@ CONTENTS
> > >    - FMan MURAM Node
> > >    - FMan dTSEC/XGEC/mEMAC Node
> > >    - FMan IEEE 1588 Node
> > > +  - FMan MDIO Node
> > >    - Example
> > >
> > >
> > > ======================================================================
> > > ======= @@ -352,6 +353,67 @@ ptp-timer@fe000 {  };
> > >
> > >
> > > ======================================================================
> > > =======
> > > +FMan MDIO Node
> > > +
> > > +DESCRIPTION
> > > +
> > > +The MDIO is a bus to which the PHY devices are connected.
> > > +
> > > +PROPERTIES
> > > +
> > > +- compatible
> > > +		Usage: required
> > > +		Value type: <stringlist>
> > > +		Definition: A standard property.
> > > +		Must include "fsl,fman-mdio" for 1 Gb/s MDIO from FMan v2.
> > > +		Must include "fsl,fman-xmdio" for 10 Gb/s MDIO from FMan v2.
> > > +		Must include "fsl,fman-memac-mdio" for 1/10 Gb/s MDIO from
> > > +		FMan v3.
> > > +
> > > +- reg
> > > +		Usage: required
> > > +		Value type: <prop-encoded-array>
> > > +		Definition: A standard property.
> > > +
> > > +- bus-frequency
> > > +		Usage: optional
> > > +		Value type: <u32>
> > > +		Definition: Default MDIO bus clock speed.
> > 
> > Use clocks/clock-names
> [S.H] The MDIO uses Fman clock and divides it to a proper value which is specified by this property.

Use clocks/clock-names to describe that relationship.

> > 
> > > +- interrupts
> > > +		Usage: optional
> > > +		Value type: <prop-encoded-array>
> > > +		Definition: MDIO controller event interrupts.
> > 
> > One interrupt or multiple?
> [S.H] One for 1 Gb/s, one for 10 Gb/s.

Then the binding needs to say that there are two (except for
"fsl,fman-mdio", right?) and which is which.

> > 
> > > +
> > > +- type
> > > +		Usage: required for FMan v3
> > > +		Value type: <stringlist>
> > > +		Definition: A standard property.
> > 
> > What standard is "type" defined in?
>
> [S.H] It's to differentiate between the internal and external MDIO, I'm
> not quite sure about naming it, or what could be better way to
> differentiate the MDIOs?

I'm not questioning the need to convey this information.  I'm saying
it's not "A standard property".  I'd also like to see a better name.

> > 
> > > +		FMan v3 has internal MDIO for internal PCS(Physical Coding
> > > +		Sublayer) PHYs and external MDIO for external PHYs.
> > > +		The settings and programming routines for internal/external
> > > +		MDIO are different. Must include "internal" for internal MDIO,
> > > +		must include "external" for external MDIO.
> > 
> > I assume fman v2 is always internal?  How about a boolean "fsl,fman-
> > internal-phy" property instead?
> [S.H] Both Fman v2 & v3 have internal/external MDIO, Fman v2 uses internal MDIO for TBI operations to set the SGMII PHY, 
>
> The TBI implements transmit/receive portions of PCS, it's not used in
> Linux. The PCS on Fman V3 are not just for SGMII, it has more
> implementations, it's used in Linux.

The device tree is about the hardware, not what's used in Linux.

-Scott

Re: [PATCH] DT: add MDIO node for FMan node

[Joakim Tjernlund]

> >
> > The TBI implements transmit/receive portions of PCS, it's not used in
> > Linux. The PCS on Fman V3 are not just for SGMII, it has more
> > implementations, it's used in Linux.

It is used for PHY less mode(aka fixed PHY) and needs to be exposed to
linux so it is possible to select SGMII/1000BASE-X, AutoNeg etc.

> 
> The device tree is about the hardware, not what's used in Linux.
> 
> -Scott

RE: [PATCH] DT: add MDIO node for FMan node

[Shaohui Xie]

PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBXb29kIFNjb3R0LUIwNzQyMQ0K
PiBTZW50OiBXZWRuZXNkYXksIE5vdmVtYmVyIDEyLCAyMDE0IDE6MzggQU0NCj4gVG86IFhpZSBT
aGFvaHVpLUIyMTk4OQ0KPiBDYzogTGliZXJtYW4gSWdhbC1CMzE5NTA7IGxpbnV4cHBjLWRldkBs
aXN0cy5vemxhYnMub3JnOw0KPiBkZXZpY2V0cmVlQHZnZXIua2VybmVsLm9yZzsgTWVkdmUgRW1p
bGlhbi1FTU1FRFZFMQ0KPiBTdWJqZWN0OiBSZTogW1BBVENIXSBEVDogYWRkIE1ESU8gbm9kZSBm
b3IgRk1hbiBub2RlDQo+IA0KPiBPbiBUdWUsIDIwMTQtMTEtMTEgYXQgMDQ6MzIgLTA2MDAsIFhp
ZSBTaGFvaHVpLUIyMTk4OSB3cm90ZToNCj4gPiA+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0t
DQo+ID4gPiBGcm9tOiBXb29kIFNjb3R0LUIwNzQyMQ0KPiA+ID4gU2VudDogVHVlc2RheSwgTm92
ZW1iZXIgMTEsIDIwMTQgODoyMyBBTQ0KPiA+ID4gVG86IHNoaC54aWVAZ21haWwuY29tDQo+ID4g
PiBDYzogbGludXhwcGMtZGV2QGxpc3RzLm96bGFicy5vcmc7IGRldmljZXRyZWVAdmdlci5rZXJu
ZWwub3JnOyBNZWR2ZQ0KPiA+ID4gRW1pbGlhbi1FTU1FRFZFMTsgWGllIFNoYW9odWktQjIxOTg5
DQo+ID4gPiBTdWJqZWN0OiBSZTogW1BBVENIXSBEVDogYWRkIE1ESU8gbm9kZSBmb3IgRk1hbiBu
b2RlDQo+ID4gPg0KPiA+ID4gT24gVHVlLCAyMDE0LTExLTA0IGF0IDE5OjU2ICswODAwLCBzaGgu
eGllQGdtYWlsLmNvbSB3cm90ZToNCj4gPiA+ID4gRnJvbTogU2hhb2h1aSBYaWUgPFNoYW9odWku
WGllQGZyZWVzY2FsZS5jb20+DQo+ID4gPiA+DQo+ID4gPiA+IFRoaXMgYmluZGluZyBpcyBmb3Ig
Rk1hbiBNRElPLCBpdCBjb3ZlcnMgRk1hbiB2MiAmIEZNYW4gdjMuDQo+ID4gPiA+DQo+ID4gPiA+
IFNpZ25lZC1vZmYtYnk6IFNoYW9odWkgWGllIDxTaGFvaHVpLlhpZUBmcmVlc2NhbGUuY29tPg0K
PiA+ID4gPiAtLS0NCj4gPiA+ID4gYmFzZWQgb24gaHR0cDovL3BhdGNod29yay5vemxhYnMub3Jn
L3BhdGNoLzM5MDM1MS8NCj4gPiA+ID4gZm9yICduZXh0JyBvZg0KPiA+ID4gPiBnaXQ6Ly9naXQu
a2VybmVsLm9yZy9wdWIvc2NtL2xpbnV4L2tlcm5lbC9naXQvc2NvdHR3b29kL2xpbnV4LmdpdA0K
PiA+ID4NCj4gPiA+IEFyZSB0aGVyZSBhbnkgb3RoZXIgRk1hbiBwaWVjZXMgdGhhdCBhcmUgbWlz
c2luZyBmcm9tIHRoZSBhYm92ZSBwYXRjaD8NCj4gPiBbUy5IXSBJJ20gYWRkaW5nIElnYWwgZm9y
IHRoaXMgY29tbWVudC4NCj4gPg0KPiA+ID4NCj4gPiA+ID4gKy0gYnVzLWZyZXF1ZW5jeQ0KPiA+
ID4gPiArCQlVc2FnZTogb3B0aW9uYWwNCj4gPiA+ID4gKwkJVmFsdWUgdHlwZTogPHUzMj4NCj4g
PiA+ID4gKwkJRGVmaW5pdGlvbjogRGVmYXVsdCBNRElPIGJ1cyBjbG9jayBzcGVlZC4NCj4gPiA+
DQo+ID4gPiBVc2UgY2xvY2tzL2Nsb2NrLW5hbWVzDQo+ID4gW1MuSF0gVGhlIE1ESU8gdXNlcyBG
bWFuIGNsb2NrIGFuZCBkaXZpZGVzIGl0IHRvIGEgcHJvcGVyIHZhbHVlIHdoaWNoDQo+IGlzIHNw
ZWNpZmllZCBieSB0aGlzIHByb3BlcnR5Lg0KPiANCj4gVXNlIGNsb2Nrcy9jbG9jay1uYW1lcyB0
byBkZXNjcmliZSB0aGF0IHJlbGF0aW9uc2hpcC4NCj4gDQpbUy5IXSBUaGUgTURJTyBub2RlIGlz
IHN1Yi1ub2RlIGFuZCBlbWJlZGRlZCBpbiBGbWFuIG5vZGUsIHRoZSBjbG9ja3MvY2xvY2stbmFt
ZXMgaXMgcHJvdmlkZWQgYnkgRm1hbiBub2RlLCBzaG91bGQgcmVwZWF0IHRoZW0gaW4gTURJTyBu
b2RlPyBGb3IgdGhlIGRlZmF1bHQgTURJTyBidXMgY2xvY2sgc3BlZWQsIG1heWJlICJjbG9jay1y
YW5nZXMiIHNob3VsZCBiZSB1c2VkPw0KDQo+ID4gPg0KPiA+ID4gPiArLSBpbnRlcnJ1cHRzDQo+
ID4gPiA+ICsJCVVzYWdlOiBvcHRpb25hbA0KPiA+ID4gPiArCQlWYWx1ZSB0eXBlOiA8cHJvcC1l
bmNvZGVkLWFycmF5Pg0KPiA+ID4gPiArCQlEZWZpbml0aW9uOiBNRElPIGNvbnRyb2xsZXIgZXZl
bnQgaW50ZXJydXB0cy4NCj4gPiA+DQo+ID4gPiBPbmUgaW50ZXJydXB0IG9yIG11bHRpcGxlPw0K
PiA+IFtTLkhdIE9uZSBmb3IgMSBHYi9zLCBvbmUgZm9yIDEwIEdiL3MuDQo+IA0KPiBUaGVuIHRo
ZSBiaW5kaW5nIG5lZWRzIHRvIHNheSB0aGF0IHRoZXJlIGFyZSB0d28gKGV4Y2VwdCBmb3IgImZz
bCxmbWFuLQ0KPiBtZGlvIiwgcmlnaHQ/KSBhbmQgd2hpY2ggaXMgd2hpY2guDQo+IA0KW1MuSF0g
T0suDQoNCj4gPiA+DQo+ID4gPiA+ICsNCj4gPiA+ID4gKy0gdHlwZQ0KPiA+ID4gPiArCQlVc2Fn
ZTogcmVxdWlyZWQgZm9yIEZNYW4gdjMNCj4gPiA+ID4gKwkJVmFsdWUgdHlwZTogPHN0cmluZ2xp
c3Q+DQo+ID4gPiA+ICsJCURlZmluaXRpb246IEEgc3RhbmRhcmQgcHJvcGVydHkuDQo+ID4gPg0K
PiA+ID4gV2hhdCBzdGFuZGFyZCBpcyAidHlwZSIgZGVmaW5lZCBpbj8NCj4gPg0KPiA+IFtTLkhd
IEl0J3MgdG8gZGlmZmVyZW50aWF0ZSBiZXR3ZWVuIHRoZSBpbnRlcm5hbCBhbmQgZXh0ZXJuYWwg
TURJTywNCj4gPiBJJ20gbm90IHF1aXRlIHN1cmUgYWJvdXQgbmFtaW5nIGl0LCBvciB3aGF0IGNv
dWxkIGJlIGJldHRlciB3YXkgdG8NCj4gPiBkaWZmZXJlbnRpYXRlIHRoZSBNRElPcz8NCj4gDQo+
IEknbSBub3QgcXVlc3Rpb25pbmcgdGhlIG5lZWQgdG8gY29udmV5IHRoaXMgaW5mb3JtYXRpb24u
ICBJJ20gc2F5aW5nIGl0J3MNCj4gbm90ICJBIHN0YW5kYXJkIHByb3BlcnR5Ii4gIEknZCBhbHNv
IGxpa2UgdG8gc2VlIGEgYmV0dGVyIG5hbWUuDQo+IA0KW1MuSF0gc2luY2UgRm1hbiBWMiAmIFYz
IGNhbiBiZSBkaWZmZXJlbnRpYXRlZCBieSBjb21wYXRpYmxlLCBhIGJvb2xlYW4gcHJvcGVydHkg
ImZzbCxmbWFuLWludGVybmFsLW1kaW8iIHNlZW1zIGJldHRlciwgaWYgZGVmaW5lZCwgaXQgaW5k
aWNhdGVzIGFuIGludGVybmFsIE1ESU8uIEl0IGxvb2tzIGxpa2UgYmVsb3c6DQoNCmZzbCxmbWFu
LWludGVybmFsLW1kaW8NCgkJVXNhZ2U6IHJlcXVpcmVkIGZvciBpbnRlcm5hbCBNRElPDQoJCVZh
bHVlIHR5cGU6IEJvb2xlYW4NCgkJRGVmaW5pdGlvbjogRm1hbiBoYXMgaW50ZXJuYWwgTURJTyBm
b3IgaW50ZXJuYWwgUENTKFBoeXNpY2FsDQoJCUNvZGluZyBTdWJsYXllcikgUEhZcyBhbmQgZXh0
ZXJuYWwgTURJTyBmb3IgZXh0ZXJuYWwgUEhZcy4NCgkJVGhlIHNldHRpbmdzIGFuZCBwcm9ncmFt
bWluZyByb3V0aW5lcyBmb3IgaW50ZXJuYWwvZXh0ZXJuYWwNCgkJTURJTyBhcmUgZGlmZmVyZW50
LiBNdXN0IGJlIGluY2x1ZGVkIGZvciBpbnRlcm5hbCBNRElPLg0KDQpIb3cgYWJvdXQgdGhpcz8N
Cg0KVGhhbmtzIQ0KU2hhb2h1aQ0KIA0K

Re: [PATCH] DT: add MDIO node for FMan node

[Scott Wood]

On Wed, 2014-11-12 at 07:40 -0600, Xie Shaohui-B21989 wrote:
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Wednesday, November 12, 2014 1:38 AM
> > To: Xie Shaohui-B21989
> > Cc: Liberman Igal-B31950; linuxppc-dev@lists.ozlabs.org;
> > devicetree@vger.kernel.org; Medve Emilian-EMMEDVE1
> > Subject: Re: [PATCH] DT: add MDIO node for FMan node
> > 
> > On Tue, 2014-11-11 at 04:32 -0600, Xie Shaohui-B21989 wrote:
> > > > -----Original Message-----
> > > > From: Wood Scott-B07421
> > > > Sent: Tuesday, November 11, 2014 8:23 AM
> > > > To: shh.xie@gmail.com
> > > > Cc: linuxppc-dev@lists.ozlabs.org; devicetree@vger.kernel.org; Medve
> > > > Emilian-EMMEDVE1; Xie Shaohui-B21989
> > > > Subject: Re: [PATCH] DT: add MDIO node for FMan node
> > > >
> > > > On Tue, 2014-11-04 at 19:56 +0800, shh.xie@gmail.com wrote:
> > > > > From: Shaohui Xie <Shaohui.Xie@freescale.com>
> > > > >
> > > > > This binding is for FMan MDIO, it covers FMan v2 & FMan v3.
> > > > >
> > > > > Signed-off-by: Shaohui Xie <Shaohui.Xie@freescale.com>
> > > > > ---
> > > > > based on http://patchwork.ozlabs.org/patch/390351/
> > > > > for 'next' of
> > > > > git://git.kernel.org/pub/scm/linux/kernel/git/scottwood/linux.git
> > > >
> > > > Are there any other FMan pieces that are missing from the above patch?
> > > [S.H] I'm adding Igal for this comment.
> > >
> > > >
> > > > > +- bus-frequency
> > > > > +		Usage: optional
> > > > > +		Value type: <u32>
> > > > > +		Definition: Default MDIO bus clock speed.
> > > >
> > > > Use clocks/clock-names
> > > [S.H] The MDIO uses Fman clock and divides it to a proper value which
> > is specified by this property.
> > 
> > Use clocks/clock-names to describe that relationship.
> > 
>
> [S.H] The MDIO node is sub-node and embedded in Fman node, the
> clocks/clock-names is provided by Fman node, should repeat them in MDIO
> node? For the default MDIO bus clock speed, maybe "clock-ranges" should
> be used?

It's a different clock.  You wouldn't be repeating.  If it's derived
from the FMan clock, then maybe you don't need anything here (does the
driver know what the divider is, or would that need to be specified in
the device tree?), but no more clock-frequency/bus-frequency properties.

> [S.H] since Fman V2 & V3 can be differentiated by compatible, a boolean
> property "fsl,fman-internal-mdio" seems better, if defined, it
> indicates an internal MDIO. It looks like below:
> 
> fsl,fman-internal-mdio
> 		Usage: required for internal MDIO
> 		Value type: Boolean
> 		Definition: Fman has internal MDIO for internal PCS(Physical
> 		Coding Sublayer) PHYs and external MDIO for external PHYs.
> 		The settings and programming routines for internal/external
> 		MDIO are different. Must be included for internal MDIO.
> 
> How about this?

This looks better, thanks.

This would be set on fman v2 TBI mdio nodes as well, right?

-Scott

RE: [PATCH] DT: add MDIO node for FMan node

[Shaohui Xie]

PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBXb29kIFNjb3R0LUIwNzQyMQ0K
PiBTZW50OiBUaHVyc2RheSwgTm92ZW1iZXIgMTMsIDIwMTQgMjoxNyBQTQ0KPiBUbzogWGllIFNo
YW9odWktQjIxOTg5DQo+IENjOiBMaWJlcm1hbiBJZ2FsLUIzMTk1MDsgbGludXhwcGMtZGV2QGxp
c3RzLm96bGFicy5vcmc7DQo+IGRldmljZXRyZWVAdmdlci5rZXJuZWwub3JnOyBNZWR2ZSBFbWls
aWFuLUVNTUVEVkUxDQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0hdIERUOiBhZGQgTURJTyBub2RlIGZv
ciBGTWFuIG5vZGUNCj4gDQo+IE9uIFdlZCwgMjAxNC0xMS0xMiBhdCAwNzo0MCAtMDYwMCwgWGll
IFNoYW9odWktQjIxOTg5IHdyb3RlOg0KPiA+ID4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0N
Cj4gPiA+IEZyb206IFdvb2QgU2NvdHQtQjA3NDIxDQo+ID4gPiBTZW50OiBXZWRuZXNkYXksIE5v
dmVtYmVyIDEyLCAyMDE0IDE6MzggQU0NCj4gPiA+IFRvOiBYaWUgU2hhb2h1aS1CMjE5ODkNCj4g
PiA+IENjOiBMaWJlcm1hbiBJZ2FsLUIzMTk1MDsgbGludXhwcGMtZGV2QGxpc3RzLm96bGFicy5v
cmc7DQo+ID4gPiBkZXZpY2V0cmVlQHZnZXIua2VybmVsLm9yZzsgTWVkdmUgRW1pbGlhbi1FTU1F
RFZFMQ0KPiA+ID4gU3ViamVjdDogUmU6IFtQQVRDSF0gRFQ6IGFkZCBNRElPIG5vZGUgZm9yIEZN
YW4gbm9kZQ0KPiA+ID4NCj4gPiA+IE9uIFR1ZSwgMjAxNC0xMS0xMSBhdCAwNDozMiAtMDYwMCwg
WGllIFNoYW9odWktQjIxOTg5IHdyb3RlOg0KPiA+ID4gPiA+IC0tLS0tT3JpZ2luYWwgTWVzc2Fn
ZS0tLS0tDQo+ID4gPiA+ID4gRnJvbTogV29vZCBTY290dC1CMDc0MjENCj4gPiA+ID4gPiBTZW50
OiBUdWVzZGF5LCBOb3ZlbWJlciAxMSwgMjAxNCA4OjIzIEFNDQo+ID4gPiA+ID4gVG86IHNoaC54
aWVAZ21haWwuY29tDQo+ID4gPiA+ID4gQ2M6IGxpbnV4cHBjLWRldkBsaXN0cy5vemxhYnMub3Jn
OyBkZXZpY2V0cmVlQHZnZXIua2VybmVsLm9yZzsNCj4gPiA+ID4gPiBNZWR2ZSBFbWlsaWFuLUVN
TUVEVkUxOyBYaWUgU2hhb2h1aS1CMjE5ODkNCj4gPiA+ID4gPiBTdWJqZWN0OiBSZTogW1BBVENI
XSBEVDogYWRkIE1ESU8gbm9kZSBmb3IgRk1hbiBub2RlDQo+ID4gPiA+ID4NCj4gPiA+ID4gPiBP
biBUdWUsIDIwMTQtMTEtMDQgYXQgMTk6NTYgKzA4MDAsIHNoaC54aWVAZ21haWwuY29tIHdyb3Rl
Og0KPiA+ID4gPiA+ID4gRnJvbTogU2hhb2h1aSBYaWUgPFNoYW9odWkuWGllQGZyZWVzY2FsZS5j
b20+DQo+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gVGhpcyBiaW5kaW5nIGlzIGZvciBGTWFuIE1E
SU8sIGl0IGNvdmVycyBGTWFuIHYyICYgRk1hbiB2My4NCj4gPiA+ID4gPiA+DQo+ID4gPiA+ID4g
PiBTaWduZWQtb2ZmLWJ5OiBTaGFvaHVpIFhpZSA8U2hhb2h1aS5YaWVAZnJlZXNjYWxlLmNvbT4N
Cj4gPiA+ID4gPiA+IC0tLQ0KPiA+ID4gPiA+ID4gYmFzZWQgb24gaHR0cDovL3BhdGNod29yay5v
emxhYnMub3JnL3BhdGNoLzM5MDM1MS8NCj4gPiA+ID4gPiA+IGZvciAnbmV4dCcgb2YNCj4gPiA+
ID4gPiA+IGdpdDovL2dpdC5rZXJuZWwub3JnL3B1Yi9zY20vbGludXgva2VybmVsL2dpdC9zY290
dHdvb2QvbGludXguDQo+ID4gPiA+ID4gPiBnaXQNCj4gPiA+ID4gPg0KPiA+ID4gPiA+IEFyZSB0
aGVyZSBhbnkgb3RoZXIgRk1hbiBwaWVjZXMgdGhhdCBhcmUgbWlzc2luZyBmcm9tIHRoZSBhYm92
ZQ0KPiBwYXRjaD8NCj4gPiA+ID4gW1MuSF0gSSdtIGFkZGluZyBJZ2FsIGZvciB0aGlzIGNvbW1l
bnQuDQo+ID4gPiA+DQo+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ICstIGJ1cy1mcmVxdWVuY3kNCj4g
PiA+ID4gPiA+ICsJCVVzYWdlOiBvcHRpb25hbA0KPiA+ID4gPiA+ID4gKwkJVmFsdWUgdHlwZTog
PHUzMj4NCj4gPiA+ID4gPiA+ICsJCURlZmluaXRpb246IERlZmF1bHQgTURJTyBidXMgY2xvY2sg
c3BlZWQuDQo+ID4gPiA+ID4NCj4gPiA+ID4gPiBVc2UgY2xvY2tzL2Nsb2NrLW5hbWVzDQo+ID4g
PiA+IFtTLkhdIFRoZSBNRElPIHVzZXMgRm1hbiBjbG9jayBhbmQgZGl2aWRlcyBpdCB0byBhIHBy
b3BlciB2YWx1ZQ0KPiA+ID4gPiB3aGljaA0KPiA+ID4gaXMgc3BlY2lmaWVkIGJ5IHRoaXMgcHJv
cGVydHkuDQo+ID4gPg0KPiA+ID4gVXNlIGNsb2Nrcy9jbG9jay1uYW1lcyB0byBkZXNjcmliZSB0
aGF0IHJlbGF0aW9uc2hpcC4NCj4gPiA+DQo+ID4NCj4gPiBbUy5IXSBUaGUgTURJTyBub2RlIGlz
IHN1Yi1ub2RlIGFuZCBlbWJlZGRlZCBpbiBGbWFuIG5vZGUsIHRoZQ0KPiA+IGNsb2Nrcy9jbG9j
ay1uYW1lcyBpcyBwcm92aWRlZCBieSBGbWFuIG5vZGUsIHNob3VsZCByZXBlYXQgdGhlbSBpbg0K
PiA+IE1ESU8gbm9kZT8gRm9yIHRoZSBkZWZhdWx0IE1ESU8gYnVzIGNsb2NrIHNwZWVkLCBtYXli
ZSAiY2xvY2stcmFuZ2VzIg0KPiA+IHNob3VsZCBiZSB1c2VkPw0KPiANCj4gSXQncyBhIGRpZmZl
cmVudCBjbG9jay4gIFlvdSB3b3VsZG4ndCBiZSByZXBlYXRpbmcuICBJZiBpdCdzIGRlcml2ZWQg
ZnJvbQ0KPiB0aGUgRk1hbiBjbG9jaywgdGhlbiBtYXliZSB5b3UgZG9uJ3QgbmVlZCBhbnl0aGlu
ZyBoZXJlIChkb2VzIHRoZSBkcml2ZXINCj4ga25vdyB3aGF0IHRoZSBkaXZpZGVyIGlzLCBvciB3
b3VsZCB0aGF0IG5lZWQgdG8gYmUgc3BlY2lmaWVkIGluIHRoZQ0KPiBkZXZpY2UgdHJlZT8pLCBi
dXQgbm8gbW9yZSBjbG9jay1mcmVxdWVuY3kvYnVzLWZyZXF1ZW5jeSBwcm9wZXJ0aWVzLg0KPiAN
CltTLkhdIFRoZSBwdXJwb3NlIGhlcmUgaXMgdG8gZ2V0IGEgc3BlY2lmaWMgY2xvY2sgZnJlcXVl
bmN5LCBkcml2ZXIgdG8gdXNlIGl0IHRvIGNhbGN1bGF0ZSB0aGUgZGl2aWRlci4NClRoZW4gdGhl
IEZtYW4gY2xvY2sgY2FuIGJlIGRpdmlkZWQgdG8gdGhlIGZyZXF1ZW5jeS4NCg0KPiA+IFtTLkhd
IHNpbmNlIEZtYW4gVjIgJiBWMyBjYW4gYmUgZGlmZmVyZW50aWF0ZWQgYnkgY29tcGF0aWJsZSwg
YQ0KPiA+IGJvb2xlYW4gcHJvcGVydHkgImZzbCxmbWFuLWludGVybmFsLW1kaW8iIHNlZW1zIGJl
dHRlciwgaWYgZGVmaW5lZCwgaXQNCj4gPiBpbmRpY2F0ZXMgYW4gaW50ZXJuYWwgTURJTy4gSXQg
bG9va3MgbGlrZSBiZWxvdzoNCj4gPg0KPiA+IGZzbCxmbWFuLWludGVybmFsLW1kaW8NCj4gPiAJ
CVVzYWdlOiByZXF1aXJlZCBmb3IgaW50ZXJuYWwgTURJTw0KPiA+IAkJVmFsdWUgdHlwZTogQm9v
bGVhbg0KPiA+IAkJRGVmaW5pdGlvbjogRm1hbiBoYXMgaW50ZXJuYWwgTURJTyBmb3IgaW50ZXJu
YWwgUENTKFBoeXNpY2FsDQo+ID4gCQlDb2RpbmcgU3VibGF5ZXIpIFBIWXMgYW5kIGV4dGVybmFs
IE1ESU8gZm9yIGV4dGVybmFsIFBIWXMuDQo+ID4gCQlUaGUgc2V0dGluZ3MgYW5kIHByb2dyYW1t
aW5nIHJvdXRpbmVzIGZvciBpbnRlcm5hbC9leHRlcm5hbA0KPiA+IAkJTURJTyBhcmUgZGlmZmVy
ZW50LiBNdXN0IGJlIGluY2x1ZGVkIGZvciBpbnRlcm5hbCBNRElPLg0KPiA+DQo+ID4gSG93IGFi
b3V0IHRoaXM/DQo+IA0KPiBUaGlzIGxvb2tzIGJldHRlciwgdGhhbmtzLg0KPiANCj4gVGhpcyB3
b3VsZCBiZSBzZXQgb24gZm1hbiB2MiBUQkkgbWRpbyBub2RlcyBhcyB3ZWxsLCByaWdodD8NCltT
LkhdIFllcy4gQnV0IGl0J3Mgbm90IHVzZWQgYnkgZHJpdmVyLiAoSSBrbm93IEkgc2hvdWxkIG5v
dCBzYXkgdGhpcyA6KSApDQoNClRoYW5rcy4NClNoYW9odWkNCg0K

Re: [PATCH] DT: add MDIO node for FMan node

[Scott Wood]

On Thu, 2014-11-13 at 01:11 -0600, Xie Shaohui-B21989 wrote:
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Thursday, November 13, 2014 2:17 PM
> > To: Xie Shaohui-B21989
> > Cc: Liberman Igal-B31950; linuxppc-dev@lists.ozlabs.org;
> > devicetree@vger.kernel.org; Medve Emilian-EMMEDVE1
> > Subject: Re: [PATCH] DT: add MDIO node for FMan node
> > 
> > On Wed, 2014-11-12 at 07:40 -0600, Xie Shaohui-B21989 wrote:
> > > > -----Original Message-----
> > > > From: Wood Scott-B07421
> > > > Sent: Wednesday, November 12, 2014 1:38 AM
> > > > To: Xie Shaohui-B21989
> > > > Cc: Liberman Igal-B31950; linuxppc-dev@lists.ozlabs.org;
> > > > devicetree@vger.kernel.org; Medve Emilian-EMMEDVE1
> > > > Subject: Re: [PATCH] DT: add MDIO node for FMan node
> > > >
> > > > On Tue, 2014-11-11 at 04:32 -0600, Xie Shaohui-B21989 wrote:
> > > > > > -----Original Message-----
> > > > > > From: Wood Scott-B07421
> > > > > > Sent: Tuesday, November 11, 2014 8:23 AM
> > > > > > To: shh.xie@gmail.com
> > > > > > Cc: linuxppc-dev@lists.ozlabs.org; devicetree@vger.kernel.org;
> > > > > > Medve Emilian-EMMEDVE1; Xie Shaohui-B21989
> > > > > > Subject: Re: [PATCH] DT: add MDIO node for FMan node
> > > > > >
> > > > > > On Tue, 2014-11-04 at 19:56 +0800, shh.xie@gmail.com wrote:
> > > > > > > From: Shaohui Xie <Shaohui.Xie@freescale.com>
> > > > > > >
> > > > > > > This binding is for FMan MDIO, it covers FMan v2 & FMan v3.
> > > > > > >
> > > > > > > Signed-off-by: Shaohui Xie <Shaohui.Xie@freescale.com>
> > > > > > > ---
> > > > > > > based on http://patchwork.ozlabs.org/patch/390351/
> > > > > > > for 'next' of
> > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/scottwood/linux.
> > > > > > > git
> > > > > >
> > > > > > Are there any other FMan pieces that are missing from the above
> > patch?
> > > > > [S.H] I'm adding Igal for this comment.
> > > > >
> > > > > >
> > > > > > > +- bus-frequency
> > > > > > > +		Usage: optional
> > > > > > > +		Value type: <u32>
> > > > > > > +		Definition: Default MDIO bus clock speed.
> > > > > >
> > > > > > Use clocks/clock-names
> > > > > [S.H] The MDIO uses Fman clock and divides it to a proper value
> > > > > which
> > > > is specified by this property.
> > > >
> > > > Use clocks/clock-names to describe that relationship.
> > > >
> > >
> > > [S.H] The MDIO node is sub-node and embedded in Fman node, the
> > > clocks/clock-names is provided by Fman node, should repeat them in
> > > MDIO node? For the default MDIO bus clock speed, maybe "clock-ranges"
> > > should be used?
> > 
> > It's a different clock.  You wouldn't be repeating.  If it's derived from
> > the FMan clock, then maybe you don't need anything here (does the driver
> > know what the divider is, or would that need to be specified in the
> > device tree?), but no more clock-frequency/bus-frequency properties.
> > 
> [S.H] The purpose here is to get a specific clock frequency, driver to use it to calculate the divider.
> Then the Fman clock can be divided to the frequency.

Oh, so this is stating a desired frequency and not something that
already exists?  What determines this frequency?  Is it based on board
design, or just on the MDIO standard, etc?  I'm wondering if the device
tree is the right place for it.

> > > [S.H] since Fman V2 & V3 can be differentiated by compatible, a
> > > boolean property "fsl,fman-internal-mdio" seems better, if defined, it
> > > indicates an internal MDIO. It looks like below:
> > >
> > > fsl,fman-internal-mdio
> > > 		Usage: required for internal MDIO
> > > 		Value type: Boolean
> > > 		Definition: Fman has internal MDIO for internal PCS(Physical
> > > 		Coding Sublayer) PHYs and external MDIO for external PHYs.
> > > 		The settings and programming routines for internal/external
> > > 		MDIO are different. Must be included for internal MDIO.
> > >
> > > How about this?
> > 
> > This looks better, thanks.
> > 
> > This would be set on fman v2 TBI mdio nodes as well, right?
> [S.H] Yes. But it's not used by driver. (I know I should not say this :) )

Saying it is fine as long as you still put it in the device tree. :-)

-Scott

RE: [PATCH] DT: add MDIO node for FMan node

[Shaohui Xie]

DQoNCkJlc3QgUmVnYXJkcywgDQpTaGFvaHVpIFhpZQ0KDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNz
YWdlLS0tLS0NCj4gRnJvbTogV29vZCBTY290dC1CMDc0MjENCj4gU2VudDogVGh1cnNkYXksIE5v
dmVtYmVyIDEzLCAyMDE0IDM6MTUgUE0NCj4gVG86IFhpZSBTaGFvaHVpLUIyMTk4OQ0KPiBDYzog
TGliZXJtYW4gSWdhbC1CMzE5NTA7IGxpbnV4cHBjLWRldkBsaXN0cy5vemxhYnMub3JnOw0KPiBk
ZXZpY2V0cmVlQHZnZXIua2VybmVsLm9yZzsgTWVkdmUgRW1pbGlhbi1FTU1FRFZFMQ0KPiBTdWJq
ZWN0OiBSZTogW1BBVENIXSBEVDogYWRkIE1ESU8gbm9kZSBmb3IgRk1hbiBub2RlDQo+IA0KPiBP
biBUaHUsIDIwMTQtMTEtMTMgYXQgMDE6MTEgLTA2MDAsIFhpZSBTaGFvaHVpLUIyMTk4OSB3cm90
ZToNCj4gPiA+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+ID4gPiBGcm9tOiBXb29kIFNj
b3R0LUIwNzQyMQ0KPiA+ID4gU2VudDogVGh1cnNkYXksIE5vdmVtYmVyIDEzLCAyMDE0IDI6MTcg
UE0NCj4gPiA+IFRvOiBYaWUgU2hhb2h1aS1CMjE5ODkNCj4gPiA+IENjOiBMaWJlcm1hbiBJZ2Fs
LUIzMTk1MDsgbGludXhwcGMtZGV2QGxpc3RzLm96bGFicy5vcmc7DQo+ID4gPiBkZXZpY2V0cmVl
QHZnZXIua2VybmVsLm9yZzsgTWVkdmUgRW1pbGlhbi1FTU1FRFZFMQ0KPiA+ID4gU3ViamVjdDog
UmU6IFtQQVRDSF0gRFQ6IGFkZCBNRElPIG5vZGUgZm9yIEZNYW4gbm9kZQ0KPiA+ID4NCj4gPiA+
IE9uIFdlZCwgMjAxNC0xMS0xMiBhdCAwNzo0MCAtMDYwMCwgWGllIFNoYW9odWktQjIxOTg5IHdy
b3RlOg0KPiA+ID4gPiA+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+ID4gPiA+ID4gRnJv
bTogV29vZCBTY290dC1CMDc0MjENCj4gPiA+ID4gPiBTZW50OiBXZWRuZXNkYXksIE5vdmVtYmVy
IDEyLCAyMDE0IDE6MzggQU0NCj4gPiA+ID4gPiBUbzogWGllIFNoYW9odWktQjIxOTg5DQo+ID4g
PiA+ID4gQ2M6IExpYmVybWFuIElnYWwtQjMxOTUwOyBsaW51eHBwYy1kZXZAbGlzdHMub3psYWJz
Lm9yZzsNCj4gPiA+ID4gPiBkZXZpY2V0cmVlQHZnZXIua2VybmVsLm9yZzsgTWVkdmUgRW1pbGlh
bi1FTU1FRFZFMQ0KPiA+ID4gPiA+IFN1YmplY3Q6IFJlOiBbUEFUQ0hdIERUOiBhZGQgTURJTyBu
b2RlIGZvciBGTWFuIG5vZGUNCj4gPiA+ID4gPg0KPiA+ID4gPiA+IE9uIFR1ZSwgMjAxNC0xMS0x
MSBhdCAwNDozMiAtMDYwMCwgWGllIFNoYW9odWktQjIxOTg5IHdyb3RlOg0KPiA+ID4gPiA+ID4g
PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiA+ID4gPiA+ID4gPiBGcm9tOiBXb29kIFNj
b3R0LUIwNzQyMQ0KPiA+ID4gPiA+ID4gPiBTZW50OiBUdWVzZGF5LCBOb3ZlbWJlciAxMSwgMjAx
NCA4OjIzIEFNDQo+ID4gPiA+ID4gPiA+IFRvOiBzaGgueGllQGdtYWlsLmNvbQ0KPiA+ID4gPiA+
ID4gPiBDYzogbGludXhwcGMtZGV2QGxpc3RzLm96bGFicy5vcmc7DQo+ID4gPiA+ID4gPiA+IGRl
dmljZXRyZWVAdmdlci5rZXJuZWwub3JnOyBNZWR2ZSBFbWlsaWFuLUVNTUVEVkUxOyBYaWUNCj4g
PiA+ID4gPiA+ID4gU2hhb2h1aS1CMjE5ODkNCj4gPiA+ID4gPiA+ID4gU3ViamVjdDogUmU6IFtQ
QVRDSF0gRFQ6IGFkZCBNRElPIG5vZGUgZm9yIEZNYW4gbm9kZQ0KPiA+ID4gPiA+ID4gPg0KPiA+
ID4gPiA+ID4gPiBPbiBUdWUsIDIwMTQtMTEtMDQgYXQgMTk6NTYgKzA4MDAsIHNoaC54aWVAZ21h
aWwuY29tIHdyb3RlOg0KPiA+ID4gPiA+ID4gPiA+IEZyb206IFNoYW9odWkgWGllIDxTaGFvaHVp
LlhpZUBmcmVlc2NhbGUuY29tPg0KPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4gVGhp
cyBiaW5kaW5nIGlzIGZvciBGTWFuIE1ESU8sIGl0IGNvdmVycyBGTWFuIHYyICYgRk1hbiB2My4N
Cj4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+IFNpZ25lZC1vZmYtYnk6IFNoYW9odWkg
WGllIDxTaGFvaHVpLlhpZUBmcmVlc2NhbGUuY29tPg0KPiA+ID4gPiA+ID4gPiA+IC0tLQ0KPiA+
ID4gPiA+ID4gPiA+IGJhc2VkIG9uIGh0dHA6Ly9wYXRjaHdvcmsub3psYWJzLm9yZy9wYXRjaC8z
OTAzNTEvDQo+ID4gPiA+ID4gPiA+ID4gZm9yICduZXh0JyBvZg0KPiA+ID4gPiA+ID4gPiA+DQo+
IGdpdDovL2dpdC5rZXJuZWwub3JnL3B1Yi9zY20vbGludXgva2VybmVsL2dpdC9zY290dHdvb2Qv
bGludXguDQo+ID4gPiA+ID4gPiA+ID4gZ2l0DQo+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+
IEFyZSB0aGVyZSBhbnkgb3RoZXIgRk1hbiBwaWVjZXMgdGhhdCBhcmUgbWlzc2luZyBmcm9tIHRo
ZQ0KPiA+ID4gPiA+ID4gPiBhYm92ZQ0KPiA+ID4gcGF0Y2g/DQo+ID4gPiA+ID4gPiBbUy5IXSBJ
J20gYWRkaW5nIElnYWwgZm9yIHRoaXMgY29tbWVudC4NCj4gPiA+ID4gPiA+DQo+ID4gPiA+ID4g
PiA+DQo+ID4gPiA+ID4gPiA+ID4gKy0gYnVzLWZyZXF1ZW5jeQ0KPiA+ID4gPiA+ID4gPiA+ICsJ
CVVzYWdlOiBvcHRpb25hbA0KPiA+ID4gPiA+ID4gPiA+ICsJCVZhbHVlIHR5cGU6IDx1MzI+DQo+
ID4gPiA+ID4gPiA+ID4gKwkJRGVmaW5pdGlvbjogRGVmYXVsdCBNRElPIGJ1cyBjbG9jayBzcGVl
ZC4NCj4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gVXNlIGNsb2Nrcy9jbG9jay1uYW1lcw0K
PiA+ID4gPiA+ID4gW1MuSF0gVGhlIE1ESU8gdXNlcyBGbWFuIGNsb2NrIGFuZCBkaXZpZGVzIGl0
IHRvIGEgcHJvcGVyDQo+ID4gPiA+ID4gPiB2YWx1ZSB3aGljaA0KPiA+ID4gPiA+IGlzIHNwZWNp
ZmllZCBieSB0aGlzIHByb3BlcnR5Lg0KPiA+ID4gPiA+DQo+ID4gPiA+ID4gVXNlIGNsb2Nrcy9j
bG9jay1uYW1lcyB0byBkZXNjcmliZSB0aGF0IHJlbGF0aW9uc2hpcC4NCj4gPiA+ID4gPg0KPiA+
ID4gPg0KPiA+ID4gPiBbUy5IXSBUaGUgTURJTyBub2RlIGlzIHN1Yi1ub2RlIGFuZCBlbWJlZGRl
ZCBpbiBGbWFuIG5vZGUsIHRoZQ0KPiA+ID4gPiBjbG9ja3MvY2xvY2stbmFtZXMgaXMgcHJvdmlk
ZWQgYnkgRm1hbiBub2RlLCBzaG91bGQgcmVwZWF0IHRoZW0gaW4NCj4gPiA+ID4gTURJTyBub2Rl
PyBGb3IgdGhlIGRlZmF1bHQgTURJTyBidXMgY2xvY2sgc3BlZWQsIG1heWJlICJjbG9jay0NCj4g
cmFuZ2VzIg0KPiA+ID4gPiBzaG91bGQgYmUgdXNlZD8NCj4gPiA+DQo+ID4gPiBJdCdzIGEgZGlm
ZmVyZW50IGNsb2NrLiAgWW91IHdvdWxkbid0IGJlIHJlcGVhdGluZy4gIElmIGl0J3MgZGVyaXZl
ZA0KPiA+ID4gZnJvbSB0aGUgRk1hbiBjbG9jaywgdGhlbiBtYXliZSB5b3UgZG9uJ3QgbmVlZCBh
bnl0aGluZyBoZXJlIChkb2VzDQo+ID4gPiB0aGUgZHJpdmVyIGtub3cgd2hhdCB0aGUgZGl2aWRl
ciBpcywgb3Igd291bGQgdGhhdCBuZWVkIHRvIGJlDQo+ID4gPiBzcGVjaWZpZWQgaW4gdGhlIGRl
dmljZSB0cmVlPyksIGJ1dCBubyBtb3JlIGNsb2NrLWZyZXF1ZW5jeS9idXMtDQo+IGZyZXF1ZW5j
eSBwcm9wZXJ0aWVzLg0KPiA+ID4NCj4gPiBbUy5IXSBUaGUgcHVycG9zZSBoZXJlIGlzIHRvIGdl
dCBhIHNwZWNpZmljIGNsb2NrIGZyZXF1ZW5jeSwgZHJpdmVyIHRvDQo+IHVzZSBpdCB0byBjYWxj
dWxhdGUgdGhlIGRpdmlkZXIuDQo+ID4gVGhlbiB0aGUgRm1hbiBjbG9jayBjYW4gYmUgZGl2aWRl
ZCB0byB0aGUgZnJlcXVlbmN5Lg0KPiANCj4gT2gsIHNvIHRoaXMgaXMgc3RhdGluZyBhIGRlc2ly
ZWQgZnJlcXVlbmN5IGFuZCBub3Qgc29tZXRoaW5nIHRoYXQgYWxyZWFkeQ0KPiBleGlzdHM/ICBX
aGF0IGRldGVybWluZXMgdGhpcyBmcmVxdWVuY3k/ICBJcyBpdCBiYXNlZCBvbiBib2FyZCBkZXNp
Z24sIG9yDQo+IGp1c3Qgb24gdGhlIE1ESU8gc3RhbmRhcmQsIGV0Yz8gIEknbSB3b25kZXJpbmcg
aWYgdGhlIGRldmljZSB0cmVlIGlzIHRoZQ0KPiByaWdodCBwbGFjZSBmb3IgaXQuDQpbUy5IXSBZ
ZXMsIGEgZGVzaXJlZCBmcmVxdWVuY3kgd2hpY2ggaXMgZGlmZmVyZW50IHdpdGggTURJTyBzdGFu
ZGFyZC4NClRoZSBGbWFuIGNsb2NrIGFuZCB0aGUgZGl2aWRlciBkZXRlcm1pbmVzIHRoaXMgZnJl
cXVlbmN5Lg0KU2luY2UgRm1hbiBjbG9jayBpcyBkaWZmZXJlbnQgb24gZGlmZmVyZW50IFNvQ3Ms
IHNvIHNwZWNpZnkgdGhlIGRlc2lyZWQgZnJlcXVlbmN5LCANCnRoZW4gdG8gZ2V0IHRoZSBwcm9w
ZXIgZGl2aWRlci4NCg0KDQpUaGFua3MuDQpzaGFvaHVpDQo=

Re: [PATCH] DT: add MDIO node for FMan node

[Scott Wood]

On Thu, 2014-11-13 at 02:02 -0600, Xie Shaohui-B21989 wrote:
> 
> 
> Best Regards, 
> Shaohui Xie
> 
> 
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Thursday, November 13, 2014 3:15 PM
> > To: Xie Shaohui-B21989
> > Cc: Liberman Igal-B31950; linuxppc-dev@lists.ozlabs.org;
> > devicetree@vger.kernel.org; Medve Emilian-EMMEDVE1
> > Subject: Re: [PATCH] DT: add MDIO node for FMan node
> > 
> > On Thu, 2014-11-13 at 01:11 -0600, Xie Shaohui-B21989 wrote:
> > > > -----Original Message-----
> > > > From: Wood Scott-B07421
> > > > Sent: Thursday, November 13, 2014 2:17 PM
> > > > To: Xie Shaohui-B21989
> > > > Cc: Liberman Igal-B31950; linuxppc-dev@lists.ozlabs.org;
> > > > devicetree@vger.kernel.org; Medve Emilian-EMMEDVE1
> > > > Subject: Re: [PATCH] DT: add MDIO node for FMan node
> > > >
> > > > On Wed, 2014-11-12 at 07:40 -0600, Xie Shaohui-B21989 wrote:
> > > > > > -----Original Message-----
> > > > > > From: Wood Scott-B07421
> > > > > > Sent: Wednesday, November 12, 2014 1:38 AM
> > > > > > To: Xie Shaohui-B21989
> > > > > > Cc: Liberman Igal-B31950; linuxppc-dev@lists.ozlabs.org;
> > > > > > devicetree@vger.kernel.org; Medve Emilian-EMMEDVE1
> > > > > > Subject: Re: [PATCH] DT: add MDIO node for FMan node
> > > > > >
> > > > > > On Tue, 2014-11-11 at 04:32 -0600, Xie Shaohui-B21989 wrote:
> > > > > > > > -----Original Message-----
> > > > > > > > From: Wood Scott-B07421
> > > > > > > > Sent: Tuesday, November 11, 2014 8:23 AM
> > > > > > > > To: shh.xie@gmail.com
> > > > > > > > Cc: linuxppc-dev@lists.ozlabs.org;
> > > > > > > > devicetree@vger.kernel.org; Medve Emilian-EMMEDVE1; Xie
> > > > > > > > Shaohui-B21989
> > > > > > > > Subject: Re: [PATCH] DT: add MDIO node for FMan node
> > > > > > > >
> > > > > > > > On Tue, 2014-11-04 at 19:56 +0800, shh.xie@gmail.com wrote:
> > > > > > > > > From: Shaohui Xie <Shaohui.Xie@freescale.com>
> > > > > > > > >
> > > > > > > > > This binding is for FMan MDIO, it covers FMan v2 & FMan v3.
> > > > > > > > >
> > > > > > > > > Signed-off-by: Shaohui Xie <Shaohui.Xie@freescale.com>
> > > > > > > > > ---
> > > > > > > > > based on http://patchwork.ozlabs.org/patch/390351/
> > > > > > > > > for 'next' of
> > > > > > > > >
> > git://git.kernel.org/pub/scm/linux/kernel/git/scottwood/linux.
> > > > > > > > > git
> > > > > > > >
> > > > > > > > Are there any other FMan pieces that are missing from the
> > > > > > > > above
> > > > patch?
> > > > > > > [S.H] I'm adding Igal for this comment.
> > > > > > >
> > > > > > > >
> > > > > > > > > +- bus-frequency
> > > > > > > > > +		Usage: optional
> > > > > > > > > +		Value type: <u32>
> > > > > > > > > +		Definition: Default MDIO bus clock speed.
> > > > > > > >
> > > > > > > > Use clocks/clock-names
> > > > > > > [S.H] The MDIO uses Fman clock and divides it to a proper
> > > > > > > value which
> > > > > > is specified by this property.
> > > > > >
> > > > > > Use clocks/clock-names to describe that relationship.
> > > > > >
> > > > >
> > > > > [S.H] The MDIO node is sub-node and embedded in Fman node, the
> > > > > clocks/clock-names is provided by Fman node, should repeat them in
> > > > > MDIO node? For the default MDIO bus clock speed, maybe "clock-
> > ranges"
> > > > > should be used?
> > > >
> > > > It's a different clock.  You wouldn't be repeating.  If it's derived
> > > > from the FMan clock, then maybe you don't need anything here (does
> > > > the driver know what the divider is, or would that need to be
> > > > specified in the device tree?), but no more clock-frequency/bus-
> > frequency properties.
> > > >
> > > [S.H] The purpose here is to get a specific clock frequency, driver to
> > use it to calculate the divider.
> > > Then the Fman clock can be divided to the frequency.
> > 
> > Oh, so this is stating a desired frequency and not something that already
> > exists?  What determines this frequency?  Is it based on board design, or
> > just on the MDIO standard, etc?  I'm wondering if the device tree is the
> > right place for it.
> [S.H] Yes, a desired frequency which is different with MDIO standard.

I'm not sure what you mean by "different with".  Do you mean "different
from"?  What does the standard say about frequency?

> The Fman clock and the divider determines this frequency.
> Since Fman clock is different on different SoCs, so specify the desired frequency, 
> then to get the proper divider.

Why does the fman clock being different mean the mdio clock should be
different?

-Scott

RE: [PATCH] DT: add MDIO node for FMan node

[Shaohui Xie]

DQoNCkJlc3QgUmVnYXJkcywgDQpTaGFvaHVpIFhpZQ0KDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNz
YWdlLS0tLS0NCj4gRnJvbTogV29vZCBTY290dC1CMDc0MjENCj4gU2VudDogVGh1cnNkYXksIE5v
dmVtYmVyIDEzLCAyMDE0IDQ6MDQgUE0NCj4gVG86IFhpZSBTaGFvaHVpLUIyMTk4OQ0KPiBDYzog
TGliZXJtYW4gSWdhbC1CMzE5NTA7IGxpbnV4cHBjLWRldkBsaXN0cy5vemxhYnMub3JnOw0KPiBk
ZXZpY2V0cmVlQHZnZXIua2VybmVsLm9yZzsgTWVkdmUgRW1pbGlhbi1FTU1FRFZFMQ0KPiBTdWJq
ZWN0OiBSZTogW1BBVENIXSBEVDogYWRkIE1ESU8gbm9kZSBmb3IgRk1hbiBub2RlDQo+IA0KPiBP
biBUaHUsIDIwMTQtMTEtMTMgYXQgMDI6MDIgLTA2MDAsIFhpZSBTaGFvaHVpLUIyMTk4OSB3cm90
ZToNCj4gPg0KPiA+DQo+ID4gQmVzdCBSZWdhcmRzLA0KPiA+IFNoYW9odWkgWGllDQo+ID4NCj4g
Pg0KPiA+ID4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gPiA+IEZyb206IFdvb2QgU2Nv
dHQtQjA3NDIxDQo+ID4gPiBTZW50OiBUaHVyc2RheSwgTm92ZW1iZXIgMTMsIDIwMTQgMzoxNSBQ
TQ0KPiA+ID4gVG86IFhpZSBTaGFvaHVpLUIyMTk4OQ0KPiA+ID4gQ2M6IExpYmVybWFuIElnYWwt
QjMxOTUwOyBsaW51eHBwYy1kZXZAbGlzdHMub3psYWJzLm9yZzsNCj4gPiA+IGRldmljZXRyZWVA
dmdlci5rZXJuZWwub3JnOyBNZWR2ZSBFbWlsaWFuLUVNTUVEVkUxDQo+ID4gPiBTdWJqZWN0OiBS
ZTogW1BBVENIXSBEVDogYWRkIE1ESU8gbm9kZSBmb3IgRk1hbiBub2RlDQo+ID4gPg0KPiA+ID4g
T24gVGh1LCAyMDE0LTExLTEzIGF0IDAxOjExIC0wNjAwLCBYaWUgU2hhb2h1aS1CMjE5ODkgd3Jv
dGU6DQo+ID4gPiA+ID4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gPiA+ID4gPiBGcm9t
OiBXb29kIFNjb3R0LUIwNzQyMQ0KPiA+ID4gPiA+IFNlbnQ6IFRodXJzZGF5LCBOb3ZlbWJlciAx
MywgMjAxNCAyOjE3IFBNDQo+ID4gPiA+ID4gVG86IFhpZSBTaGFvaHVpLUIyMTk4OQ0KPiA+ID4g
PiA+IENjOiBMaWJlcm1hbiBJZ2FsLUIzMTk1MDsgbGludXhwcGMtZGV2QGxpc3RzLm96bGFicy5v
cmc7DQo+ID4gPiA+ID4gZGV2aWNldHJlZUB2Z2VyLmtlcm5lbC5vcmc7IE1lZHZlIEVtaWxpYW4t
RU1NRURWRTENCj4gPiA+ID4gPiBTdWJqZWN0OiBSZTogW1BBVENIXSBEVDogYWRkIE1ESU8gbm9k
ZSBmb3IgRk1hbiBub2RlDQo+ID4gPiA+ID4NCj4gPiA+ID4gPiBPbiBXZWQsIDIwMTQtMTEtMTIg
YXQgMDc6NDAgLTA2MDAsIFhpZSBTaGFvaHVpLUIyMTk4OSB3cm90ZToNCj4gPiA+ID4gPiA+ID4g
LS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gPiA+ID4gPiA+ID4gRnJvbTogV29vZCBTY290
dC1CMDc0MjENCj4gPiA+ID4gPiA+ID4gU2VudDogV2VkbmVzZGF5LCBOb3ZlbWJlciAxMiwgMjAx
NCAxOjM4IEFNDQo+ID4gPiA+ID4gPiA+IFRvOiBYaWUgU2hhb2h1aS1CMjE5ODkNCj4gPiA+ID4g
PiA+ID4gQ2M6IExpYmVybWFuIElnYWwtQjMxOTUwOyBsaW51eHBwYy1kZXZAbGlzdHMub3psYWJz
Lm9yZzsNCj4gPiA+ID4gPiA+ID4gZGV2aWNldHJlZUB2Z2VyLmtlcm5lbC5vcmc7IE1lZHZlIEVt
aWxpYW4tRU1NRURWRTENCj4gPiA+ID4gPiA+ID4gU3ViamVjdDogUmU6IFtQQVRDSF0gRFQ6IGFk
ZCBNRElPIG5vZGUgZm9yIEZNYW4gbm9kZQ0KPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiBP
biBUdWUsIDIwMTQtMTEtMTEgYXQgMDQ6MzIgLTA2MDAsIFhpZSBTaGFvaHVpLUIyMTk4OSB3cm90
ZToNCj4gPiA+ID4gPiA+ID4gPiA+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+ID4gPiA+
ID4gPiA+ID4gPiBGcm9tOiBXb29kIFNjb3R0LUIwNzQyMQ0KPiA+ID4gPiA+ID4gPiA+ID4gU2Vu
dDogVHVlc2RheSwgTm92ZW1iZXIgMTEsIDIwMTQgODoyMyBBTQ0KPiA+ID4gPiA+ID4gPiA+ID4g
VG86IHNoaC54aWVAZ21haWwuY29tDQo+ID4gPiA+ID4gPiA+ID4gPiBDYzogbGludXhwcGMtZGV2
QGxpc3RzLm96bGFicy5vcmc7DQo+ID4gPiA+ID4gPiA+ID4gPiBkZXZpY2V0cmVlQHZnZXIua2Vy
bmVsLm9yZzsgTWVkdmUgRW1pbGlhbi1FTU1FRFZFMTsgWGllDQo+ID4gPiA+ID4gPiA+ID4gPiBT
aGFvaHVpLUIyMTk4OQ0KPiA+ID4gPiA+ID4gPiA+ID4gU3ViamVjdDogUmU6IFtQQVRDSF0gRFQ6
IGFkZCBNRElPIG5vZGUgZm9yIEZNYW4gbm9kZQ0KPiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4g
PiA+ID4gPiA+IE9uIFR1ZSwgMjAxNC0xMS0wNCBhdCAxOTo1NiArMDgwMCwgc2hoLnhpZUBnbWFp
bC5jb20NCj4gd3JvdGU6DQo+ID4gPiA+ID4gPiA+ID4gPiA+IEZyb206IFNoYW9odWkgWGllIDxT
aGFvaHVpLlhpZUBmcmVlc2NhbGUuY29tPg0KPiA+ID4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+
ID4gPiA+ID4gPiBUaGlzIGJpbmRpbmcgaXMgZm9yIEZNYW4gTURJTywgaXQgY292ZXJzIEZNYW4g
djIgJiBGTWFuDQo+IHYzLg0KPiA+ID4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ID4g
PiBTaWduZWQtb2ZmLWJ5OiBTaGFvaHVpIFhpZSA8U2hhb2h1aS5YaWVAZnJlZXNjYWxlLmNvbT4N
Cj4gPiA+ID4gPiA+ID4gPiA+ID4gLS0tDQo+ID4gPiA+ID4gPiA+ID4gPiA+IGJhc2VkIG9uIGh0
dHA6Ly9wYXRjaHdvcmsub3psYWJzLm9yZy9wYXRjaC8zOTAzNTEvDQo+ID4gPiA+ID4gPiA+ID4g
PiA+IGZvciAnbmV4dCcgb2YNCj4gPiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+IGdpdDovL2dpdC5r
ZXJuZWwub3JnL3B1Yi9zY20vbGludXgva2VybmVsL2dpdC9zY290dHdvb2QvbGludXguDQo+ID4g
PiA+ID4gPiA+ID4gPiA+IGdpdA0KPiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+
IEFyZSB0aGVyZSBhbnkgb3RoZXIgRk1hbiBwaWVjZXMgdGhhdCBhcmUgbWlzc2luZyBmcm9tDQo+
ID4gPiA+ID4gPiA+ID4gPiB0aGUgYWJvdmUNCj4gPiA+ID4gPiBwYXRjaD8NCj4gPiA+ID4gPiA+
ID4gPiBbUy5IXSBJJ20gYWRkaW5nIElnYWwgZm9yIHRoaXMgY29tbWVudC4NCj4gPiA+ID4gPiA+
ID4gPg0KPiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gKy0gYnVzLWZyZXF1
ZW5jeQ0KPiA+ID4gPiA+ID4gPiA+ID4gPiArCQlVc2FnZTogb3B0aW9uYWwNCj4gPiA+ID4gPiA+
ID4gPiA+ID4gKwkJVmFsdWUgdHlwZTogPHUzMj4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gKwkJRGVm
aW5pdGlvbjogRGVmYXVsdCBNRElPIGJ1cyBjbG9jayBzcGVlZC4NCj4gPiA+ID4gPiA+ID4gPiA+
DQo+ID4gPiA+ID4gPiA+ID4gPiBVc2UgY2xvY2tzL2Nsb2NrLW5hbWVzDQo+ID4gPiA+ID4gPiA+
ID4gW1MuSF0gVGhlIE1ESU8gdXNlcyBGbWFuIGNsb2NrIGFuZCBkaXZpZGVzIGl0IHRvIGEgcHJv
cGVyDQo+ID4gPiA+ID4gPiA+ID4gdmFsdWUgd2hpY2gNCj4gPiA+ID4gPiA+ID4gaXMgc3BlY2lm
aWVkIGJ5IHRoaXMgcHJvcGVydHkuDQo+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+IFVzZSBj
bG9ja3MvY2xvY2stbmFtZXMgdG8gZGVzY3JpYmUgdGhhdCByZWxhdGlvbnNoaXAuDQo+ID4gPiA+
ID4gPiA+DQo+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gW1MuSF0gVGhlIE1ESU8gbm9kZSBpcyBz
dWItbm9kZSBhbmQgZW1iZWRkZWQgaW4gRm1hbiBub2RlLCB0aGUNCj4gPiA+ID4gPiA+IGNsb2Nr
cy9jbG9jay1uYW1lcyBpcyBwcm92aWRlZCBieSBGbWFuIG5vZGUsIHNob3VsZCByZXBlYXQNCj4g
PiA+ID4gPiA+IHRoZW0gaW4gTURJTyBub2RlPyBGb3IgdGhlIGRlZmF1bHQgTURJTyBidXMgY2xv
Y2sgc3BlZWQsIG1heWJlDQo+ID4gPiA+ID4gPiAiY2xvY2stDQo+ID4gPiByYW5nZXMiDQo+ID4g
PiA+ID4gPiBzaG91bGQgYmUgdXNlZD8NCj4gPiA+ID4gPg0KPiA+ID4gPiA+IEl0J3MgYSBkaWZm
ZXJlbnQgY2xvY2suICBZb3Ugd291bGRuJ3QgYmUgcmVwZWF0aW5nLiAgSWYgaXQncw0KPiA+ID4g
PiA+IGRlcml2ZWQgZnJvbSB0aGUgRk1hbiBjbG9jaywgdGhlbiBtYXliZSB5b3UgZG9uJ3QgbmVl
ZCBhbnl0aGluZw0KPiA+ID4gPiA+IGhlcmUgKGRvZXMgdGhlIGRyaXZlciBrbm93IHdoYXQgdGhl
IGRpdmlkZXIgaXMsIG9yIHdvdWxkIHRoYXQNCj4gPiA+ID4gPiBuZWVkIHRvIGJlIHNwZWNpZmll
ZCBpbiB0aGUgZGV2aWNlIHRyZWU/KSwgYnV0IG5vIG1vcmUNCj4gPiA+ID4gPiBjbG9jay1mcmVx
dWVuY3kvYnVzLQ0KPiA+ID4gZnJlcXVlbmN5IHByb3BlcnRpZXMuDQo+ID4gPiA+ID4NCj4gPiA+
ID4gW1MuSF0gVGhlIHB1cnBvc2UgaGVyZSBpcyB0byBnZXQgYSBzcGVjaWZpYyBjbG9jayBmcmVx
dWVuY3ksDQo+ID4gPiA+IGRyaXZlciB0bw0KPiA+ID4gdXNlIGl0IHRvIGNhbGN1bGF0ZSB0aGUg
ZGl2aWRlci4NCj4gPiA+ID4gVGhlbiB0aGUgRm1hbiBjbG9jayBjYW4gYmUgZGl2aWRlZCB0byB0
aGUgZnJlcXVlbmN5Lg0KPiA+ID4NCj4gPiA+IE9oLCBzbyB0aGlzIGlzIHN0YXRpbmcgYSBkZXNp
cmVkIGZyZXF1ZW5jeSBhbmQgbm90IHNvbWV0aGluZyB0aGF0DQo+ID4gPiBhbHJlYWR5IGV4aXN0
cz8gIFdoYXQgZGV0ZXJtaW5lcyB0aGlzIGZyZXF1ZW5jeT8gIElzIGl0IGJhc2VkIG9uDQo+ID4g
PiBib2FyZCBkZXNpZ24sIG9yIGp1c3Qgb24gdGhlIE1ESU8gc3RhbmRhcmQsIGV0Yz8gIEknbSB3
b25kZXJpbmcgaWYNCj4gPiA+IHRoZSBkZXZpY2UgdHJlZSBpcyB0aGUgcmlnaHQgcGxhY2UgZm9y
IGl0Lg0KPiA+IFtTLkhdIFllcywgYSBkZXNpcmVkIGZyZXF1ZW5jeSB3aGljaCBpcyBkaWZmZXJl
bnQgd2l0aCBNRElPIHN0YW5kYXJkLg0KPiANCj4gSSdtIG5vdCBzdXJlIHdoYXQgeW91IG1lYW4g
YnkgImRpZmZlcmVudCB3aXRoIi4gIERvIHlvdSBtZWFuICJkaWZmZXJlbnQNCj4gZnJvbSI/ICBX
aGF0IGRvZXMgdGhlIHN0YW5kYXJkIHNheSBhYm91dCBmcmVxdWVuY3k/DQpbUy5IXSBUaGUgc3Rh
bmRhcmQgTURJTyBmcmVxdWVuY3kgaXMgMi41TUh6LiAgQnV0IGEgZGlmZmVyZW50IG9uZSBpcyBk
ZXNpcmVkLg0KDQo+IA0KPiA+IFRoZSBGbWFuIGNsb2NrIGFuZCB0aGUgZGl2aWRlciBkZXRlcm1p
bmVzIHRoaXMgZnJlcXVlbmN5Lg0KPiA+IFNpbmNlIEZtYW4gY2xvY2sgaXMgZGlmZmVyZW50IG9u
IGRpZmZlcmVudCBTb0NzLCBzbyBzcGVjaWZ5IHRoZQ0KPiA+IGRlc2lyZWQgZnJlcXVlbmN5LCB0
aGVuIHRvIGdldCB0aGUgcHJvcGVyIGRpdmlkZXIuDQo+IA0KPiBXaHkgZG9lcyB0aGUgZm1hbiBj
bG9jayBiZWluZyBkaWZmZXJlbnQgbWVhbiB0aGUgbWRpbyBjbG9jayBzaG91bGQgYmUNCj4gZGlm
ZmVyZW50Pw0KW1MuSF0gVGhlIG1kaW8gY2xvY2sgc2hvdWxkIGJlIHNhbWUsIGEgZGlmZmVyZW50
IGRpdmlkZXIgc2hvdWxkIGJlIHVzZWQgDQp0byBtYXRjaCB0aGUgRm1hbiBjbG9jayB0byBtYWtl
IHN1cmUgdGhlIG1kaW8gY2xvY2sga2VwdCBzYW1lLiBTbyB0byBzcGVjaWZ5DQpUaGUgZGVzaXJl
ZCBtZGlvIGZyZXF1ZW5jeSwgdGhlbiB0byBnZXQgcHJvcGVyIGRpdmlkZXIuDQoNClRoYW5rcy4N
ClNoYW9odWkNCg==

Re: [PATCH] DT: add MDIO node for FMan node

[Scott Wood]

On Thu, 2014-11-13 at 02:27 -0600, Xie Shaohui-B21989 wrote:
> 
> 
> Best Regards, 
> Shaohui Xie
> 
> 
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Thursday, November 13, 2014 4:04 PM
> > To: Xie Shaohui-B21989
> > Cc: Liberman Igal-B31950; linuxppc-dev@lists.ozlabs.org;
> > devicetree@vger.kernel.org; Medve Emilian-EMMEDVE1
> > Subject: Re: [PATCH] DT: add MDIO node for FMan node
> > 
> > On Thu, 2014-11-13 at 02:02 -0600, Xie Shaohui-B21989 wrote:
> > >
> > >
> > > Best Regards,
> > > Shaohui Xie
> > >
> > >
> > > > -----Original Message-----
> > > > From: Wood Scott-B07421
> > > > Sent: Thursday, November 13, 2014 3:15 PM
> > > > To: Xie Shaohui-B21989
> > > > Cc: Liberman Igal-B31950; linuxppc-dev@lists.ozlabs.org;
> > > > devicetree@vger.kernel.org; Medve Emilian-EMMEDVE1
> > > > Subject: Re: [PATCH] DT: add MDIO node for FMan node
> > > >
> > > > On Thu, 2014-11-13 at 01:11 -0600, Xie Shaohui-B21989 wrote:
> > > > > > -----Original Message-----
> > > > > > From: Wood Scott-B07421
> > > > > > Sent: Thursday, November 13, 2014 2:17 PM
> > > > > > To: Xie Shaohui-B21989
> > > > > > Cc: Liberman Igal-B31950; linuxppc-dev@lists.ozlabs.org;
> > > > > > devicetree@vger.kernel.org; Medve Emilian-EMMEDVE1
> > > > > > Subject: Re: [PATCH] DT: add MDIO node for FMan node
> > > > > >
> > > > > > On Wed, 2014-11-12 at 07:40 -0600, Xie Shaohui-B21989 wrote:
> > > > > > > > -----Original Message-----
> > > > > > > > From: Wood Scott-B07421
> > > > > > > > Sent: Wednesday, November 12, 2014 1:38 AM
> > > > > > > > To: Xie Shaohui-B21989
> > > > > > > > Cc: Liberman Igal-B31950; linuxppc-dev@lists.ozlabs.org;
> > > > > > > > devicetree@vger.kernel.org; Medve Emilian-EMMEDVE1
> > > > > > > > Subject: Re: [PATCH] DT: add MDIO node for FMan node
> > > > > > > >
> > > > > > > > On Tue, 2014-11-11 at 04:32 -0600, Xie Shaohui-B21989 wrote:
> > > > > > > > > > -----Original Message-----
> > > > > > > > > > From: Wood Scott-B07421
> > > > > > > > > > Sent: Tuesday, November 11, 2014 8:23 AM
> > > > > > > > > > To: shh.xie@gmail.com
> > > > > > > > > > Cc: linuxppc-dev@lists.ozlabs.org;
> > > > > > > > > > devicetree@vger.kernel.org; Medve Emilian-EMMEDVE1; Xie
> > > > > > > > > > Shaohui-B21989
> > > > > > > > > > Subject: Re: [PATCH] DT: add MDIO node for FMan node
> > > > > > > > > >
> > > > > > > > > > On Tue, 2014-11-04 at 19:56 +0800, shh.xie@gmail.com
> > wrote:
> > > > > > > > > > > From: Shaohui Xie <Shaohui.Xie@freescale.com>
> > > > > > > > > > >
> > > > > > > > > > > This binding is for FMan MDIO, it covers FMan v2 & FMan
> > v3.
> > > > > > > > > > >
> > > > > > > > > > > Signed-off-by: Shaohui Xie <Shaohui.Xie@freescale.com>
> > > > > > > > > > > ---
> > > > > > > > > > > based on http://patchwork.ozlabs.org/patch/390351/
> > > > > > > > > > > for 'next' of
> > > > > > > > > > >
> > > > git://git.kernel.org/pub/scm/linux/kernel/git/scottwood/linux.
> > > > > > > > > > > git
> > > > > > > > > >
> > > > > > > > > > Are there any other FMan pieces that are missing from
> > > > > > > > > > the above
> > > > > > patch?
> > > > > > > > > [S.H] I'm adding Igal for this comment.
> > > > > > > > >
> > > > > > > > > >
> > > > > > > > > > > +- bus-frequency
> > > > > > > > > > > +		Usage: optional
> > > > > > > > > > > +		Value type: <u32>
> > > > > > > > > > > +		Definition: Default MDIO bus clock speed.
> > > > > > > > > >
> > > > > > > > > > Use clocks/clock-names
> > > > > > > > > [S.H] The MDIO uses Fman clock and divides it to a proper
> > > > > > > > > value which
> > > > > > > > is specified by this property.
> > > > > > > >
> > > > > > > > Use clocks/clock-names to describe that relationship.
> > > > > > > >
> > > > > > >
> > > > > > > [S.H] The MDIO node is sub-node and embedded in Fman node, the
> > > > > > > clocks/clock-names is provided by Fman node, should repeat
> > > > > > > them in MDIO node? For the default MDIO bus clock speed, maybe
> > > > > > > "clock-
> > > > ranges"
> > > > > > > should be used?
> > > > > >
> > > > > > It's a different clock.  You wouldn't be repeating.  If it's
> > > > > > derived from the FMan clock, then maybe you don't need anything
> > > > > > here (does the driver know what the divider is, or would that
> > > > > > need to be specified in the device tree?), but no more
> > > > > > clock-frequency/bus-
> > > > frequency properties.
> > > > > >
> > > > > [S.H] The purpose here is to get a specific clock frequency,
> > > > > driver to
> > > > use it to calculate the divider.
> > > > > Then the Fman clock can be divided to the frequency.
> > > >
> > > > Oh, so this is stating a desired frequency and not something that
> > > > already exists?  What determines this frequency?  Is it based on
> > > > board design, or just on the MDIO standard, etc?  I'm wondering if
> > > > the device tree is the right place for it.
> > > [S.H] Yes, a desired frequency which is different with MDIO standard.
> > 
> > I'm not sure what you mean by "different with".  Do you mean "different
> > from"?  What does the standard say about frequency?
> [S.H] The standard MDIO frequency is 2.5MHz.  But a different one is desired.

Why is a different frequency desired?

> > 
> > > The Fman clock and the divider determines this frequency.
> > > Since Fman clock is different on different SoCs, so specify the
> > > desired frequency, then to get the proper divider.
> > 
> > Why does the fman clock being different mean the mdio clock should be
> > different?
> [S.H] The mdio clock should be same, a different divider should be used 
> to match the Fman clock to make sure the mdio clock kept same. So to specify
> The desired mdio frequency, then to get proper divider.

What I'm trying to determine is why the MDIO frequency wouldn't always
be the same, and thus could be hardcoded in the driver rather than in
the device tree.

-Scott