From: Scott Wood <scottwood@freescale.com>
To: Emil Medve <Emilian.Medve@Freescale.com>
Cc: Poonam Aggrwal <poonam.aggrwal@Freescale.com>,
Geoff Thorpe <Geoff.Thorpe@Freescale.com>,
linuxppc-dev@ozlabs.org, Chunhe Lan <Chunhe.Lan@Freescale.com>
Subject: Re: [PATCH 2/2] powerpc/mpc85xx: Add DPAA Q/BMan support to device tree(s)
Date: Thu, 13 Nov 2014 15:42:03 -0600 [thread overview]
Message-ID: <1415914923.15957.64.camel@freescale.com> (raw)
In-Reply-To: <1415870513-10632-1-git-send-email-Emilian.Medve@Freescale.com>
On Thu, 2014-11-13 at 03:21 -0600, Emil Medve wrote:
> From: Kumar Gala <galak@kernel.crashing.org>
>
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> Signed-off-by: Geoff Thorpe <Geoff.Thorpe@freescale.com>
> Signed-off-by: Hai-Ying Wang <Haiying.Wang@freescale.com>
> Signed-off-by: Chunhe Lan <Chunhe.Lan@freescale.com>
> Signed-off-by: Poonam Aggrwal <poonam.aggrwal@freescale.com>
> Signed-off-by: Emil Medve <Emilian.Medve@Freescale.com>
> Change-Id: If643fa5ba0a903aef8f5056a2c90ebecc995b760
I suspect these patches are changed quite a bit from Kumar's version...
It's good to note changes after the listed author has stopped being
involved, so they don't get the blame for anything they wouldn't have
put in there.
Why is the devicetree list not CCed?
> ---
>
> Based on:
> http://patchwork.ozlabs.org/patch/407034
> http://patchwork.ozlabs.org/patch/407037
> http://patchwork.ozlabs.org/patch/407035
> http://patchwork.ozlabs.org/patch/407036
>
> arch/powerpc/boot/dts/b4qds.dtsi | 42 +-
> arch/powerpc/boot/dts/fsl/b4420si-post.dtsi | 2 +-
> arch/powerpc/boot/dts/fsl/b4420si-pre.dtsi | 2 +-
> arch/powerpc/boot/dts/fsl/b4860si-post.dtsi | 129 ++++++-
> arch/powerpc/boot/dts/fsl/b4860si-pre.dtsi | 3 +-
> arch/powerpc/boot/dts/fsl/b4si-post.dtsi | 180 ++++++++-
> arch/powerpc/boot/dts/fsl/p1023si-post.dtsi | 61 ++-
> arch/powerpc/boot/dts/fsl/p1023si-pre.dtsi | 2 +-
> arch/powerpc/boot/dts/fsl/p2041si-post.dtsi | 9 +-
> arch/powerpc/boot/dts/fsl/p3041si-post.dtsi | 9 +-
> arch/powerpc/boot/dts/fsl/p4080si-post.dtsi | 9 +-
> arch/powerpc/boot/dts/fsl/p5020si-post.dtsi | 9 +-
> arch/powerpc/boot/dts/fsl/p5040si-post.dtsi | 9 +-
> arch/powerpc/boot/dts/fsl/t1040si-post.dtsi | 128 ++++++-
> arch/powerpc/boot/dts/fsl/t2081si-post.dtsi | 216 ++++++++++-
> arch/powerpc/boot/dts/fsl/t4240si-post.dtsi | 568 +++++++++++++++++++++++++++-
> arch/powerpc/boot/dts/kmcoge4.dts | 40 ++
> arch/powerpc/boot/dts/oca4080.dts | 40 ++
> arch/powerpc/boot/dts/p1023rdb.dts | 43 ++-
> arch/powerpc/boot/dts/p2041rdb.dts | 42 +-
> arch/powerpc/boot/dts/p3041ds.dts | 42 +-
> arch/powerpc/boot/dts/p4080ds.dts | 42 +-
> arch/powerpc/boot/dts/p5020ds.dts | 42 +-
> arch/powerpc/boot/dts/p5040ds.dts | 42 +-
> arch/powerpc/boot/dts/t104xqds.dtsi | 42 +-
> arch/powerpc/boot/dts/t104xrdb.dtsi | 40 ++
> arch/powerpc/boot/dts/t208xqds.dtsi | 42 +-
> arch/powerpc/boot/dts/t208xrdb.dtsi | 40 ++
> arch/powerpc/boot/dts/t4240qds.dts | 42 +-
> arch/powerpc/boot/dts/t4240rdb.dts | 40 ++
> 30 files changed, 1930 insertions(+), 27 deletions(-)
>
> diff --git a/arch/powerpc/boot/dts/b4qds.dtsi b/arch/powerpc/boot/dts/b4qds.dtsi
> index 6188583..48c3fb4 100644
> --- a/arch/powerpc/boot/dts/b4qds.dtsi
> +++ b/arch/powerpc/boot/dts/b4qds.dtsi
> @@ -1,7 +1,7 @@
> /*
> * B4420DS Device Tree Source
> *
> - * Copyright 2012 Freescale Semiconductor, Inc.
> + * Copyright 2012 - 2014 Freescale Semiconductor, Inc.
> *
> * Redistribution and use in source and binary forms, with or without
> * modification, are permitted provided that the following conditions are met:
> @@ -38,6 +38,7 @@
> #address-cells = <2>;
> #size-cells = <2>;
> interrupt-parent = <&mpic>;
> + reserved-ranges;
I don't see reserved-ranges documented anywhere, and from the code in
arch/powerpc I don't see how it has any effect when empty.
> + reserved-memory {
> + #address-cells = <2>;
> + #size-cells = <2>;
> + ranges;
> +
> + bman_fbpr: bman-fbpr {
> + compatible = "fsl,bman-fbpr";
> + alloc-ranges = <0 0 0xffff 0xffffffff>;
> + size = <0 0x1000000>;
> + alignment = <0 0x1000000>;
> + no-map;
> + reusable;
> + };
> + qman_fqd: qman-fqd {
> + compatible = "fsl,qman-fqd";
> + alloc-ranges = <0 0 0xffff 0xffffffff>;
> + size = <0 0x400000>;
> + alignment = <0 0x400000>;
> + no-map;
> + reusable;
> + };
> + qman_pfdr: qman-pfdr {
> + compatible = "fsl,qman-pfdr";
> + alloc-ranges = <0 0 0xffff 0xffffffff>;
> + size = <0 0x2000000>;
> + alignment = <0 0x2000000>;
> + no-map;
> + reusable;
> + };
> + };
no-map and reusable don't make sense together. How can the OS reuse the
memory if it can't map it?
no-map is burdensome (and I believe not yet implemented) on mpc85xx,
where we want to use huge TLB entries to cover all of (low) memory. Is
it really needed?
What do we gain from specifying reusable here? How is it actually
supposed to work?
> diff --git a/arch/powerpc/boot/dts/fsl/b4420si-post.dtsi b/arch/powerpc/boot/dts/fsl/b4420si-post.dtsi
> index 86161ae..0f56263 100644
> --- a/arch/powerpc/boot/dts/fsl/b4420si-post.dtsi
> +++ b/arch/powerpc/boot/dts/fsl/b4420si-post.dtsi
> @@ -1,7 +1,7 @@
> /*
> * B4420 Silicon/SoC Device Tree Source (post include)
> *
> - * Copyright 2012 Freescale Semiconductor, Inc.
> + * Copyright 2012 - 2014 Freescale Semiconductor, Inc.
> *
> * Redistribution and use in source and binary forms, with or without
> * modification, are permitted provided that the following conditions are met:
> diff --git a/arch/powerpc/boot/dts/fsl/b4420si-pre.dtsi b/arch/powerpc/boot/dts/fsl/b4420si-pre.dtsi
> index 338af7e..f392949 100644
> --- a/arch/powerpc/boot/dts/fsl/b4420si-pre.dtsi
> +++ b/arch/powerpc/boot/dts/fsl/b4420si-pre.dtsi
> @@ -1,7 +1,7 @@
> /*
> * B4420 Silicon/SoC Device Tree Source (pre include)
> *
> - * Copyright 2012 Freescale Semiconductor, Inc.
> + * Copyright 2012 - 2014 Freescale Semiconductor, Inc.
> *
> * Redistribution and use in source and binary forms, with or without
> * modification, are permitted provided that the following conditions are met:
Why are you updating the copyright year on files you didn't change?
-Scott
next prev parent reply other threads:[~2014-11-13 21:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-13 9:21 [PATCH 2/2] powerpc/mpc85xx: Add DPAA Q/BMan support to device tree(s) Emil Medve
2014-11-13 21:42 ` Scott Wood [this message]
2014-11-17 10:31 ` Emil Medve
2014-11-17 22:13 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415914923.15957.64.camel@freescale.com \
--to=scottwood@freescale.com \
--cc=Chunhe.Lan@Freescale.com \
--cc=Emilian.Medve@Freescale.com \
--cc=Geoff.Thorpe@Freescale.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=poonam.aggrwal@Freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).