From: Scott Wood <scottwood@freescale.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Valentin Longchamp <valentin.longchamp@keymile.com>,
Linux device trees <devicetree@vger.kernel.org>,
"Boschung, Rainer" <Rainer.Boschung@keymile.com>,
"Brunck, Holger" <Holger.Brunck@keymile.com>,
Linux I2C <linux-i2c@vger.kernel.org>,
Linux PowerPC Kernel <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH] i2c-qoriq: modified compatibility for correct prescaler
Date: Mon, 17 Nov 2014 19:28:03 -0600 [thread overview]
Message-ID: <1416274083.15957.96.camel@freescale.com> (raw)
In-Reply-To: <20141114082832.GA2180@katana>
On Fri, 2014-11-14 at 09:28 +0100, Wolfram Sang wrote:
> > >
> > > If we're going to change the device tree I'd rather just add a property
> > > to say what the prescaler is.
> >
> > We would however, leave the boards' device trees that use things like
> > "fsl,mpc8543-i2c" as is and introduce the prescaler for the others requiring it.
> >
> >
> > Now the drawback is that the driver would require a change, to parse this
> > prescaler new prescaler property. Would this be OK from your point of view
> > Wolfram ? If yes, I will send the patches for it.
>
> I don't think it is OK.
Why?
> I'd think it can be deduced from the compatible property.
For almost all existing device trees it cannot be.
If you want something that will work without changing device trees,
you'll need to use SVR to identify the SoC.
-Scott
next prev parent reply other threads:[~2014-11-18 1:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-17 9:27 [PATCH] i2c-qoriq: modified compatibility for correct prescaler Valentin Longchamp
2014-10-28 23:08 ` Scott Wood
2014-10-29 8:59 ` Valentin Longchamp
2014-11-06 21:58 ` Scott Wood
2014-11-13 0:34 ` Wolfram Sang
2014-11-14 7:43 ` Valentin Longchamp
2014-11-14 8:28 ` Wolfram Sang
2014-11-18 1:28 ` Scott Wood [this message]
2014-11-25 18:13 ` Wolfram Sang
2014-11-26 1:41 ` Scott Wood
2014-11-30 4:30 ` Danielle Costantino
2014-12-01 17:23 ` Wolfram Sang
2014-12-11 13:44 ` Valentin Longchamp
2014-12-23 13:23 ` Valentin Longchamp
2014-12-23 13:49 ` Wolfram Sang
2014-12-27 2:43 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1416274083.15957.96.camel@freescale.com \
--to=scottwood@freescale.com \
--cc=Holger.Brunck@keymile.com \
--cc=Rainer.Boschung@keymile.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=valentin.longchamp@keymile.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).