From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (ozlabs.org [103.22.144.67]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4F8CA1A0612 for ; Mon, 1 Dec 2014 11:58:18 +1100 (AEDT) Message-ID: <1417395497.16178.0.camel@concordia> Subject: Re: [PATCH 6/8 v2] crypto: replace memset by memzero_explicit From: Michael Ellerman To: Julia Lawall Date: Mon, 01 Dec 2014 11:58:17 +1100 In-Reply-To: <1417367029-32762-7-git-send-email-Julia.Lawall@lip6.fr> References: <1417367029-32762-1-git-send-email-Julia.Lawall@lip6.fr> <1417367029-32762-7-git-send-email-Julia.Lawall@lip6.fr> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Cc: Herbert Xu , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Paul Mackerras , linux-crypto@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, "David S. Miller" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sun, 2014-11-30 at 18:03 +0100, Julia Lawall wrote: > From: Julia Lawall > > Memset on a local variable may be removed when it is called just before the > variable goes out of scope. Using memzero_explicit defeats this > optimization. A simplified version of the semantic patch that makes this > > Signed-off-by: Julia Lawall > > --- > Daniel Borkmann suggested that these patches could go through Herbert Xu's > cryptodev tree. That's fine by me: Acked-by: Michael Ellerman cheers