From: Michael Ellerman <mpe@ellerman.id.au>
To: Tony Breeds <tony@bakeyournoodle.com>
Cc: linuxppc-dev@ozlabs.org, David.Laight@ACULAB.COM
Subject: Re: [PATCH v2] powerpc: Remove more traces of bootmem
Date: Wed, 03 Dec 2014 10:43:09 +1100 [thread overview]
Message-ID: <1417563789.16722.1.camel@concordia> (raw)
In-Reply-To: <20141120023319.GA71013@thor.bakeyournoodle.com>
On Thu, 2014-11-20 at 13:33 +1100, Tony Breeds wrote:
> On Thu, Nov 20, 2014 at 11:07:38AM +1100, Michael Ellerman wrote:
> > --- a/arch/powerpc/lib/alloc.c
> > +++ b/arch/powerpc/lib/alloc.c
> > @@ -13,9 +13,7 @@ void * __init_refok zalloc_maybe_bootmem(size_t size, gfp_t mask)
> > if (mem_init_done)
> > p = kzalloc(size, mask);
> > else {
> > - p = alloc_bootmem(size);
> > - if (p)
> > - memset(p, 0, size);
> > + p = memblock_virt_alloc(size, 0);
> > }
>
> You knew someone would ask but ...
> Do you want to remove the {} form the else clause so that the style matches the if()
Actually I was going to do a follow-up that just returns directly without p at
all, thanks for the reminder :)
cheers
prev parent reply other threads:[~2014-12-02 23:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-20 0:07 [PATCH v2] powerpc: Remove more traces of bootmem Michael Ellerman
2014-11-20 2:33 ` Tony Breeds
2014-12-02 23:43 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1417563789.16722.1.camel@concordia \
--to=mpe@ellerman.id.au \
--cc=David.Laight@ACULAB.COM \
--cc=linuxppc-dev@ozlabs.org \
--cc=tony@bakeyournoodle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox