From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id CE1781A0CC7 for ; Fri, 5 Dec 2014 07:29:22 +1100 (AEDT) Message-ID: <1417724947.4741.31.camel@kernel.crashing.org> Subject: Re: ppc64 and Documentation/mic/mpssd/mpssd.c issues From: Benjamin Herrenschmidt To: "Yokoyama, Caz" Date: Fri, 05 Dec 2014 07:29:07 +1100 In-Reply-To: <45C67EF7794AF747A87A45C9E1CC1B97926A6AFD@ORSMSX105.amr.corp.intel.com> References: <54806490.6080303@redhat.com> <45C67EF7794AF747A87A45C9E1CC1B97926A6AFD@ORSMSX105.amr.corp.intel.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Cc: "Dixit, Ashutosh" , Daniel Borkmann , "linuxppc-dev@lists.ozlabs.org" , "Dutt, Sudeep" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, 2014-12-04 at 16:48 +0000, Yokoyama, Caz wrote: > Thank you for the report. > Have you tried to compile on x86_64? Which rhel do you use? Rhel6.X? > MIC card is expected to work with x86_64 host, not with ppc64. We have never compiled on ppc host while our primary development platform was rhel6.X. > > Line 92 is the first use of htole16 and MIC_VRING_ENTRIES. Is there any change on them? Then you should make sure your Kconfig/Makefile stanza only compiles it on x86_64 instead of breaking all other architectures... Ben. > Thank you. > -caz, Caz.Yokoyama@intel.com, yokoyama@member.fsf.org > > > -----Original Message----- > From: Daniel Borkmann [mailto:dborkman@redhat.com] > Sent: Thursday, December 04, 2014 5:42 AM > To: Yokoyama, Caz > Cc: benh@kernel.crashing.org; linuxppc-dev@lists.ozlabs.org > Subject: ppc64 and Documentation/mic/mpssd/mpssd.c issues > > Hi Caz, > > I think commit ... > > commit 8d49751580db804a02caf6a5b7cebe2ff26c0d7e > Author: Caz Yokoyama > Date: Thu Sep 5 16:42:39 2013 -0700 > > Sample Implementation of Intel MIC User Space Daemon. > > ... actually triggers a build error on my default config > ppc64 (I'm using net-next tree): > > HOSTCC Documentation/mic/mpssd/mpssd.o > Documentation/mic/mpssd/mpssd.c:93: error: braced-group within expression allowed only inside a function > Documentation/mic/mpssd/mpssd.c:96: error: braced-group within expression allowed only inside a function > Documentation/mic/mpssd/mpssd.c:113: error: braced-group within expression allowed only inside a function > Documentation/mic/mpssd/mpssd.c:116: error: braced-group within expression allowed only inside a function > Documentation/mic/mpssd/mpssd.c:119: error: braced-group within expression allowed only inside a function > Documentation/mic/mpssd/mpssd.c:146: error: braced-group within expression allowed only inside a function > Documentation/mic/mpssd/mpssd.c:149: error: braced-group within expression allowed only inside a function > Documentation/mic/mpssd/mpssd.c:151: error: braced-group within expression allowed only inside a function > Documentation/mic/mpssd/mpssd.c:152: error: braced-group within expression allowed only inside a function > make[3]: *** [Documentation/mic/mpssd/mpssd.o] Error 1 > make[2]: *** [Documentation/mic/mpssd] Error 2 > make[1]: *** [Documentation/mic] Error 2 > make: *** [vmlinux] Error 2 > > gcc --version > gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-11) > > Cheers, > Daniel