From: Scott Wood <scottwood@freescale.com>
To: Vinod Koul <vinod.koul@intel.com>
Cc: Harninder Rai <harninder.rai@freescale.com>,
Naveen Burmi <naveenburmi@freescale.com>,
dmaengine@vger.kernel.org, xuelin.shi@freescale.com,
linuxppc-dev@lists.ozlabs.org, dan.j.williams@intel.com
Subject: Re: [RESEND PATCH v4] dmaengine: Driver support for FSL RaidEngine device.
Date: Fri, 5 Dec 2014 12:33:06 -0600 [thread overview]
Message-ID: <1417804386.334.13.camel@freescale.com> (raw)
In-Reply-To: <20141205162823.GN3411@intel.com>
On Fri, 2014-12-05 at 21:58 +0530, Vinod Koul wrote:
> On Fri, Oct 17, 2014 at 03:28:20PM +0800, xuelin.shi@freescale.com wrote:
> > +/*
> > + * drivers/dma/fsl_raid.c
> > + *
> > + * Freescale RAID Engine device driver
> > + *
> > + * Author:
> > + * Harninder Rai <harninder.rai@freescale.com>
> > + * Naveen Burmi <naveenburmi@freescale.com>
> > + *
> > + * Rewrite:
> > + * Xuelin Shi <xuelin.shi@freescale.com>
> > + *
> > + * Copyright (c) 2010-2014 Freescale Semiconductor, Inc.
> > + *
> > + * Redistribution and use in source and binary forms, with or without
> > + * modification, are permitted provided that the following conditions are met:
> > + * * Redistributions of source code must retain the above copyright
> > + * notice, this list of conditions and the following disclaimer.
> > + * * Redistributions in binary form must reproduce the above copyright
> > + * notice, this list of conditions and the following disclaimer in the
> > + * documentation and/or other materials provided with the distribution.
> > + * * Neither the name of Freescale Semiconductor nor the
> > + * names of its contributors may be used to endorse or promote products
> > + * derived from this software without specific prior written permission.
> hmmm, this doesnt sound right. BSD header in kernel code
> I am not a lawyer but for kernel this doesn't sound right.
There's plenty of dual-licensed code in the kernel (try greping for
"Dual BSD" or "in source and binary"). It's fine if the code isn't
derived from other code which is GPL-only or otherwise incompatibly
licensed. Even if portions are considered derivative it ought to be
possible to specify expanded permissions on the portions which aren't
derivative.
This isn't even the first dual-licensed dmaengine driver; see
drivers/dma/ioat/dma_v3.c. There's also drivers/dma/ioat/pci.c which
claims MODULE_LICENSE("Dual BSD/GPL") but has a GPL-only comment header.
> Why cant this be only GPL? Why does this deviate from norm?
Why must it be only GPL? Insisting on that is not the norm in Linux.
Here are Linus's comments on the matter:
http://yarchive.net/comp/linux/dual_license_bsd_gpl.html
-Scott
prev parent reply other threads:[~2014-12-05 18:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-17 7:28 [RESEND PATCH v4] dmaengine: Driver support for FSL RaidEngine device xuelin.shi
2014-12-05 16:28 ` Vinod Koul
2014-12-05 18:33 ` Scott Wood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1417804386.334.13.camel@freescale.com \
--to=scottwood@freescale.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=harninder.rai@freescale.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=naveenburmi@freescale.com \
--cc=vinod.koul@intel.com \
--cc=xuelin.shi@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).