* [PATCH] arch: powerpc: kernel: vio.c: Remove unused function
@ 2014-12-07 22:31 Rickard Strandqvist
2014-12-09 5:29 ` Michael Ellerman
0 siblings, 1 reply; 2+ messages in thread
From: Rickard Strandqvist @ 2014-12-07 22:31 UTC (permalink / raw)
To: Benjamin Herrenschmidt, Paul Mackerras
Cc: devicetree, Li Zhong, Rickard Strandqvist, linux-kernel,
Rob Herring, Daniel Walter, Alistair Popple, Grant Likely,
Andrew Morton, linuxppc-dev
Remove the function cmo_high_show() that is not used anywhere.
This was partially found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
arch/powerpc/kernel/vio.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/arch/powerpc/kernel/vio.c b/arch/powerpc/kernel/vio.c
index 5bfdab9..11657d2 100644
--- a/arch/powerpc/kernel/vio.c
+++ b/arch/powerpc/kernel/vio.c
@@ -1032,11 +1032,6 @@ viobus_cmo_pool_rd_attr(reserve, size);
viobus_cmo_pool_rd_attr(excess, size);
viobus_cmo_pool_rd_attr(excess, free);
-static ssize_t cmo_high_show(struct bus_type *bt, char *buf)
-{
- return sprintf(buf, "%lu\n", vio_cmo.high);
-}
-
static ssize_t cmo_high_store(struct bus_type *bt, const char *buf,
size_t count)
{
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arch: powerpc: kernel: vio.c: Remove unused function
2014-12-07 22:31 [PATCH] arch: powerpc: kernel: vio.c: Remove unused function Rickard Strandqvist
@ 2014-12-09 5:29 ` Michael Ellerman
0 siblings, 0 replies; 2+ messages in thread
From: Michael Ellerman @ 2014-12-09 5:29 UTC (permalink / raw)
To: Rickard Strandqvist
Cc: devicetree, Li Zhong, linux-kernel, Rob Herring, Paul Mackerras,
Daniel Walter, Alistair Popple, Grant Likely, Andrew Morton,
linuxppc-dev
On Sun, 2014-12-07 at 23:31 +0100, Rickard Strandqvist wrote:
> Remove the function cmo_high_show() that is not used anywhere.
>
> This was partially found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
> arch/powerpc/kernel/vio.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/arch/powerpc/kernel/vio.c b/arch/powerpc/kernel/vio.c
> index 5bfdab9..11657d2 100644
> --- a/arch/powerpc/kernel/vio.c
> +++ b/arch/powerpc/kernel/vio.c
> @@ -1032,11 +1032,6 @@ viobus_cmo_pool_rd_attr(reserve, size);
> viobus_cmo_pool_rd_attr(excess, size);
> viobus_cmo_pool_rd_attr(excess, free);
>
> -static ssize_t cmo_high_show(struct bus_type *bt, char *buf)
> -{
> - return sprintf(buf, "%lu\n", vio_cmo.high);
> -}
from ../arch/powerpc/kernel/vio.c:17:
../arch/powerpc/kernel/vio.c:1046:20: error: 'cmo_high_show' undeclared here (not in a function)
static BUS_ATTR_RW(cmo_high);
^
../include/linux/sysfs.h:76:10: note: in definition of macro '__ATTR'
.show = _show, \
^
../include/linux/device.h:53:42: note: in expansion of macro '__ATTR_RW'
struct bus_attribute bus_attr_##_name = __ATTR_RW(_name)
^
../arch/powerpc/kernel/vio.c:1046:8: note: in expansion of macro 'BUS_ATTR_RW'
static BUS_ATTR_RW(cmo_high);
^
cheers
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-12-09 5:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-07 22:31 [PATCH] arch: powerpc: kernel: vio.c: Remove unused function Rickard Strandqvist
2014-12-09 5:29 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).