From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: devicetree@vger.kernel.org, wsa@the-dreams.de,
linuxppc-dev@ozlabs.org, linux-i2c@vger.kernel.org,
Neelesh Gupta <neelegup@linux.vnet.ibm.com>,
Jeremy Kerr <jeremy.kerr@au1.ibm.com>
Subject: Re: [v3] i2c: Driver to expose PowerNV platform i2c busses
Date: Tue, 09 Dec 2014 21:21:32 +1100 [thread overview]
Message-ID: <1418120492.13358.45.camel@kernel.crashing.org> (raw)
In-Reply-To: <20141209094503.100F81400DE@ozlabs.org>
On Tue, 2014-12-09 at 20:45 +1100, Michael Ellerman wrote:
> On Mon, 2014-08-12 at 06:36:16 UTC, Neelesh Gupta wrote:
> > The patch exposes the available i2c busses on the PowerNV platform
> > to the kernel and implements the bus driver to support i2c and
> > smbus commands.
> > The driver uses the platform device infrastructure to probe the busses
> > on the platform and registers them with the i2c driver framework.
>
> > arch/powerpc/include/asm/opal.h | 29 ++
> > arch/powerpc/platforms/powernv/opal-wrappers.S | 1
> > arch/powerpc/platforms/powernv/opal.c | 11 +
>
> This had major conflicts in the above files.
>
> I've fixed it up but please check I did it correctly:
>
> https://github.com/mpe/powerpc-merge/commits/pw/neelesh-i2c
>
> It also doesn't build as a module:
>
> $ grep CONFIG_I2C_OPAL .config
> CONFIG_I2C_OPAL=m
> $ make ...
> ...
> ERROR: "opal_i2c_request" [drivers/i2c/busses/i2c-opal.ko] undefined!
Right that needs to be exported, however for those OPAL wrappers to work
when exported as modules on an LE kernel with ABI v2 (pfiew !) we need
another patch from jk to sort out the external entry to the asm...
Jeremy, is that already in or not yet ?
Cheers,
Ben.
> cheers
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-12-09 10:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-08 6:36 [PATCH v3] i2c: Driver to expose PowerNV platform i2c busses Neelesh Gupta
2014-12-08 20:13 ` Benjamin Herrenschmidt
2014-12-08 20:55 ` Wolfram Sang
2014-12-08 21:43 ` Benjamin Herrenschmidt
2014-12-09 8:54 ` Wolfram Sang
2014-12-09 9:43 ` Benjamin Herrenschmidt
2014-12-09 9:45 ` [v3] " Michael Ellerman
2014-12-09 10:21 ` Benjamin Herrenschmidt [this message]
2014-12-12 5:30 ` Michael Ellerman
2014-12-09 13:18 ` Neelesh Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418120492.13358.45.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=devicetree@vger.kernel.org \
--cc=jeremy.kerr@au1.ibm.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=neelegup@linux.vnet.ibm.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).