From: Michael Ellerman <mpe@ellerman.id.au>
To: Shreyas B Prabhu <shreyas@linux.vnet.ibm.com>
Cc: Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [v4,4/4] powernv: powerpc: Add winkle support for offline cpus
Date: Mon, 15 Dec 2014 11:01:41 +1100 [thread overview]
Message-ID: <1418601701.19970.4.camel@ellerman.id.au> (raw)
In-Reply-To: <548D7A0E.2060107@linux.vnet.ibm.com>
On Sun, 2014-12-14 at 17:22 +0530, Shreyas B Prabhu wrote:
> On Sunday 14 December 2014 03:35 PM, Michael Ellerman wrote:
> >> diff --git a/arch/powerpc/platforms/powernv/subcore.h b/arch/powerpc/platforms/powernv/subcore.h
> >> index 148abc9..604eb40 100644
> >> --- a/arch/powerpc/platforms/powernv/subcore.h
> >> +++ b/arch/powerpc/platforms/powernv/subcore.h
> >> @@ -15,4 +15,5 @@
> >>
> >> #ifndef __ASSEMBLY__
> >> void split_core_secondary_loop(u8 *state);
> >> +extern void update_subcore_sibling_mask(void);
> >> #endif
> >
> > subcore.c isn't built for CONFIG_SMP=n, resulting in:
> >
> > setup.c:(.init.text+0x34b0): undefined reference to `.update_subcore_sibling_mask'
> >
> > I needed to add:
> >
> > +#else
> > +static inline void update_subcore_sibling_mask(void) { };
> > +#endif /* CONFIG_SMP */
> Sorry I missed that.
No worries.
Can you please do a quick test with a SMP=n kernel.
It looks like it should work, but it would be good to test.
cheers
next prev parent reply other threads:[~2014-12-15 0:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-09 18:56 [PATCH v4 0/4] powernv: cpuidle: Redesign idle states management Shreyas B. Prabhu
2014-12-09 18:56 ` [PATCH v4 1/4] powerpc: powernv: Switch off MMU before entering nap/sleep/rvwinkle mode Shreyas B. Prabhu
2014-12-14 10:05 ` [v4, " Michael Ellerman
2014-12-09 18:56 ` [PATCH v4 2/4] powerpc/powernv: Enable Offline CPUs to enter deep idle states Shreyas B. Prabhu
2014-12-09 18:56 ` [PATCH v4 3/4] powernv: cpuidle: Redesign idle states management Shreyas B. Prabhu
2014-12-09 18:56 ` [PATCH v4 4/4] powernv: powerpc: Add winkle support for offline cpus Shreyas B. Prabhu
2014-12-14 10:05 ` [v4,4/4] " Michael Ellerman
2014-12-14 11:52 ` Shreyas B Prabhu
2014-12-15 0:01 ` Michael Ellerman [this message]
2014-12-15 7:03 ` Shreyas B Prabhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418601701.19970.4.camel@ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=shreyas@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).