From: Scott Wood <scottwood@freescale.com>
To: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: linux-kernel@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/8xx: reduce pressure on TLB due to context switches
Date: Tue, 6 Jan 2015 20:52:46 -0600 [thread overview]
Message-ID: <1420599166.4961.47.camel@freescale.com> (raw)
In-Reply-To: <20150105151453.E32BD1A4CF3@localhost.localdomain>
On Mon, 2015-01-05 at 16:14 +0100, Christophe Leroy wrote:
> + }
> + __clear_bit(id, stale_map[cpu]);
> +
> + }
Whitespace
> +
> + /* Flush the TLB for all contexts */
> + _tlbil_all();
Can you put a comment in here pointing out that for this to work on SMP,
it needs to be a global invalidation, or at least some indication on
this function that it's not SMP-safe? I realize there's no SMP 8xx, and
this is only called in place of steal_context_up(), but in case others
think of reusing this elsewhere[1]...
-Scott
[1] It might be helpful on e500 derivatives in virtualized environments
where invalidate-by-PID is expensive, depending on how often stealing
happens there.
next prev parent reply other threads:[~2015-01-07 2:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-05 15:14 [PATCH] powerpc/8xx: reduce pressure on TLB due to context switches Christophe Leroy
2015-01-07 2:52 ` Scott Wood [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-01-05 14:25 Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1420599166.4961.47.camel@freescale.com \
--to=scottwood@freescale.com \
--cc=christophe.leroy@c-s.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).