* [PATCH] [v3] power/fsl: add MDIO dt binding for FMan
@ 2014-12-23 7:57 shh.xie
2015-01-05 11:21 ` Shaohui Xie
0 siblings, 1 reply; 9+ messages in thread
From: shh.xie @ 2014-12-23 7:57 UTC (permalink / raw)
To: linuxppc-dev, devicetree, scottwood; +Cc: Shaohui Xie, Emilian.Medve
From: Shaohui Xie <Shaohui.Xie@freescale.com>
This binding is for FMan MDIO, it covers FMan v2 & FMan v3.
Signed-off-by: Shaohui Xie <Shaohui.Xie@freescale.com>
---
changes in v3:
rephrase the 'Definition' of property 'bus-frequency', don't include the
property in example.
changes in v2:
addressed comments from Scott in V1.
.../devicetree/bindings/powerpc/fsl/fman.txt | 69 ++++++++++++++++++++++
1 file changed, 69 insertions(+)
diff --git a/Documentation/devicetree/bindings/powerpc/fsl/fman.txt b/Documentation/devicetree/bindings/powerpc/fsl/fman.txt
index edeea16..737aa4c 100644
--- a/Documentation/devicetree/bindings/powerpc/fsl/fman.txt
+++ b/Documentation/devicetree/bindings/powerpc/fsl/fman.txt
@@ -7,6 +7,7 @@ CONTENTS
- FMan MURAM Node
- FMan dTSEC/XGEC/mEMAC Node
- FMan IEEE 1588 Node
+ - FMan MDIO Node
- Example
=============================================================================
@@ -357,6 +358,69 @@ ptp-timer@fe000 {
};
=============================================================================
+FMan MDIO Node
+
+DESCRIPTION
+
+The MDIO is a bus to which the PHY devices are connected.
+
+PROPERTIES
+
+- compatible
+ Usage: required
+ Value type: <stringlist>
+ Definition: A standard property.
+ Must include "fsl,fman-mdio" for 1 Gb/s MDIO from FMan v2.
+ Must include "fsl,fman-xmdio" for 10 Gb/s MDIO from FMan v2.
+ Must include "fsl,fman-memac-mdio" for 1/10 Gb/s MDIO from
+ FMan v3.
+
+- reg
+ Usage: required
+ Value type: <prop-encoded-array>
+ Definition: A standard property.
+
+- bus-frequency
+ Usage: optional
+ Value type: <u32>
+ Definition: Specifies the external MDIO bus clock speed to
+ be used, if different from the standard 2.5 MHz.
+ This may be due to the standard speed being unsupported (e.g.
+ due to a hardware problem), or to advertise that all relevant
+ components in the system support a faster speed.
+
+- interrupts
+ Usage: optional
+ Value type: <prop-encoded-array>
+ Definition: Event interrupt of external MDIO controller.
+ 1 Gb/s MDIO and 10 Gb/s MDIO has one interrupt respectively.
+
+- fsl,fman-internal-mdio
+ Usage: required for internal MDIO
+ Value type: boolean
+ Definition: Fman has internal MDIO for internal PCS(Physical
+ Coding Sublayer) PHYs and external MDIO for external PHYs.
+ The settings and programming routines for internal/external
+ MDIO are different. Must be included for internal MDIO.
+
+EXAMPLE
+
+Example for FMan v2 external MDIO:
+
+mdio@f1000 {
+ compatible = "fsl,fman-xmdio";
+ reg = <0xf1000 0x1000>;
+};
+
+Example for FMan v3 internal MDIO:
+
+mdio@f1000 {
+ compatible = "fsl,fman-memac-mdio";
+ reg = <0xf1000 0x1000>;
+ fsl,fman-internal-mdio;
+};
+
+=============================================================================
Example
fman@400000 {
@@ -531,4 +595,9 @@ fman@400000 {
compatible = "fsl,fman-ptp-timer";
reg = <0xfe000 0x1000>;
};
+
+ mdio@f1000 {
+ compatible = "fsl,fman-xmdio";
+ reg = <0xf1000 0x1000>;
+ };
};
--
1.8.4.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* RE: [PATCH] [v3] power/fsl: add MDIO dt binding for FMan
2014-12-23 7:57 [PATCH] [v3] power/fsl: add MDIO dt binding for FMan shh.xie
@ 2015-01-05 11:21 ` Shaohui Xie
2015-01-07 0:28 ` Scott Wood
0 siblings, 1 reply; 9+ messages in thread
From: Shaohui Xie @ 2015-01-05 11:21 UTC (permalink / raw)
To: linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org,
Scott Wood
Cc: Emilian Medve
Hello Scott,
Is this v3 OK?
Best Regards,=20
Shaohui Xie
> -----Original Message-----
> From: shh.xie@gmail.com [mailto:shh.xie@gmail.com]
> Sent: Tuesday, December 23, 2014 3:58 PM
> To: linuxppc-dev@lists.ozlabs.org; devicetree@vger.kernel.org; Wood Scott=
-B07421
> Cc: Medve Emilian-EMMEDVE1; Xie Shaohui-B21989
> Subject: [PATCH] [v3] power/fsl: add MDIO dt binding for FMan
>=20
> From: Shaohui Xie <Shaohui.Xie@freescale.com>
>=20
> This binding is for FMan MDIO, it covers FMan v2 & FMan v3.
>=20
> Signed-off-by: Shaohui Xie <Shaohui.Xie@freescale.com>
> ---
> changes in v3:
> rephrase the 'Definition' of property 'bus-frequency', don't include the
> property in example.
>=20
> changes in v2:
> addressed comments from Scott in V1.
>=20
> .../devicetree/bindings/powerpc/fsl/fman.txt | 69 ++++++++++++++++=
++++++
> 1 file changed, 69 insertions(+)
>=20
> diff --git a/Documentation/devicetree/bindings/powerpc/fsl/fman.txt
> b/Documentation/devicetree/bindings/powerpc/fsl/fman.txt
> index edeea16..737aa4c 100644
> --- a/Documentation/devicetree/bindings/powerpc/fsl/fman.txt
> +++ b/Documentation/devicetree/bindings/powerpc/fsl/fman.txt
> @@ -7,6 +7,7 @@ CONTENTS
> - FMan MURAM Node
> - FMan dTSEC/XGEC/mEMAC Node
> - FMan IEEE 1588 Node
> + - FMan MDIO Node
> - Example
>=20
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
> @@ -357,6 +358,69 @@ ptp-timer@fe000 {
> };
>=20
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
> +FMan MDIO Node
> +
> +DESCRIPTION
> +
> +The MDIO is a bus to which the PHY devices are connected.
> +
> +PROPERTIES
> +
> +- compatible
> + Usage: required
> + Value type: <stringlist>
> + Definition: A standard property.
> + Must include "fsl,fman-mdio" for 1 Gb/s MDIO from FMan v2.
> + Must include "fsl,fman-xmdio" for 10 Gb/s MDIO from FMan v2.
> + Must include "fsl,fman-memac-mdio" for 1/10 Gb/s MDIO from
> + FMan v3.
> +
> +- reg
> + Usage: required
> + Value type: <prop-encoded-array>
> + Definition: A standard property.
> +
> +- bus-frequency
> + Usage: optional
> + Value type: <u32>
> + Definition: Specifies the external MDIO bus clock speed to
> + be used, if different from the standard 2.5 MHz.
> + This may be due to the standard speed being unsupported (e.g.
> + due to a hardware problem), or to advertise that all relevant
> + components in the system support a faster speed.
> +
> +- interrupts
> + Usage: optional
> + Value type: <prop-encoded-array>
> + Definition: Event interrupt of external MDIO controller.
> + 1 Gb/s MDIO and 10 Gb/s MDIO has one interrupt respectively.
> +
> +- fsl,fman-internal-mdio
> + Usage: required for internal MDIO
> + Value type: boolean
> + Definition: Fman has internal MDIO for internal PCS(Physical
> + Coding Sublayer) PHYs and external MDIO for external PHYs.
> + The settings and programming routines for internal/external
> + MDIO are different. Must be included for internal MDIO.
> +
> +EXAMPLE
> +
> +Example for FMan v2 external MDIO:
> +
> +mdio@f1000 {
> + compatible =3D "fsl,fman-xmdio";
> + reg =3D <0xf1000 0x1000>;
> +};
> +
> +Example for FMan v3 internal MDIO:
> +
> +mdio@f1000 {
> + compatible =3D "fsl,fman-memac-mdio";
> + reg =3D <0xf1000 0x1000>;
> + fsl,fman-internal-mdio;
> +};
> +
> +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> +=3D=3D=3D=3D=3D=3D
> Example
>=20
> fman@400000 {
> @@ -531,4 +595,9 @@ fman@400000 {
> compatible =3D "fsl,fman-ptp-timer";
> reg =3D <0xfe000 0x1000>;
> };
> +
> + mdio@f1000 {
> + compatible =3D "fsl,fman-xmdio";
> + reg =3D <0xf1000 0x1000>;
> + };
> };
> --
> 1.8.4.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] [v3] power/fsl: add MDIO dt binding for FMan
2015-01-05 11:21 ` Shaohui Xie
@ 2015-01-07 0:28 ` Scott Wood
2015-01-07 5:29 ` Shaohui Xie
0 siblings, 1 reply; 9+ messages in thread
From: Scott Wood @ 2015-01-07 0:28 UTC (permalink / raw)
To: Xie Shaohui-B21989
Cc: devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
Medve Emilian-EMMEDVE1
On Mon, 2015-01-05 at 05:21 -0600, Xie Shaohui-B21989 wrote:
> Hello Scott,
>
> Is this v3 OK?
>
> Best Regards,
> Shaohui Xie
> > -----Original Message-----
> > From: shh.xie@gmail.com [mailto:shh.xie@gmail.com]
> > Sent: Tuesday, December 23, 2014 3:58 PM
> > To: linuxppc-dev@lists.ozlabs.org; devicetree@vger.kernel.org; Wood Scott-B07421
> > Cc: Medve Emilian-EMMEDVE1; Xie Shaohui-B21989
> > Subject: [PATCH] [v3] power/fsl: add MDIO dt binding for FMan
> >
> > From: Shaohui Xie <Shaohui.Xie@freescale.com>
> >
> > This binding is for FMan MDIO, it covers FMan v2 & FMan v3.
> >
> > Signed-off-by: Shaohui Xie <Shaohui.Xie@freescale.com>
> > ---
> > changes in v3:
> > rephrase the 'Definition' of property 'bus-frequency', don't include the
> > property in example.
> >
> > changes in v2:
> > addressed comments from Scott in V1.
> >
> > .../devicetree/bindings/powerpc/fsl/fman.txt | 69 ++++++++++++++++++++++
> > 1 file changed, 69 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/powerpc/fsl/fman.txt
> > b/Documentation/devicetree/bindings/powerpc/fsl/fman.txt
> > index edeea16..737aa4c 100644
> > --- a/Documentation/devicetree/bindings/powerpc/fsl/fman.txt
> > +++ b/Documentation/devicetree/bindings/powerpc/fsl/fman.txt
> > @@ -7,6 +7,7 @@ CONTENTS
> > - FMan MURAM Node
> > - FMan dTSEC/XGEC/mEMAC Node
> > - FMan IEEE 1588 Node
> > + - FMan MDIO Node
> > - Example
> >
> > =============================================================================
> > @@ -357,6 +358,69 @@ ptp-timer@fe000 {
> > };
> >
> > =============================================================================
> > +FMan MDIO Node
> > +
> > +DESCRIPTION
> > +
> > +The MDIO is a bus to which the PHY devices are connected.
> > +
> > +PROPERTIES
> > +
> > +- compatible
> > + Usage: required
> > + Value type: <stringlist>
> > + Definition: A standard property.
> > + Must include "fsl,fman-mdio" for 1 Gb/s MDIO from FMan v2.
> > + Must include "fsl,fman-xmdio" for 10 Gb/s MDIO from FMan v2.
> > + Must include "fsl,fman-memac-mdio" for 1/10 Gb/s MDIO from
> > + FMan v3.
> > +
> > +- reg
> > + Usage: required
> > + Value type: <prop-encoded-array>
> > + Definition: A standard property.
> > +
> > +- bus-frequency
> > + Usage: optional
> > + Value type: <u32>
> > + Definition: Specifies the external MDIO bus clock speed to
> > + be used, if different from the standard 2.5 MHz.
> > + This may be due to the standard speed being unsupported (e.g.
> > + due to a hardware problem), or to advertise that all relevant
> > + components in the system support a faster speed.
> > +
> > +- interrupts
> > + Usage: optional
> > + Value type: <prop-encoded-array>
> > + Definition: Event interrupt of external MDIO controller.
> > + 1 Gb/s MDIO and 10 Gb/s MDIO has one interrupt respectively.
I'm confused by "respectively" here. Does fsl,fman-memac-mdio have two
interrupts (one for 1 Gb/s and one for 10 Gb/s)? If there's only (at
most) one interrupt per MDIO controller then just delete this line.
What interrupt is used for internal MDIO? Does "optional" mean it's
used if and only if external MDIO is used, or is it optional even with
external MDIO? I see it's not present in the example -- do we not have
a real example that has the interrupt?
-Scott
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH] [v3] power/fsl: add MDIO dt binding for FMan
2015-01-07 0:28 ` Scott Wood
@ 2015-01-07 5:29 ` Shaohui Xie
2015-01-07 18:05 ` Scott Wood
0 siblings, 1 reply; 9+ messages in thread
From: Shaohui Xie @ 2015-01-07 5:29 UTC (permalink / raw)
To: Scott Wood
Cc: devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
Emilian Medve
PiA+ID4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gPiA+IEZyb206IHNoaC54aWVAZ21h
aWwuY29tIFttYWlsdG86c2hoLnhpZUBnbWFpbC5jb21dDQo+ID4gPiBTZW50OiBUdWVzZGF5LCBE
ZWNlbWJlciAyMywgMjAxNCAzOjU4IFBNDQo+ID4gPiBUbzogbGludXhwcGMtZGV2QGxpc3RzLm96
bGFicy5vcmc7IGRldmljZXRyZWVAdmdlci5rZXJuZWwub3JnOyBXb29kDQo+ID4gPiBTY290dC1C
MDc0MjENCj4gPiA+IENjOiBNZWR2ZSBFbWlsaWFuLUVNTUVEVkUxOyBYaWUgU2hhb2h1aS1CMjE5
ODkNCj4gPiA+IFN1YmplY3Q6IFtQQVRDSF0gW3YzXSBwb3dlci9mc2w6IGFkZCBNRElPIGR0IGJp
bmRpbmcgZm9yIEZNYW4NCj4gPiA+DQo+ID4gPiBGcm9tOiBTaGFvaHVpIFhpZSA8U2hhb2h1aS5Y
aWVAZnJlZXNjYWxlLmNvbT4NCj4gPiA+DQo+ID4gPiBUaGlzIGJpbmRpbmcgaXMgZm9yIEZNYW4g
TURJTywgaXQgY292ZXJzIEZNYW4gdjIgJiBGTWFuIHYzLg0KPiA+ID4NCj4gPiA+IFNpZ25lZC1v
ZmYtYnk6IFNoYW9odWkgWGllIDxTaGFvaHVpLlhpZUBmcmVlc2NhbGUuY29tPg0KPiA+ID4gLS0t
DQo+ID4gPiBjaGFuZ2VzIGluIHYzOg0KPiA+ID4gcmVwaHJhc2UgdGhlICdEZWZpbml0aW9uJyBv
ZiBwcm9wZXJ0eSAnYnVzLWZyZXF1ZW5jeScsIGRvbid0IGluY2x1ZGUNCj4gPiA+IHRoZSBwcm9w
ZXJ0eSBpbiBleGFtcGxlLg0KPiA+ID4NCj4gPiA+IGNoYW5nZXMgaW4gdjI6DQo+ID4gPiBhZGRy
ZXNzZWQgY29tbWVudHMgZnJvbSBTY290dCBpbiBWMS4NCj4gPiA+DQo+ID4gPiAgLi4uL2Rldmlj
ZXRyZWUvYmluZGluZ3MvcG93ZXJwYy9mc2wvZm1hbi50eHQgICAgICAgfCA2OQ0KPiArKysrKysr
KysrKysrKysrKysrKysrDQo+ID4gPiAgMSBmaWxlIGNoYW5nZWQsIDY5IGluc2VydGlvbnMoKykN
Cj4gPiA+DQo+ID4gPiBkaWZmIC0tZ2l0IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRp
bmdzL3Bvd2VycGMvZnNsL2ZtYW4udHh0DQo+ID4gPiBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJl
ZS9iaW5kaW5ncy9wb3dlcnBjL2ZzbC9mbWFuLnR4dA0KPiA+ID4gaW5kZXggZWRlZWExNi4uNzM3
YWE0YyAxMDA2NDQNCj4gPiA+IC0tLSBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5n
cy9wb3dlcnBjL2ZzbC9mbWFuLnR4dA0KPiA+ID4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0
cmVlL2JpbmRpbmdzL3Bvd2VycGMvZnNsL2ZtYW4udHh0DQo+ID4gPiBAQCAtNyw2ICs3LDcgQEAg
Q09OVEVOVFMNCj4gPiA+ICAgIC0gRk1hbiBNVVJBTSBOb2RlDQo+ID4gPiAgICAtIEZNYW4gZFRT
RUMvWEdFQy9tRU1BQyBOb2RlDQo+ID4gPiAgICAtIEZNYW4gSUVFRSAxNTg4IE5vZGUNCj4gPiA+
ICsgIC0gRk1hbiBNRElPIE5vZGUNCj4gPiA+ICAgIC0gRXhhbXBsZQ0KPiA+ID4NCj4gPiA+DQo+
ID4gPiA9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PQ0KPiA+ID4gPT09PT09PT09IEBAIC0zNTcsNiArMzU4LDY5IEBAIHB0
cC10aW1lckBmZTAwMCB7ICB9Ow0KPiA+ID4NCj4gPiA+DQo+ID4gPiA9PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KPiA+
ID4gPT09PT09PT09DQo+ID4gPiArRk1hbiBNRElPIE5vZGUNCj4gPiA+ICsNCj4gPiA+ICtERVND
UklQVElPTg0KPiA+ID4gKw0KPiA+ID4gK1RoZSBNRElPIGlzIGEgYnVzIHRvIHdoaWNoIHRoZSBQ
SFkgZGV2aWNlcyBhcmUgY29ubmVjdGVkLg0KPiA+ID4gKw0KPiA+ID4gK1BST1BFUlRJRVMNCj4g
PiA+ICsNCj4gPiA+ICstIGNvbXBhdGlibGUNCj4gPiA+ICsJCVVzYWdlOiByZXF1aXJlZA0KPiA+
ID4gKwkJVmFsdWUgdHlwZTogPHN0cmluZ2xpc3Q+DQo+ID4gPiArCQlEZWZpbml0aW9uOiBBIHN0
YW5kYXJkIHByb3BlcnR5Lg0KPiA+ID4gKwkJTXVzdCBpbmNsdWRlICJmc2wsZm1hbi1tZGlvIiBm
b3IgMSBHYi9zIE1ESU8gZnJvbSBGTWFuIHYyLg0KPiA+ID4gKwkJTXVzdCBpbmNsdWRlICJmc2ws
Zm1hbi14bWRpbyIgZm9yIDEwIEdiL3MgTURJTyBmcm9tIEZNYW4gdjIuDQo+ID4gPiArCQlNdXN0
IGluY2x1ZGUgImZzbCxmbWFuLW1lbWFjLW1kaW8iIGZvciAxLzEwIEdiL3MgTURJTyBmcm9tDQo+
ID4gPiArCQlGTWFuIHYzLg0KPiA+ID4gKw0KPiA+ID4gKy0gcmVnDQo+ID4gPiArCQlVc2FnZTog
cmVxdWlyZWQNCj4gPiA+ICsJCVZhbHVlIHR5cGU6IDxwcm9wLWVuY29kZWQtYXJyYXk+DQo+ID4g
PiArCQlEZWZpbml0aW9uOiBBIHN0YW5kYXJkIHByb3BlcnR5Lg0KPiA+ID4gKw0KPiA+ID4gKy0g
YnVzLWZyZXF1ZW5jeQ0KPiA+ID4gKwkJVXNhZ2U6IG9wdGlvbmFsDQo+ID4gPiArCQlWYWx1ZSB0
eXBlOiA8dTMyPg0KPiA+ID4gKwkJRGVmaW5pdGlvbjogU3BlY2lmaWVzIHRoZSBleHRlcm5hbCBN
RElPIGJ1cyBjbG9jayBzcGVlZCB0bw0KPiA+ID4gKwkJYmUgdXNlZCwgaWYgZGlmZmVyZW50IGZy
b20gdGhlIHN0YW5kYXJkIDIuNSBNSHouDQo+ID4gPiArCQlUaGlzIG1heSBiZSBkdWUgdG8gdGhl
IHN0YW5kYXJkIHNwZWVkIGJlaW5nIHVuc3VwcG9ydGVkIChlLmcuDQo+ID4gPiArCQlkdWUgdG8g
YSBoYXJkd2FyZSBwcm9ibGVtKSwgb3IgdG8gYWR2ZXJ0aXNlIHRoYXQgYWxsIHJlbGV2YW50DQo+
ID4gPiArCQljb21wb25lbnRzIGluIHRoZSBzeXN0ZW0gc3VwcG9ydCBhIGZhc3RlciBzcGVlZC4N
Cj4gPiA+ICsNCj4gPiA+ICstIGludGVycnVwdHMNCj4gPiA+ICsJCVVzYWdlOiBvcHRpb25hbA0K
PiA+ID4gKwkJVmFsdWUgdHlwZTogPHByb3AtZW5jb2RlZC1hcnJheT4NCj4gPiA+ICsJCURlZmlu
aXRpb246IEV2ZW50IGludGVycnVwdCBvZiBleHRlcm5hbCBNRElPIGNvbnRyb2xsZXIuDQo+ID4g
PiArCQkxIEdiL3MgTURJTyBhbmQgMTAgR2IvcyBNRElPIGhhcyBvbmUgaW50ZXJydXB0IHJlc3Bl
Y3RpdmVseS4NCj4gDQo+IEknbSBjb25mdXNlZCBieSAicmVzcGVjdGl2ZWx5IiBoZXJlLiAgRG9l
cyBmc2wsZm1hbi1tZW1hYy1tZGlvIGhhdmUgdHdvDQo+IGludGVycnVwdHMgKG9uZSBmb3IgMSBH
Yi9zIGFuZCBvbmUgZm9yIDEwIEdiL3MpPw0KW1MuSF0gV2UgdXNlIHR3byBNRElPIGNvbnRyb2xs
ZXJzIGZvciBleHRlcm5hbCBQSFkgbWFuYWdlbWVudC4gT25lIGZvciAxIEdiL3MsDQpPbmUgZm9y
IDEwIEdiL3MsIGFuZCB0d28gTURJTyBpbnRlcnJ1cHRzIGNvbm5lY3RlZCB0byBNUElDLg0KDQog
IElmIHRoZXJlJ3Mgb25seSAoYXQNCj4gbW9zdCkgb25lIGludGVycnVwdCBwZXIgTURJTyBjb250
cm9sbGVyIHRoZW4ganVzdCBkZWxldGUgdGhpcyBsaW5lLg0KPiANCj4gV2hhdCBpbnRlcnJ1cHQg
aXMgdXNlZCBmb3IgaW50ZXJuYWwgTURJTz8NCltTLkhdIGludGVybmFsIE1ESU8gaGFzIG5vIGlu
dGVycnVwdC4NCg0KICBEb2VzICJvcHRpb25hbCIgbWVhbiBpdCdzIHVzZWQgaWYgYW5kDQo+IG9u
bHkgaWYgZXh0ZXJuYWwgTURJTyBpcyB1c2VkLCBvciBpcyBpdCBvcHRpb25hbCBldmVuIHdpdGgg
ZXh0ZXJuYWwgTURJTz8gIEkgc2VlDQo+IGl0J3Mgbm90IHByZXNlbnQgaW4gdGhlIGV4YW1wbGUg
LS0gZG8gd2Ugbm90IGhhdmUgYSByZWFsIGV4YW1wbGUgdGhhdCBoYXMgdGhlDQo+IGludGVycnVw
dD8NCltTLkhdICJvcHRpb25hbCIgbWVhbnMgaXQncyBhdmFpbGFibGUgb24gaGFyZHdhcmUsIGJ1
dCBNRElPIGRyaXZlciBkb2VzIG5vdCB1c2UgaW50ZXJydXB0LiANClNvIHdlIGRvbid0IGhhdmUg
YSByZWFsIGV4YW1wbGUuDQoNClRoYW5rcyENClNoYW9odWkNCg==
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] [v3] power/fsl: add MDIO dt binding for FMan
2015-01-07 5:29 ` Shaohui Xie
@ 2015-01-07 18:05 ` Scott Wood
2015-01-07 19:44 ` Emil Medve
0 siblings, 1 reply; 9+ messages in thread
From: Scott Wood @ 2015-01-07 18:05 UTC (permalink / raw)
To: Xie Shaohui-B21989
Cc: devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
Medve Emilian-EMMEDVE1
On Tue, 2015-01-06 at 23:29 -0600, Xie Shaohui-B21989 wrote:
> > > > +- interrupts
> > > > + Usage: optional
> > > > + Value type: <prop-encoded-array>
> > > > + Definition: Event interrupt of external MDIO controller.
> > > > + 1 Gb/s MDIO and 10 Gb/s MDIO has one interrupt respectively.
> >
> > I'm confused by "respectively" here. Does fsl,fman-memac-mdio have two
> > interrupts (one for 1 Gb/s and one for 10 Gb/s)?
> [S.H] We use two MDIO controllers for external PHY management. One for 1 Gb/s,
> One for 10 Gb/s, and two MDIO interrupts connected to MPIC.
If there can be two interrupts you need to make that clear and specify
the order.
Is it possible for one MDIO controller to have an interrupt connected
but not the other, on the same system? How would you represent that in
the device tree? If there are two MDIO controllers why are they in the
same node?
> Does "optional" mean it's used if and
> > only if external MDIO is used, or is it optional even with external MDIO? I see
> > it's not present in the example -- do we not have a real example that has the
> > interrupt?
> [S.H] "optional" means it's available on hardware, but MDIO driver does not use interrupt.
> So we don't have a real example.
<record type="broken">The device tree describes the hardware, not the
driver</record>
-Scott
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] [v3] power/fsl: add MDIO dt binding for FMan
2015-01-07 18:05 ` Scott Wood
@ 2015-01-07 19:44 ` Emil Medve
2015-01-08 1:12 ` Scott Wood
0 siblings, 1 reply; 9+ messages in thread
From: Emil Medve @ 2015-01-07 19:44 UTC (permalink / raw)
To: Scott Wood, Xie Shaohui-B21989
Cc: devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Hello Scott,
On 01/07/2015 12:05 PM, Scott Wood wrote:
> On Tue, 2015-01-06 at 23:29 -0600, Xie Shaohui-B21989 wrote:
>>>>> +- interrupts
>>>>> + Usage: optional
>>>>> + Value type: <prop-encoded-array>
>>>>> + Definition: Event interrupt of external MDIO controller.
>>>>> + 1 Gb/s MDIO and 10 Gb/s MDIO has one interrupt respectively.
>>>
>>> I'm confused by "respectively" here. Does fsl,fman-memac-mdio have two
>>> interrupts (one for 1 Gb/s and one for 10 Gb/s)?
>> [S.H] We use two MDIO controllers for external PHY management. One for 1 Gb/s,
>> One for 10 Gb/s, and two MDIO interrupts connected to MPIC.
>
> If there can be two interrupts you need to make that clear and specify
> the order.
>
> Is it possible for one MDIO controller to have an interrupt connected
> but not the other, on the same system? How would you represent that in
> the device tree? If there are two MDIO controllers why are they in the
> same node?
Historically (FMan v2 and even before/legacy) we've had each MAC include
an MDIO controller, but only one MDIO controller per MAC type/speed (1
Gb/s vs 10 Gb/s) is pinned out and all the same speed PHY(s) are
connected to the respective MDIO controllers. As such the first 1 Gb/s
MAC/MDIO controller is used to manage all the 1 Gb/s PHY(s) and the
first 10 Gb/s MAC/MDIO controller is used to manage all the 10 Gb/s
PHY(s). Each MDIO controller has the ability to generate interrupts but
only pinned out MDIO controllers are hooked up to the MPIC (as such the
talk about two interrupts)
(Each MAC has also integrated a SERDES/TBI/"internal" PHY that is
connected to the "local" MDIO controller)
As you can imagine this creates a number of problems in a partitioning
scenario (and not just, imagine RCWs where the first MAC is not
used/enabled). In order to help a bit (but not quite enough), in FMan
v3, two additional MDIO controllers (one for 1 the Gb/s PHY(s) and one
for 1 the 10 Gb/s PHY(s)) have been integrated that are not associated
with any MAC and these are the pinned out MDIO controllers on such
SoC(s) (chassis v2)
>> Does "optional" mean it's used if and
>>> only if external MDIO is used, or is it optional even with external MDIO? I see
>>> it's not present in the example -- do we not have a real example that has the
>>> interrupt?
>> [S.H] "optional" means it's available on hardware, but MDIO driver does not use interrupt.
>> So we don't have a real example.
>
> <record type="broken">The device tree describes the hardware, not the
> driver</record>
Anyway, only two MDIO nodes (out of 4 to 14) would have an interrupt
property describing exactly one interrupt. What language should we use
to convey this situation
Cheers,
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] [v3] power/fsl: add MDIO dt binding for FMan
2015-01-07 19:44 ` Emil Medve
@ 2015-01-08 1:12 ` Scott Wood
2015-01-08 3:58 ` Shaohui Xie
2015-01-08 9:31 ` Emil Medve
0 siblings, 2 replies; 9+ messages in thread
From: Scott Wood @ 2015-01-08 1:12 UTC (permalink / raw)
To: Emil Medve
Cc: devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
Xie Shaohui-B21989
On Wed, 2015-01-07 at 13:44 -0600, Emil Medve wrote:
> Hello Scott,
>
>
> On 01/07/2015 12:05 PM, Scott Wood wrote:
> > On Tue, 2015-01-06 at 23:29 -0600, Xie Shaohui-B21989 wrote:
> >>>>> +- interrupts
> >>>>> + Usage: optional
> >>>>> + Value type: <prop-encoded-array>
> >>>>> + Definition: Event interrupt of external MDIO controller.
> >>>>> + 1 Gb/s MDIO and 10 Gb/s MDIO has one interrupt respectively.
> >>>
> >>> I'm confused by "respectively" here. Does fsl,fman-memac-mdio have two
> >>> interrupts (one for 1 Gb/s and one for 10 Gb/s)?
> >> [S.H] We use two MDIO controllers for external PHY management. One for 1 Gb/s,
> >> One for 10 Gb/s, and two MDIO interrupts connected to MPIC.
> >
> > If there can be two interrupts you need to make that clear and specify
> > the order.
> >
> > Is it possible for one MDIO controller to have an interrupt connected
> > but not the other, on the same system? How would you represent that in
> > the device tree? If there are two MDIO controllers why are they in the
> > same node?
>
> Historically (FMan v2 and even before/legacy) we've had each MAC include
> an MDIO controller, but only one MDIO controller per MAC type/speed (1
> Gb/s vs 10 Gb/s) is pinned out and all the same speed PHY(s) are
> connected to the respective MDIO controllers. As such the first 1 Gb/s
> MAC/MDIO controller is used to manage all the 1 Gb/s PHY(s) and the
> first 10 Gb/s MAC/MDIO controller is used to manage all the 10 Gb/s
> PHY(s). Each MDIO controller has the ability to generate interrupts but
> only pinned out MDIO controllers are hooked up to the MPIC (as such the
> talk about two interrupts)
>
> (Each MAC has also integrated a SERDES/TBI/"internal" PHY that is
> connected to the "local" MDIO controller)
>
> As you can imagine this creates a number of problems in a partitioning
> scenario (and not just, imagine RCWs where the first MAC is not
> used/enabled). In order to help a bit (but not quite enough), in FMan
> v3, two additional MDIO controllers (one for 1 the Gb/s PHY(s) and one
> for 1 the 10 Gb/s PHY(s)) have been integrated that are not associated
> with any MAC and these are the pinned out MDIO controllers on such
> SoC(s) (chassis v2)
I'm happy to hear that. Is that what is meant by "external" here? I
thought it meant external to the SoC. Is this the term used by hardware
documentation? I'd have called it "independent" or similar.
> >> Does "optional" mean it's used if and
> >>> only if external MDIO is used, or is it optional even with external MDIO? I see
> >>> it's not present in the example -- do we not have a real example that has the
> >>> interrupt?
> >> [S.H] "optional" means it's available on hardware, but MDIO driver does not use interrupt.
> >> So we don't have a real example.
> >
> > <record type="broken">The device tree describes the hardware, not the
> > driver</record>
>
> Anyway, only two MDIO nodes (out of 4 to 14) would have an interrupt
> property describing exactly one interrupt. What language should we use
> to convey this situation
So the answer is that there will not be more than one MDIO controller
per MDIO node, or more than one interrupt per MDIO node? In that case
just get rid of the confusing "respectively" sentence -- and always
describe the interrupt if it exists in hardware.
-Scott
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH] [v3] power/fsl: add MDIO dt binding for FMan
2015-01-08 1:12 ` Scott Wood
@ 2015-01-08 3:58 ` Shaohui Xie
2015-01-08 9:31 ` Emil Medve
1 sibling, 0 replies; 9+ messages in thread
From: Shaohui Xie @ 2015-01-08 3:58 UTC (permalink / raw)
To: Scott Wood, Emilian Medve
Cc: devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBXb29kIFNjb3R0LUIwNzQyMQ0K
PiBTZW50OiBUaHVyc2RheSwgSmFudWFyeSAwOCwgMjAxNSA5OjEzIEFNDQo+IFRvOiBNZWR2ZSBF
bWlsaWFuLUVNTUVEVkUxDQo+IENjOiBYaWUgU2hhb2h1aS1CMjE5ODk7IGxpbnV4cHBjLWRldkBs
aXN0cy5vemxhYnMub3JnOw0KPiBkZXZpY2V0cmVlQHZnZXIua2VybmVsLm9yZw0KPiBTdWJqZWN0
OiBSZTogW1BBVENIXSBbdjNdIHBvd2VyL2ZzbDogYWRkIE1ESU8gZHQgYmluZGluZyBmb3IgRk1h
bg0KPiANCj4gT24gV2VkLCAyMDE1LTAxLTA3IGF0IDEzOjQ0IC0wNjAwLCBFbWlsIE1lZHZlIHdy
b3RlOg0KPiA+IEhlbGxvIFNjb3R0LA0KPiA+DQo+ID4NCj4gPiBPbiAwMS8wNy8yMDE1IDEyOjA1
IFBNLCBTY290dCBXb29kIHdyb3RlOg0KPiA+ID4gT24gVHVlLCAyMDE1LTAxLTA2IGF0IDIzOjI5
IC0wNjAwLCBYaWUgU2hhb2h1aS1CMjE5ODkgd3JvdGU6DQo+ID4gPj4+Pj4gKy0gaW50ZXJydXB0
cw0KPiA+ID4+Pj4+ICsJCVVzYWdlOiBvcHRpb25hbA0KPiA+ID4+Pj4+ICsJCVZhbHVlIHR5cGU6
IDxwcm9wLWVuY29kZWQtYXJyYXk+DQo+ID4gPj4+Pj4gKwkJRGVmaW5pdGlvbjogRXZlbnQgaW50
ZXJydXB0IG9mIGV4dGVybmFsIE1ESU8gY29udHJvbGxlci4NCj4gPiA+Pj4+PiArCQkxIEdiL3Mg
TURJTyBhbmQgMTAgR2IvcyBNRElPIGhhcyBvbmUgaW50ZXJydXB0IHJlc3BlY3RpdmVseS4NCj4g
PiA+Pj4NCj4gPiA+Pj4gSSdtIGNvbmZ1c2VkIGJ5ICJyZXNwZWN0aXZlbHkiIGhlcmUuICBEb2Vz
IGZzbCxmbWFuLW1lbWFjLW1kaW8NCj4gPiA+Pj4gaGF2ZSB0d28gaW50ZXJydXB0cyAob25lIGZv
ciAxIEdiL3MgYW5kIG9uZSBmb3IgMTAgR2Ivcyk/DQo+ID4gPj4gW1MuSF0gV2UgdXNlIHR3byBN
RElPIGNvbnRyb2xsZXJzIGZvciBleHRlcm5hbCBQSFkgbWFuYWdlbWVudC4gT25lDQo+ID4gPj4g
Zm9yIDEgR2IvcywgT25lIGZvciAxMCBHYi9zLCBhbmQgdHdvIE1ESU8gaW50ZXJydXB0cyBjb25u
ZWN0ZWQgdG8gTVBJQy4NCj4gPiA+DQo+ID4gPiBJZiB0aGVyZSBjYW4gYmUgdHdvIGludGVycnVw
dHMgeW91IG5lZWQgdG8gbWFrZSB0aGF0IGNsZWFyIGFuZA0KPiA+ID4gc3BlY2lmeSB0aGUgb3Jk
ZXIuDQo+ID4gPg0KPiA+ID4gSXMgaXQgcG9zc2libGUgZm9yIG9uZSBNRElPIGNvbnRyb2xsZXIg
dG8gaGF2ZSBhbiBpbnRlcnJ1cHQNCj4gPiA+IGNvbm5lY3RlZCBidXQgbm90IHRoZSBvdGhlciwg
b24gdGhlIHNhbWUgc3lzdGVtPyAgSG93IHdvdWxkIHlvdQ0KPiA+ID4gcmVwcmVzZW50IHRoYXQg
aW4gdGhlIGRldmljZSB0cmVlPyAgSWYgdGhlcmUgYXJlIHR3byBNRElPDQo+ID4gPiBjb250cm9s
bGVycyB3aHkgYXJlIHRoZXkgaW4gdGhlIHNhbWUgbm9kZT8NCj4gPg0KPiA+IEhpc3RvcmljYWxs
eSAoRk1hbiB2MiBhbmQgZXZlbiBiZWZvcmUvbGVnYWN5KSB3ZSd2ZSBoYWQgZWFjaCBNQUMNCj4g
PiBpbmNsdWRlIGFuIE1ESU8gY29udHJvbGxlciwgYnV0IG9ubHkgb25lIE1ESU8gY29udHJvbGxl
ciBwZXIgTUFDDQo+ID4gdHlwZS9zcGVlZCAoMSBHYi9zIHZzIDEwIEdiL3MpIGlzIHBpbm5lZCBv
dXQgYW5kIGFsbCB0aGUgc2FtZSBzcGVlZA0KPiA+IFBIWShzKSBhcmUgY29ubmVjdGVkIHRvIHRo
ZSByZXNwZWN0aXZlIE1ESU8gY29udHJvbGxlcnMuIEFzIHN1Y2ggdGhlDQo+ID4gZmlyc3QgMSBH
Yi9zIE1BQy9NRElPIGNvbnRyb2xsZXIgaXMgdXNlZCB0byBtYW5hZ2UgYWxsIHRoZSAxIEdiL3MN
Cj4gPiBQSFkocykgYW5kIHRoZSBmaXJzdCAxMCBHYi9zIE1BQy9NRElPIGNvbnRyb2xsZXIgaXMg
dXNlZCB0byBtYW5hZ2UgYWxsDQo+ID4gdGhlIDEwIEdiL3MgUEhZKHMpLiBFYWNoIE1ESU8gY29u
dHJvbGxlciBoYXMgdGhlIGFiaWxpdHkgdG8gZ2VuZXJhdGUNCj4gPiBpbnRlcnJ1cHRzIGJ1dCBv
bmx5IHBpbm5lZCBvdXQgTURJTyBjb250cm9sbGVycyBhcmUgaG9va2VkIHVwIHRvIHRoZQ0KPiA+
IE1QSUMgKGFzIHN1Y2ggdGhlIHRhbGsgYWJvdXQgdHdvIGludGVycnVwdHMpDQo+ID4NCj4gPiAo
RWFjaCBNQUMgaGFzIGFsc28gaW50ZWdyYXRlZCBhIFNFUkRFUy9UQkkvImludGVybmFsIiBQSFkg
dGhhdCBpcw0KPiA+IGNvbm5lY3RlZCB0byB0aGUgImxvY2FsIiBNRElPIGNvbnRyb2xsZXIpDQo+
ID4NCj4gPiBBcyB5b3UgY2FuIGltYWdpbmUgdGhpcyBjcmVhdGVzIGEgbnVtYmVyIG9mIHByb2Js
ZW1zIGluIGEgcGFydGl0aW9uaW5nDQo+ID4gc2NlbmFyaW8gKGFuZCBub3QganVzdCwgaW1hZ2lu
ZSBSQ1dzIHdoZXJlIHRoZSBmaXJzdCBNQUMgaXMgbm90DQo+ID4gdXNlZC9lbmFibGVkKS4gSW4g
b3JkZXIgdG8gaGVscCBhIGJpdCAoYnV0IG5vdCBxdWl0ZSBlbm91Z2gpLCBpbiBGTWFuDQo+ID4g
djMsIHR3byBhZGRpdGlvbmFsIE1ESU8gY29udHJvbGxlcnMgKG9uZSBmb3IgMSB0aGUgR2IvcyBQ
SFkocykgYW5kIG9uZQ0KPiA+IGZvciAxIHRoZSAxMCBHYi9zIFBIWShzKSkgaGF2ZSBiZWVuIGlu
dGVncmF0ZWQgdGhhdCBhcmUgbm90IGFzc29jaWF0ZWQNCj4gPiB3aXRoIGFueSBNQUMgYW5kIHRo
ZXNlIGFyZSB0aGUgcGlubmVkIG91dCBNRElPIGNvbnRyb2xsZXJzIG9uIHN1Y2gNCj4gPiBTb0Mo
cykgKGNoYXNzaXMgdjIpDQo+IA0KPiBJJ20gaGFwcHkgdG8gaGVhciB0aGF0LiAgSXMgdGhhdCB3
aGF0IGlzIG1lYW50IGJ5ICJleHRlcm5hbCIgaGVyZT8gIEkgdGhvdWdodCBpdA0KPiBtZWFudCBl
eHRlcm5hbCB0byB0aGUgU29DLiAgSXMgdGhpcyB0aGUgdGVybSB1c2VkIGJ5IGhhcmR3YXJlIGRv
Y3VtZW50YXRpb24/DQpbUy5IXSBZZXMuICJleHRlcm5hbCIgJiAiaW50ZXJuYWwiIGFyZSB1c2Vk
IGJ5IGhhcmR3YXJlIGRvY3VtZW50YXRpb24uDQoNCj4gSSdkIGhhdmUgY2FsbGVkIGl0ICJpbmRl
cGVuZGVudCIgb3Igc2ltaWxhci4NCj4gDQo+ID4gPj4gICBEb2VzICJvcHRpb25hbCIgbWVhbiBp
dCdzIHVzZWQgaWYgYW5kDQo+ID4gPj4+IG9ubHkgaWYgZXh0ZXJuYWwgTURJTyBpcyB1c2VkLCBv
ciBpcyBpdCBvcHRpb25hbCBldmVuIHdpdGgNCj4gPiA+Pj4gZXh0ZXJuYWwgTURJTz8gIEkgc2Vl
IGl0J3Mgbm90IHByZXNlbnQgaW4gdGhlIGV4YW1wbGUgLS0gZG8gd2Ugbm90DQo+ID4gPj4+IGhh
dmUgYSByZWFsIGV4YW1wbGUgdGhhdCBoYXMgdGhlIGludGVycnVwdD8NCj4gPiA+PiBbUy5IXSAi
b3B0aW9uYWwiIG1lYW5zIGl0J3MgYXZhaWxhYmxlIG9uIGhhcmR3YXJlLCBidXQgTURJTyBkcml2
ZXIgZG9lcyBub3QNCj4gdXNlIGludGVycnVwdC4NCj4gPiA+PiBTbyB3ZSBkb24ndCBoYXZlIGEg
cmVhbCBleGFtcGxlLg0KPiA+ID4NCj4gPiA+IDxyZWNvcmQgdHlwZT0iYnJva2VuIj5UaGUgZGV2
aWNlIHRyZWUgZGVzY3JpYmVzIHRoZSBoYXJkd2FyZSwgbm90DQo+ID4gPiB0aGUgZHJpdmVyPC9y
ZWNvcmQ+DQo+ID4NCj4gPiBBbnl3YXksIG9ubHkgdHdvIE1ESU8gbm9kZXMgKG91dCBvZiA0IHRv
IDE0KSB3b3VsZCBoYXZlIGFuIGludGVycnVwdA0KPiA+IHByb3BlcnR5IGRlc2NyaWJpbmcgZXhh
Y3RseSBvbmUgaW50ZXJydXB0LiBXaGF0IGxhbmd1YWdlIHNob3VsZCB3ZSB1c2UNCj4gPiB0byBj
b252ZXkgdGhpcyBzaXR1YXRpb24NCj4gDQo+IFNvIHRoZSBhbnN3ZXIgaXMgdGhhdCB0aGVyZSB3
aWxsIG5vdCBiZSBtb3JlIHRoYW4gb25lIE1ESU8gY29udHJvbGxlciBwZXIgTURJTw0KPiBub2Rl
LCBvciBtb3JlIHRoYW4gb25lIGludGVycnVwdCBwZXIgTURJTyBub2RlPyANCltTLkhdIFllcywg
b25lIE1ESU8gY29udHJvbGxlciBwZXIgTURJTyBub2RlLCBhbmQgb25lIGludGVycnVwdCBwZXIg
ImV4dGVybmFsIg0KTURJTyBub2RlLg0KDQogSW4gdGhhdCBjYXNlIGp1c3QgZ2V0IHJpZCBvZg0K
PiB0aGUgY29uZnVzaW5nICJyZXNwZWN0aXZlbHkiIHNlbnRlbmNlIC0tIGFuZCBhbHdheXMgZGVz
Y3JpYmUgdGhlIGludGVycnVwdCBpZiBpdA0KPiBleGlzdHMgaW4gaGFyZHdhcmUuDQpbUy5IXSBP
Sy4NCg0KVGhhbmtzIQ0KU2hhb2h1aQ0K
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] [v3] power/fsl: add MDIO dt binding for FMan
2015-01-08 1:12 ` Scott Wood
2015-01-08 3:58 ` Shaohui Xie
@ 2015-01-08 9:31 ` Emil Medve
1 sibling, 0 replies; 9+ messages in thread
From: Emil Medve @ 2015-01-08 9:31 UTC (permalink / raw)
To: Scott Wood
Cc: devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
Xie Shaohui-B21989
Hello Scott,
On 01/07/2015 07:12 PM, Scott Wood wrote:
> On Wed, 2015-01-07 at 13:44 -0600, Emil Medve wrote:
>> Hello Scott,
>>
>>
>> On 01/07/2015 12:05 PM, Scott Wood wrote:
>>> On Tue, 2015-01-06 at 23:29 -0600, Xie Shaohui-B21989 wrote:
>>>>>>> +- interrupts
>>>>>>> + Usage: optional
>>>>>>> + Value type: <prop-encoded-array>
>>>>>>> + Definition: Event interrupt of external MDIO controller.
>>>>>>> + 1 Gb/s MDIO and 10 Gb/s MDIO has one interrupt respectively.
>>>>>
>>>>> I'm confused by "respectively" here. Does fsl,fman-memac-mdio have two
>>>>> interrupts (one for 1 Gb/s and one for 10 Gb/s)?
>>>> [S.H] We use two MDIO controllers for external PHY management. One for 1 Gb/s,
>>>> One for 10 Gb/s, and two MDIO interrupts connected to MPIC.
>>>
>>> If there can be two interrupts you need to make that clear and specify
>>> the order.
>>>
>>> Is it possible for one MDIO controller to have an interrupt connected
>>> but not the other, on the same system? How would you represent that in
>>> the device tree? If there are two MDIO controllers why are they in the
>>> same node?
>>
>> Historically (FMan v2 and even before/legacy) we've had each MAC include
>> an MDIO controller, but only one MDIO controller per MAC type/speed (1
>> Gb/s vs 10 Gb/s) is pinned out and all the same speed PHY(s) are
>> connected to the respective MDIO controllers. As such the first 1 Gb/s
>> MAC/MDIO controller is used to manage all the 1 Gb/s PHY(s) and the
>> first 10 Gb/s MAC/MDIO controller is used to manage all the 10 Gb/s
>> PHY(s). Each MDIO controller has the ability to generate interrupts but
>> only pinned out MDIO controllers are hooked up to the MPIC (as such the
>> talk about two interrupts)
>>
>> (Each MAC has also integrated a SERDES/TBI/"internal" PHY that is
>> connected to the "local" MDIO controller)
>>
>> As you can imagine this creates a number of problems in a partitioning
>> scenario (and not just, imagine RCWs where the first MAC is not
>> used/enabled). In order to help a bit (but not quite enough), in FMan
>> v3, two additional MDIO controllers (one for 1 the Gb/s PHY(s) and one
>> for 1 the 10 Gb/s PHY(s)) have been integrated that are not associated
>> with any MAC and these are the pinned out MDIO controllers on such
>> SoC(s) (chassis v2)
>
> I'm happy to hear that. Is that what is meant by "external" here?
"External" doesn't mean external to the MAC nodes. "External" doesn't
even properly apply to the MDIO controller(s) at all but to the PHY(s).
> I thought it meant external to the SoC. Is this the term used by
> hardware documentation?
The documentation (mostly chip errata documents) refers to
external/internal MDIO accesses and as on FMan v3 external PHY accesses
are always made via these extra MDIO controllers (pinned oud) and the
internal SERDES PHY accesses are always made via the in-MAC MDIO
controllers some level of confusion is easy to be achieved. All the MDIO
controllers are identical whether they are in-MAC or standalone
> I'd have called it "independent" or similar.
To make things even more confusing, some documents call these extra MDIO
controllers "dedicated"
Cheers,
>>>> Does "optional" mean it's used if and
>>>>> only if external MDIO is used, or is it optional even with external MDIO? I see
>>>>> it's not present in the example -- do we not have a real example that has the
>>>>> interrupt?
>>>> [S.H] "optional" means it's available on hardware, but MDIO driver does not use interrupt.
>>>> So we don't have a real example.
>>>
>>> <record type="broken">The device tree describes the hardware, not the
>>> driver</record>
>>
>> Anyway, only two MDIO nodes (out of 4 to 14) would have an interrupt
>> property describing exactly one interrupt. What language should we use
>> to convey this situation
>
> So the answer is that there will not be more than one MDIO controller
> per MDIO node, or more than one interrupt per MDIO node? In that case
> just get rid of the confusing "respectively" sentence -- and always
> describe the interrupt if it exists in hardware.
>
> -Scott
>
>
> .
>
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2015-01-08 9:32 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-23 7:57 [PATCH] [v3] power/fsl: add MDIO dt binding for FMan shh.xie
2015-01-05 11:21 ` Shaohui Xie
2015-01-07 0:28 ` Scott Wood
2015-01-07 5:29 ` Shaohui Xie
2015-01-07 18:05 ` Scott Wood
2015-01-07 19:44 ` Emil Medve
2015-01-08 1:12 ` Scott Wood
2015-01-08 3:58 ` Shaohui Xie
2015-01-08 9:31 ` Emil Medve
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).