linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] selftests/powerpc: Add .gitignore for powerpc selftests
@ 2015-01-13 23:49 Michael Ellerman
  2015-01-14  0:16 ` Shuah Khan
  0 siblings, 1 reply; 5+ messages in thread
From: Michael Ellerman @ 2015-01-13 23:49 UTC (permalink / raw)
  To: linuxppc-dev; +Cc: linux-kernel, shuahkh

Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
---
 .../testing/selftests/powerpc/copyloops/.gitignore |  4 ++++
 tools/testing/selftests/powerpc/mm/.gitignore      |  1 +
 tools/testing/selftests/powerpc/pmu/.gitignore     |  3 +++
 tools/testing/selftests/powerpc/pmu/ebb/.gitignore | 22 ++++++++++++++++++++++
 .../selftests/powerpc/primitives/.gitignore        |  1 +
 tools/testing/selftests/powerpc/tm/.gitignore      |  1 +
 6 files changed, 32 insertions(+)
 create mode 100644 tools/testing/selftests/powerpc/copyloops/.gitignore
 create mode 100644 tools/testing/selftests/powerpc/mm/.gitignore
 create mode 100644 tools/testing/selftests/powerpc/pmu/.gitignore
 create mode 100644 tools/testing/selftests/powerpc/pmu/ebb/.gitignore
 create mode 100644 tools/testing/selftests/powerpc/primitives/.gitignore
 create mode 100644 tools/testing/selftests/powerpc/tm/.gitignore

diff --git a/tools/testing/selftests/powerpc/copyloops/.gitignore b/tools/testing/selftests/powerpc/copyloops/.gitignore
new file mode 100644
index 000000000000..25a192f62c4d
--- /dev/null
+++ b/tools/testing/selftests/powerpc/copyloops/.gitignore
@@ -0,0 +1,4 @@
+copyuser_64
+copyuser_power7
+memcpy_64
+memcpy_power7
diff --git a/tools/testing/selftests/powerpc/mm/.gitignore b/tools/testing/selftests/powerpc/mm/.gitignore
new file mode 100644
index 000000000000..156f4e89c2f1
--- /dev/null
+++ b/tools/testing/selftests/powerpc/mm/.gitignore
@@ -0,0 +1 @@
+hugetlb_vs_thp_test
diff --git a/tools/testing/selftests/powerpc/pmu/.gitignore b/tools/testing/selftests/powerpc/pmu/.gitignore
new file mode 100644
index 000000000000..e748f336eed3
--- /dev/null
+++ b/tools/testing/selftests/powerpc/pmu/.gitignore
@@ -0,0 +1,3 @@
+count_instructions
+l3_bank_test
+per_event_excludes
diff --git a/tools/testing/selftests/powerpc/pmu/ebb/.gitignore b/tools/testing/selftests/powerpc/pmu/ebb/.gitignore
new file mode 100644
index 000000000000..5967ff34c167
--- /dev/null
+++ b/tools/testing/selftests/powerpc/pmu/ebb/.gitignore
@@ -0,0 +1,22 @@
+back_to_back_ebbs_test
+close_clears_pmcc_test
+cpu_event_pinned_vs_ebb_test
+cpu_event_vs_ebb_test
+cycles_test
+cycles_with_freeze_test
+cycles_with_mmcr2_test
+ebb_on_child_test
+ebb_on_willing_child_test
+ebb_vs_cpu_event_test
+event_attributes_test
+fork_cleanup_test
+instruction_count_test
+lost_exception_test
+multi_counter_test
+multi_ebb_procs_test
+no_handler_test
+pmae_handling_test
+pmc56_overflow_test
+reg_access_test
+task_event_pinned_vs_ebb_test
+task_event_vs_ebb_test
diff --git a/tools/testing/selftests/powerpc/primitives/.gitignore b/tools/testing/selftests/powerpc/primitives/.gitignore
new file mode 100644
index 000000000000..4cc4e31bed1d
--- /dev/null
+++ b/tools/testing/selftests/powerpc/primitives/.gitignore
@@ -0,0 +1 @@
+load_unaligned_zeropad
diff --git a/tools/testing/selftests/powerpc/tm/.gitignore b/tools/testing/selftests/powerpc/tm/.gitignore
new file mode 100644
index 000000000000..33d02cc54a3e
--- /dev/null
+++ b/tools/testing/selftests/powerpc/tm/.gitignore
@@ -0,0 +1 @@
+tm-resched-dscr
-- 
2.1.0

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] selftests/powerpc: Add .gitignore for powerpc selftests
  2015-01-13 23:49 [PATCH] selftests/powerpc: Add .gitignore for powerpc selftests Michael Ellerman
@ 2015-01-14  0:16 ` Shuah Khan
  2015-01-14  2:15   ` Michael Ellerman
  0 siblings, 1 reply; 5+ messages in thread
From: Shuah Khan @ 2015-01-14  0:16 UTC (permalink / raw)
  To: Michael Ellerman, linuxppc-dev; +Cc: linux-kernel

Please add a commit log.

On 01/13/2015 04:49 PM, Michael Ellerman wrote:
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> ---
>  .../testing/selftests/powerpc/copyloops/.gitignore |  4 ++++
>  tools/testing/selftests/powerpc/mm/.gitignore      |  1 +
>  tools/testing/selftests/powerpc/pmu/.gitignore     |  3 +++
>  tools/testing/selftests/powerpc/pmu/ebb/.gitignore | 22 ++++++++++++++++++++++
>  .../selftests/powerpc/primitives/.gitignore        |  1 +
>  tools/testing/selftests/powerpc/tm/.gitignore      |  1 +
>  6 files changed, 32 insertions(+)
>  create mode 100644 tools/testing/selftests/powerpc/copyloops/.gitignore
>  create mode 100644 tools/testing/selftests/powerpc/mm/.gitignore
>  create mode 100644 tools/testing/selftests/powerpc/pmu/.gitignore
>  create mode 100644 tools/testing/selftests/powerpc/pmu/ebb/.gitignore
>  create mode 100644 tools/testing/selftests/powerpc/primitives/.gitignore
>  create mode 100644 tools/testing/selftests/powerpc/tm/.gitignore

Please create a single .gitignore for all targets right under
tools/testing/selftests/powerpc instead of multiple .gitignore
files.

thanks,
-- Shuah

-- 
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@osg.samsung.com | (970) 217-8978

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] selftests/powerpc: Add .gitignore for powerpc selftests
  2015-01-14  0:16 ` Shuah Khan
@ 2015-01-14  2:15   ` Michael Ellerman
  2015-01-14  3:50     ` Anshuman Khandual
  2015-01-14 17:20     ` Shuah Khan
  0 siblings, 2 replies; 5+ messages in thread
From: Michael Ellerman @ 2015-01-14  2:15 UTC (permalink / raw)
  To: Shuah Khan; +Cc: linuxppc-dev, linux-kernel

On Tue, 2015-01-13 at 17:16 -0700, Shuah Khan wrote:
> Please add a commit log.
 
What does it need to say?

> On 01/13/2015 04:49 PM, Michael Ellerman wrote:
> > Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> > ---
> >  .../testing/selftests/powerpc/copyloops/.gitignore |  4 ++++
> >  tools/testing/selftests/powerpc/mm/.gitignore      |  1 +
> >  tools/testing/selftests/powerpc/pmu/.gitignore     |  3 +++
> >  tools/testing/selftests/powerpc/pmu/ebb/.gitignore | 22 ++++++++++++++++++++++
> >  .../selftests/powerpc/primitives/.gitignore        |  1 +
> >  tools/testing/selftests/powerpc/tm/.gitignore      |  1 +
> >  6 files changed, 32 insertions(+)
> >  create mode 100644 tools/testing/selftests/powerpc/copyloops/.gitignore
> >  create mode 100644 tools/testing/selftests/powerpc/mm/.gitignore
> >  create mode 100644 tools/testing/selftests/powerpc/pmu/.gitignore
> >  create mode 100644 tools/testing/selftests/powerpc/pmu/ebb/.gitignore
> >  create mode 100644 tools/testing/selftests/powerpc/primitives/.gitignore
> >  create mode 100644 tools/testing/selftests/powerpc/tm/.gitignore
> 
> Please create a single .gitignore for all targets right under
> tools/testing/selftests/powerpc instead of multiple .gitignore
> files.

Why? Having separate files makes it less likely we'll get merge conflicts
between different test subdirectores, it also makes it more likely someone
adding a test will notice they need to update the .gitignore in the same
directory.

cheers

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] selftests/powerpc: Add .gitignore for powerpc selftests
  2015-01-14  2:15   ` Michael Ellerman
@ 2015-01-14  3:50     ` Anshuman Khandual
  2015-01-14 17:20     ` Shuah Khan
  1 sibling, 0 replies; 5+ messages in thread
From: Anshuman Khandual @ 2015-01-14  3:50 UTC (permalink / raw)
  To: Michael Ellerman, Shuah Khan; +Cc: linuxppc-dev, linux-kernel

On 01/14/2015 07:45 AM, Michael Ellerman wrote:
> On Tue, 2015-01-13 at 17:16 -0700, Shuah Khan wrote:
>> Please add a commit log.
>  
> What does it need to say?
> 
>> On 01/13/2015 04:49 PM, Michael Ellerman wrote:
>>> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
>>> ---
>>>  .../testing/selftests/powerpc/copyloops/.gitignore |  4 ++++
>>>  tools/testing/selftests/powerpc/mm/.gitignore      |  1 +
>>>  tools/testing/selftests/powerpc/pmu/.gitignore     |  3 +++
>>>  tools/testing/selftests/powerpc/pmu/ebb/.gitignore | 22 ++++++++++++++++++++++
>>>  .../selftests/powerpc/primitives/.gitignore        |  1 +
>>>  tools/testing/selftests/powerpc/tm/.gitignore      |  1 +
>>>  6 files changed, 32 insertions(+)
>>>  create mode 100644 tools/testing/selftests/powerpc/copyloops/.gitignore
>>>  create mode 100644 tools/testing/selftests/powerpc/mm/.gitignore
>>>  create mode 100644 tools/testing/selftests/powerpc/pmu/.gitignore
>>>  create mode 100644 tools/testing/selftests/powerpc/pmu/ebb/.gitignore
>>>  create mode 100644 tools/testing/selftests/powerpc/primitives/.gitignore
>>>  create mode 100644 tools/testing/selftests/powerpc/tm/.gitignore
>>
>> Please create a single .gitignore for all targets right under
>> tools/testing/selftests/powerpc instead of multiple .gitignore
>> files.
> 
> Why? Having separate files makes it less likely we'll get merge conflicts
> between different test subdirectores, it also makes it more likely someone
> adding a test will notice they need to update the .gitignore in the same
> directory.

Hey Michael,

I had already posted a similar patch in this regard along with the ptrace
patches last month. Thats why I mentioned in the cover letter that
gitignore updates for all these tests will come from that patch series
instead of from this one. 

https://lkml.org/lkml/2014/12/2/80

Regards
Anshuman

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] selftests/powerpc: Add .gitignore for powerpc selftests
  2015-01-14  2:15   ` Michael Ellerman
  2015-01-14  3:50     ` Anshuman Khandual
@ 2015-01-14 17:20     ` Shuah Khan
  1 sibling, 0 replies; 5+ messages in thread
From: Shuah Khan @ 2015-01-14 17:20 UTC (permalink / raw)
  To: Michael Ellerman; +Cc: linuxppc-dev, linux-kernel

On 01/13/2015 07:15 PM, Michael Ellerman wrote:
> On Tue, 2015-01-13 at 17:16 -0700, Shuah Khan wrote:
>> Please add a commit log.
>  
> What does it need to say?

Explain the change the patch is making. Please see
Documentation/SubmittingPatches for details.

Looks like this patch is no longer needed as I see a new
patch added to the series from Anshuman Khandual.

> 
>> On 01/13/2015 04:49 PM, Michael Ellerman wrote:
>>> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
>>> ---
>>>  .../testing/selftests/powerpc/copyloops/.gitignore |  4 ++++
>>>  tools/testing/selftests/powerpc/mm/.gitignore      |  1 +
>>>  tools/testing/selftests/powerpc/pmu/.gitignore     |  3 +++
>>>  tools/testing/selftests/powerpc/pmu/ebb/.gitignore | 22 ++++++++++++++++++++++
>>>  .../selftests/powerpc/primitives/.gitignore        |  1 +
>>>  tools/testing/selftests/powerpc/tm/.gitignore      |  1 +
>>>  6 files changed, 32 insertions(+)
>>>  create mode 100644 tools/testing/selftests/powerpc/copyloops/.gitignore
>>>  create mode 100644 tools/testing/selftests/powerpc/mm/.gitignore
>>>  create mode 100644 tools/testing/selftests/powerpc/pmu/.gitignore
>>>  create mode 100644 tools/testing/selftests/powerpc/pmu/ebb/.gitignore
>>>  create mode 100644 tools/testing/selftests/powerpc/primitives/.gitignore
>>>  create mode 100644 tools/testing/selftests/powerpc/tm/.gitignore
>>
>> Please create a single .gitignore for all targets right under
>> tools/testing/selftests/powerpc instead of multiple .gitignore
>> files.
> 
> Why? Having separate files makes it less likely we'll get merge conflicts
> between different test subdirectores, it also makes it more likely someone
> adding a test will notice they need to update the .gitignore in the same
> directory.
> 

It is a matter of reducing the number of files. I am fine with creating
one per directory, if that fits in better with powerpc tests.

-- Shuah


-- 
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@osg.samsung.com | (970) 217-8978

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2015-01-14 17:20 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-13 23:49 [PATCH] selftests/powerpc: Add .gitignore for powerpc selftests Michael Ellerman
2015-01-14  0:16 ` Shuah Khan
2015-01-14  2:15   ` Michael Ellerman
2015-01-14  3:50     ` Anshuman Khandual
2015-01-14 17:20     ` Shuah Khan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).