From: Ian Munsie <imunsie@au1.ibm.com>
To: Ryan Grimm <grimm@linux.vnet.ibm.com>
Cc: mikey <mikey@neuling.org>, linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH 3/3] CXL: Add reset to sysfs
Date: Thu, 15 Jan 2015 16:51:48 +1100 [thread overview]
Message-ID: <1421300999-sup-3862@delenn.ozlabs.ibm.com> (raw)
In-Reply-To: <1421290601-3293-3-git-send-email-grimm@linux.vnet.ibm.com>
Excerpts from Ryan Grimm's message of 2015-01-15 13:56:41 +1100:
> +What: /sys/class/cxl/<card>/reset
> +Date: October 2014
> +Contact: linuxppc-dev@lists.ozlabs.org
> +Description: write only
> + Writing 1 here will issue a PERST to card.
...
> +static ssize_t reset_adapter_store(struct device *device,
> + struct device_attribute *attr,
> + const char *buf, size_t count)
> +{
> + struct cxl *adapter = to_cxl_adapter(device);
> + int rc;
> +
> + if ((rc = cxl_reset(adapter)))
> + return rc;
> + return count;
> +}
Looks like we reset the card no matter what is written to that file?
I like the description better - add a test here to match what it says.
Cheers,
-Ian
next prev parent reply other threads:[~2015-01-15 5:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-15 2:56 [PATCH 1/3] CXL: Add image control to sysfs Ryan Grimm
2015-01-15 2:56 ` [PATCH 2/3] CXL: Snoop control Ryan Grimm
2015-01-15 5:16 ` Ian Munsie
2015-01-15 21:46 ` Ryan Grimm
2015-01-15 2:56 ` [PATCH 3/3] CXL: Add reset to sysfs Ryan Grimm
2015-01-15 5:42 ` Ian Munsie
2015-01-15 6:18 ` Ian Munsie
2015-01-15 21:58 ` Ryan Grimm
2015-01-15 5:51 ` Ian Munsie [this message]
2015-01-15 4:41 ` [PATCH 1/3] CXL: Add image control " Ian Munsie
2015-01-15 4:46 ` Ian Munsie
2015-01-15 4:54 ` Ian Munsie
2015-01-15 5:07 ` Michael Ellerman
2015-01-15 5:44 ` Ian Munsie
2015-01-15 21:45 ` Ryan Grimm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421300999-sup-3862@delenn.ozlabs.ibm.com \
--to=imunsie@au1.ibm.com \
--cc=grimm@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).