From: Gavin Shan <gwshan@linux.vnet.ibm.com>
To: linuxppc-dev@lists.ozlabs.org
Cc: Gavin Shan <gwshan@linux.vnet.ibm.com>
Subject: [PATCH] powerpc/pseries: Avoid context switch in EEH reset if required
Date: Mon, 19 Jan 2015 09:47:23 +1100 [thread overview]
Message-ID: <1421621243-21265-1-git-send-email-gwshan@linux.vnet.ibm.com> (raw)
On pseries platform, the EEH reset backend pseries_eeh_reset() can
be called in atomic context as follows. For this case, we should
call udelay() instead of msleep() to avoid context switching.
drivers/scsi/ipr.c::ipr_reset_slot_reset_done()
drivers/pci/pci.c::pci_set_pcie_reset_state()
arch/powerpc/kernel/eeh.c::pcibios_set_pcie_reset_state()
arch/powerpc/platforms/pseries/eeh_pseries.c::pseries_eeh_reset()
Signed-off-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
Tested-by: Wen Xiong<wenxiong@linux.vnet.ibm.com>
---
arch/powerpc/platforms/pseries/eeh_pseries.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/arch/powerpc/platforms/pseries/eeh_pseries.c b/arch/powerpc/platforms/pseries/eeh_pseries.c
index a6c7e19..67623a3 100644
--- a/arch/powerpc/platforms/pseries/eeh_pseries.c
+++ b/arch/powerpc/platforms/pseries/eeh_pseries.c
@@ -503,8 +503,7 @@ static int pseries_eeh_get_state(struct eeh_pe *pe, int *state)
*/
static int pseries_eeh_reset(struct eeh_pe *pe, int option)
{
- int config_addr;
- int ret;
+ int config_addr, delay, ret;
/* Figure out PE address */
config_addr = pe->config_addr;
@@ -528,9 +527,14 @@ static int pseries_eeh_reset(struct eeh_pe *pe, int option)
/* We need reset hold or settlement delay */
if (option == EEH_RESET_FUNDAMENTAL ||
option == EEH_RESET_HOT)
- msleep(EEH_PE_RST_HOLD_TIME);
+ delay = EEH_PE_RST_HOLD_TIME;
+ else
+ delay = EEH_PE_RST_SETTLE_TIME;
+
+ if (in_atomic())
+ udelay(delay * 1000);
else
- msleep(EEH_PE_RST_SETTLE_TIME);
+ msleep(delay);
return ret;
}
--
1.8.3.2
next reply other threads:[~2015-01-18 22:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-18 22:47 Gavin Shan [this message]
2015-01-20 9:28 ` [PATCH] powerpc/pseries: Avoid context switch in EEH reset if required Benjamin Herrenschmidt
2015-01-20 22:56 ` Gavin Shan
2015-01-20 23:53 ` Gavin Shan
2015-01-23 3:50 ` Gavin Shan
2015-01-24 9:57 ` Benjamin Herrenschmidt
2015-01-26 23:36 ` Brian King
2015-01-27 4:31 ` Benjamin Herrenschmidt
2015-01-27 22:58 ` Brian King
2015-01-27 23:58 ` Benjamin Herrenschmidt
2015-01-30 1:37 ` Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421621243-21265-1-git-send-email-gwshan@linux.vnet.ibm.com \
--to=gwshan@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).