linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: Igal.Liberman <igal.liberman@freescale.com>
Cc: linuxppc-dev@lists.ozlabs.org, Emilian.Medve@freescale.com
Subject: Re: [PATCH] powerpc/dts: Update platform PLL node
Date: Tue, 20 Jan 2015 01:43:30 -0600	[thread overview]
Message-ID: <1421739810.4961.207.camel@freescale.com> (raw)
In-Reply-To: <1421042407-13921-1-git-send-email-igal.liberman@freescale.com>

On Mon, 2015-01-12 at 08:00 +0200, Igal.Liberman wrote:
> From: Igal Liberman <Igal.Liberman@freescale.com>
> 
> Signed-off-by: Igal Liberman <Igal.Liberman@freescale.com>
> Change-Id: I92d020651237041d3767aa35e9345439714f9831
> ---
>  arch/powerpc/boot/dts/fsl/qoriq-clockgen2.dtsi |    6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

Please explain this more.  Was it just wrong before?  Is this for a new
chip?  If the latter, what effect does this have on existing chips?

> diff --git a/arch/powerpc/boot/dts/fsl/qoriq-clockgen2.dtsi b/arch/powerpc/boot/dts/fsl/qoriq-clockgen2.dtsi
> index 48e0b6e..7e1f074 100644
> --- a/arch/powerpc/boot/dts/fsl/qoriq-clockgen2.dtsi
> +++ b/arch/powerpc/boot/dts/fsl/qoriq-clockgen2.dtsi
> @@ -49,14 +49,16 @@ global-utilities@e1000 {
>  		reg = <0x800 0x4>;
>  		compatible = "fsl,qoriq-core-pll-2.0";
>  		clocks = <&sysclk>;
> -		clock-output-names = "pll0", "pll0-div2", "pll0-div4";
> +		clock-output-names = "pll0", "pll0-div2", "pll0-div3",
> +				      "pll0-div4";

You're changing the meaning of existing clock index 2.

-Scott

  reply	other threads:[~2015-01-20  7:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-12  6:00 [PATCH] powerpc/dts: Update platform PLL node Igal.Liberman
2015-01-20  7:43 ` Scott Wood [this message]
2015-01-20  8:51   ` Igal.Liberman
2015-01-30  4:12     ` Scott Wood
2015-02-08 13:27       ` Emil Medve

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1421739810.4961.207.camel@freescale.com \
    --to=scottwood@freescale.com \
    --cc=Emilian.Medve@freescale.com \
    --cc=igal.liberman@freescale.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).