From: Benjamin Herrenschmidt <benh@au1.ibm.com>
To: Brian King <brking@linux.vnet.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org, wenxiong@linux.vnet.ibm.com,
Gavin Shan <gwshan@linux.vnet.ibm.com>,
Brian J King <bjking1@us.ibm.com>
Subject: Re: [PATCH] powerpc/pseries: Avoid context switch in EEH reset if required
Date: Wed, 28 Jan 2015 10:58:42 +1100 [thread overview]
Message-ID: <1422403122.4949.123.camel@au1.ibm.com> (raw)
In-Reply-To: <54C81800.6070407@linux.vnet.ibm.com>
On Tue, 2015-01-27 at 16:58 -0600, Brian King wrote:
> I'd argue we are our own worst enemy here really. The new user is EEH
> code.
> I don't see a huge reason that code would need to use this exact same
> API.
>
> > In fact, even with IPR and the existing call, how do you wait for
> the link to come
> > back for a PERST ? That can take a while...
>
> Basically, I assert reset, delay for 1/2 second via a timer interrupt,
> deassert reset,
> delay for 2 seconds via another timer interrupt, then proceed with
> adapter initialization.
I'm surprised that even works properly... for example in the case of
PERST we need to mask various error traps before asserting and unmask
them when the link comes up (such as the surprise link down error), I
don't see an opportunity in that scheme for FW to do that latter...
Ben.
next prev parent reply other threads:[~2015-01-27 23:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-18 22:47 [PATCH] powerpc/pseries: Avoid context switch in EEH reset if required Gavin Shan
2015-01-20 9:28 ` Benjamin Herrenschmidt
2015-01-20 22:56 ` Gavin Shan
2015-01-20 23:53 ` Gavin Shan
2015-01-23 3:50 ` Gavin Shan
2015-01-24 9:57 ` Benjamin Herrenschmidt
2015-01-26 23:36 ` Brian King
2015-01-27 4:31 ` Benjamin Herrenschmidt
2015-01-27 22:58 ` Brian King
2015-01-27 23:58 ` Benjamin Herrenschmidt [this message]
2015-01-30 1:37 ` Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1422403122.4949.123.camel@au1.ibm.com \
--to=benh@au1.ibm.com \
--cc=bjking1@us.ibm.com \
--cc=brking@linux.vnet.ibm.com \
--cc=gwshan@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=wenxiong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).