* [PATCH][v4] power/fsl: add MDIO dt binding for FMan
@ 2015-01-28 11:54 shh.xie
2015-01-30 0:54 ` Scott Wood
0 siblings, 1 reply; 5+ messages in thread
From: shh.xie @ 2015-01-28 11:54 UTC (permalink / raw)
To: linuxppc-dev, devicetree, scottwood; +Cc: Shaohui Xie, Emilian.Medve
From: Shaohui Xie <Shaohui.Xie@freescale.com>
This binding is for FMan MDIO, it covers FMan v2 & FMan v3.
Signed-off-by: Shaohui Xie <Shaohui.Xie@freescale.com>
---
changes for V4:
revised MDIO interrupt related statement.
changes in v3:
rephrase the 'Definition' of property 'bus-frequency', don't include the
property in example.
changes in v2:
addressed comments from Scott in V1.
.../devicetree/bindings/powerpc/fsl/fman.txt | 70 ++++++++++++++++++++++
1 file changed, 70 insertions(+)
diff --git a/Documentation/devicetree/bindings/powerpc/fsl/fman.txt b/Documentation/devicetree/bindings/powerpc/fsl/fman.txt
index edeea16..774c24f 100644
--- a/Documentation/devicetree/bindings/powerpc/fsl/fman.txt
+++ b/Documentation/devicetree/bindings/powerpc/fsl/fman.txt
@@ -7,6 +7,7 @@ CONTENTS
- FMan MURAM Node
- FMan dTSEC/XGEC/mEMAC Node
- FMan IEEE 1588 Node
+ - FMan MDIO Node
- Example
=============================================================================
@@ -357,6 +358,69 @@ ptp-timer@fe000 {
};
=============================================================================
+FMan MDIO Node
+
+DESCRIPTION
+
+The MDIO is a bus to which the PHY devices are connected.
+
+PROPERTIES
+
+- compatible
+ Usage: required
+ Value type: <stringlist>
+ Definition: A standard property.
+ Must include "fsl,fman-mdio" for 1 Gb/s MDIO from FMan v2.
+ Must include "fsl,fman-xmdio" for 10 Gb/s MDIO from FMan v2.
+ Must include "fsl,fman-memac-mdio" for 1/10 Gb/s MDIO from
+ FMan v3.
+
+- reg
+ Usage: required
+ Value type: <prop-encoded-array>
+ Definition: A standard property.
+
+- bus-frequency
+ Usage: optional
+ Value type: <u32>
+ Definition: Specifies the external MDIO bus clock speed to
+ be used, if different from the standard 2.5 MHz.
+ This may be due to the standard speed being unsupported (e.g.
+ due to a hardware problem), or to advertise that all relevant
+ components in the system support a faster speed.
+
+- interrupts
+ Usage: required
+ Value type: <prop-encoded-array>
+ Definition: Event interrupt of external MDIO controller.
+
+- fsl,fman-internal-mdio
+ Usage: required for internal MDIO
+ Value type: boolean
+ Definition: Fman has internal MDIO for internal PCS(Physical
+ Coding Sublayer) PHYs and external MDIO for external PHYs.
+ The settings and programming routines for internal/external
+ MDIO are different. Must be included for internal MDIO.
+
+EXAMPLE
+
+Example for FMan v2 external MDIO:
+
+mdio@f1000 {
+ compatible = "fsl,fman-xmdio";
+ reg = <0xf1000 0x1000>;
+ interrupts = <101 2 0 0>;
+};
+
+Example for FMan v3 internal MDIO:
+
+mdio@f1000 {
+ compatible = "fsl,fman-memac-mdio";
+ reg = <0xf1000 0x1000>;
+ fsl,fman-internal-mdio;
+};
+
+=============================================================================
Example
fman@400000 {
@@ -531,4 +595,10 @@ fman@400000 {
compatible = "fsl,fman-ptp-timer";
reg = <0xfe000 0x1000>;
};
+
+ mdio@f1000 {
+ compatible = "fsl,fman-xmdio";
+ reg = <0xf1000 0x1000>;
+ interrupts = <101 2 0 0>;
+ };
};
--
1.8.4.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH][v4] power/fsl: add MDIO dt binding for FMan
2015-01-28 11:54 [PATCH][v4] power/fsl: add MDIO dt binding for FMan shh.xie
@ 2015-01-30 0:54 ` Scott Wood
2015-01-30 2:38 ` Shaohui Xie
0 siblings, 1 reply; 5+ messages in thread
From: Scott Wood @ 2015-01-30 0:54 UTC (permalink / raw)
To: shh.xie; +Cc: devicetree, linuxppc-dev, Shaohui Xie, Emilian.Medve
On Wed, 2015-01-28 at 19:54 +0800, shh.xie@gmail.com wrote:
> +- interrupts
> + Usage: required
> + Value type: <prop-encoded-array>
> + Definition: Event interrupt of external MDIO controller.
What if this MDIO controller is not "external"? Should Usage say
"required for external MDIO"?
-Scott
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH][v4] power/fsl: add MDIO dt binding for FMan
2015-01-30 0:54 ` Scott Wood
@ 2015-01-30 2:38 ` Shaohui Xie
2015-01-30 2:43 ` Scott Wood
0 siblings, 1 reply; 5+ messages in thread
From: Shaohui Xie @ 2015-01-30 2:38 UTC (permalink / raw)
To: Scott Wood
Cc: devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
Emilian Medve
PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBXb29kIFNjb3R0LUIwNzQyMQ0K
PiBTZW50OiBGcmlkYXksIEphbnVhcnkgMzAsIDIwMTUgODo1NCBBTQ0KPiBUbzogc2hoLnhpZUBn
bWFpbC5jb20NCj4gQ2M6IGxpbnV4cHBjLWRldkBsaXN0cy5vemxhYnMub3JnOyBkZXZpY2V0cmVl
QHZnZXIua2VybmVsLm9yZzsgTWVkdmUNCj4gRW1pbGlhbi1FTU1FRFZFMTsgWGllIFNoYW9odWkt
QjIxOTg5DQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0hdW3Y0XSBwb3dlci9mc2w6IGFkZCBNRElPIGR0
IGJpbmRpbmcgZm9yIEZNYW4NCj4gDQo+IE9uIFdlZCwgMjAxNS0wMS0yOCBhdCAxOTo1NCArMDgw
MCwgc2hoLnhpZUBnbWFpbC5jb20gd3JvdGU6DQo+ID4gKy0gaW50ZXJydXB0cw0KPiA+ICsJCVVz
YWdlOiByZXF1aXJlZA0KPiA+ICsJCVZhbHVlIHR5cGU6IDxwcm9wLWVuY29kZWQtYXJyYXk+DQo+
ID4gKwkJRGVmaW5pdGlvbjogRXZlbnQgaW50ZXJydXB0IG9mIGV4dGVybmFsIE1ESU8gY29udHJv
bGxlci4NCj4gDQo+IFdoYXQgaWYgdGhpcyBNRElPIGNvbnRyb2xsZXIgaXMgbm90ICJleHRlcm5h
bCI/ICBTaG91bGQgVXNhZ2Ugc2F5DQo+ICJyZXF1aXJlZCBmb3IgZXh0ZXJuYWwgTURJTyI/DQpb
Uy5IXSBJIHRob3VnaHQgdGhlIGRlZmluaXRpb24gY2FuIHRlbGwgdGhlIGludGVycnVwdCBpcyBm
b3IgZXh0ZXJuYWwgTURJTywNCkkgY2FuIGNoYW5nZSB0aGUgVXNhZ2UgdG8gInJlcXVpcmVkIGZv
ciBleHRlcm5hbCBNRElPIiBpbiBuZXh0IHZlcnNpb24uIA0KaG93IGFib3V0IG90aGVyIHBhcnRz
LCBhcmUgdGhleSBPSz8NCg0KVGhhbmtzIQ0KU2hhb2h1aQ0K
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH][v4] power/fsl: add MDIO dt binding for FMan
2015-01-30 2:38 ` Shaohui Xie
@ 2015-01-30 2:43 ` Scott Wood
2015-01-30 3:04 ` Shaohui Xie
0 siblings, 1 reply; 5+ messages in thread
From: Scott Wood @ 2015-01-30 2:43 UTC (permalink / raw)
To: Xie Shaohui-B21989
Cc: devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
Medve Emilian-EMMEDVE1
On Thu, 2015-01-29 at 20:38 -0600, Xie Shaohui-B21989 wrote:
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Friday, January 30, 2015 8:54 AM
> > To: shh.xie@gmail.com
> > Cc: linuxppc-dev@lists.ozlabs.org; devicetree@vger.kernel.org; Medve
> > Emilian-EMMEDVE1; Xie Shaohui-B21989
> > Subject: Re: [PATCH][v4] power/fsl: add MDIO dt binding for FMan
> >
> > On Wed, 2015-01-28 at 19:54 +0800, shh.xie@gmail.com wrote:
> > > +- interrupts
> > > + Usage: required
> > > + Value type: <prop-encoded-array>
> > > + Definition: Event interrupt of external MDIO controller.
> >
> > What if this MDIO controller is not "external"? Should Usage say
> > "required for external MDIO"?
> [S.H] I thought the definition can tell the interrupt is for external MDIO,
> I can change the Usage to "required for external MDIO" in next version.
> how about other parts, are they OK?
Yes. I'll fix it up when applying.
-Scott
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH][v4] power/fsl: add MDIO dt binding for FMan
2015-01-30 2:43 ` Scott Wood
@ 2015-01-30 3:04 ` Shaohui Xie
0 siblings, 0 replies; 5+ messages in thread
From: Shaohui Xie @ 2015-01-30 3:04 UTC (permalink / raw)
To: Scott Wood
Cc: devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
Emilian Medve
PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBXb29kIFNjb3R0LUIwNzQyMQ0K
PiBTZW50OiBGcmlkYXksIEphbnVhcnkgMzAsIDIwMTUgMTA6NDQgQU0NCj4gVG86IFhpZSBTaGFv
aHVpLUIyMTk4OQ0KPiBDYzogbGludXhwcGMtZGV2QGxpc3RzLm96bGFicy5vcmc7IGRldmljZXRy
ZWVAdmdlci5rZXJuZWwub3JnOyBNZWR2ZQ0KPiBFbWlsaWFuLUVNTUVEVkUxDQo+IFN1YmplY3Q6
IFJlOiBbUEFUQ0hdW3Y0XSBwb3dlci9mc2w6IGFkZCBNRElPIGR0IGJpbmRpbmcgZm9yIEZNYW4N
Cj4gDQo+IE9uIFRodSwgMjAxNS0wMS0yOSBhdCAyMDozOCAtMDYwMCwgWGllIFNoYW9odWktQjIx
OTg5IHdyb3RlOg0KPiA+ID4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gPiA+IEZyb206
IFdvb2QgU2NvdHQtQjA3NDIxDQo+ID4gPiBTZW50OiBGcmlkYXksIEphbnVhcnkgMzAsIDIwMTUg
ODo1NCBBTQ0KPiA+ID4gVG86IHNoaC54aWVAZ21haWwuY29tDQo+ID4gPiBDYzogbGludXhwcGMt
ZGV2QGxpc3RzLm96bGFicy5vcmc7IGRldmljZXRyZWVAdmdlci5rZXJuZWwub3JnOyBNZWR2ZQ0K
PiA+ID4gRW1pbGlhbi1FTU1FRFZFMTsgWGllIFNoYW9odWktQjIxOTg5DQo+ID4gPiBTdWJqZWN0
OiBSZTogW1BBVENIXVt2NF0gcG93ZXIvZnNsOiBhZGQgTURJTyBkdCBiaW5kaW5nIGZvciBGTWFu
DQo+ID4gPg0KPiA+ID4gT24gV2VkLCAyMDE1LTAxLTI4IGF0IDE5OjU0ICswODAwLCBzaGgueGll
QGdtYWlsLmNvbSB3cm90ZToNCj4gPiA+ID4gKy0gaW50ZXJydXB0cw0KPiA+ID4gPiArCQlVc2Fn
ZTogcmVxdWlyZWQNCj4gPiA+ID4gKwkJVmFsdWUgdHlwZTogPHByb3AtZW5jb2RlZC1hcnJheT4N
Cj4gPiA+ID4gKwkJRGVmaW5pdGlvbjogRXZlbnQgaW50ZXJydXB0IG9mIGV4dGVybmFsIE1ESU8g
Y29udHJvbGxlci4NCj4gPiA+DQo+ID4gPiBXaGF0IGlmIHRoaXMgTURJTyBjb250cm9sbGVyIGlz
IG5vdCAiZXh0ZXJuYWwiPyAgU2hvdWxkIFVzYWdlIHNheQ0KPiA+ID4gInJlcXVpcmVkIGZvciBl
eHRlcm5hbCBNRElPIj8NCj4gPiBbUy5IXSBJIHRob3VnaHQgdGhlIGRlZmluaXRpb24gY2FuIHRl
bGwgdGhlIGludGVycnVwdCBpcyBmb3IgZXh0ZXJuYWwNCj4gPiBNRElPLCBJIGNhbiBjaGFuZ2Ug
dGhlIFVzYWdlIHRvICJyZXF1aXJlZCBmb3IgZXh0ZXJuYWwgTURJTyIgaW4gbmV4dA0KPiB2ZXJz
aW9uLg0KPiA+IGhvdyBhYm91dCBvdGhlciBwYXJ0cywgYXJlIHRoZXkgT0s/DQo+IA0KPiBZZXMu
ICBJJ2xsIGZpeCBpdCB1cCB3aGVuIGFwcGx5aW5nLg0KDQpUaGFuayB5b3UhDQoNClNoYW9odWkN
Cg0K
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-01-30 3:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-28 11:54 [PATCH][v4] power/fsl: add MDIO dt binding for FMan shh.xie
2015-01-30 0:54 ` Scott Wood
2015-01-30 2:38 ` Shaohui Xie
2015-01-30 2:43 ` Scott Wood
2015-01-30 3:04 ` Shaohui Xie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).