From: Michael Ellerman <mpe@ellerman.id.au>
To: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
acme@kernel.org
Subject: Re: [PATCHv2 0/8] Fix perf probe issues on powerpc
Date: Fri, 30 Jan 2015 13:19:38 +1100 [thread overview]
Message-ID: <1422584378.13284.3.camel@ellerman.id.au> (raw)
In-Reply-To: <20150128064302.GB2078@naverao1-tp.in.ibm.com>
On Wed, 2015-01-28 at 12:13 +0530, Naveen N. Rao wrote:
> On 2015/01/28 05:14PM, Michael Ellerman wrote:
> > On Wed, 2015-01-28 at 11:12 +0530, Naveen N. Rao wrote:
> > > On 2014/12/15 08:20PM, Naveen N Rao wrote:
> > > > This patchset fixes various issues with perf probe on powerpc across ABIv1 and
> > > > ABIv2:
> > > > - in the presence of DWARF debug-info,
> > > > - in the absence of DWARF, but with the symbol table, and
> > > > - in the absence of debug-info, but with kallsyms.
> > > >
> > > > Applies cleanly on -tip. Tested on ppc64 BE and LE.
> > > >
> > > > Changes from previous version:
> > > > Addressed various review comments from Mike Ellerman largely to generalize
> > > > changes. Some of the simpler patches have been retained in their previous form
> > > > to limit code churn, while others have been generalized by introducing arch
> > > > helpers. Individual patches have more details.
> > >
> > > Michael,
> > > Can you please take a quick look at this?
> >
> > I merged patch 1.
> >
> > https://git.kernel.org/cgit/linux/kernel/git/mpe/linux.git/commit/?h=next&id=bf794bf52a80c6278a028f0af2ca32d7c3508c9b
> >
> > The rest are not for me, they're perf tools, so you need to convince acme
> > they're good.
>
> Oh, thanks! Sorry, I didn't realize you had already merged it.
> I assume you are ok with my changes in v2 w.r.t your previous review
> comments.
Yeah it looks like you addressed most of my comments.
cheers
prev parent reply other threads:[~2015-01-30 2:19 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-15 14:50 [PATCHv2 0/8] Fix perf probe issues on powerpc Naveen N. Rao
2014-12-15 14:50 ` [PATCHv2 1/8] kprobes: Fix kallsyms lookup across powerpc ABIv1 and ABIv2 Naveen N. Rao
2014-12-15 14:50 ` [PATCHv2 2/8] perf probe: Improve detection of file/function name in the probe pattern Naveen N. Rao
2015-03-12 20:24 ` Arnaldo Carvalho de Melo
2015-03-12 20:25 ` Arnaldo Carvalho de Melo
2015-03-13 2:03 ` Ananth N Mavinakayanahalli
2015-03-13 11:20 ` Masami Hiramatsu
2015-04-27 5:05 ` Naveen N. Rao
2015-04-27 5:09 ` Naveen N. Rao
2014-12-15 14:50 ` [PATCHv2 3/8] perf probe powerpc: Fix symbol fixup issues due to ELF type Naveen N. Rao
2015-03-12 20:23 ` Arnaldo Carvalho de Melo
2015-04-27 5:06 ` Naveen N. Rao
2014-12-15 14:50 ` [PATCHv2 4/8] perf probe powerpc: Handle powerpc dot symbols Naveen N. Rao
2015-03-12 20:26 ` Arnaldo Carvalho de Melo
2014-12-15 14:50 ` [PATCHv2 5/8] perf probe powerpc: Allow matching against " Naveen N. Rao
2015-03-12 20:30 ` Arnaldo Carvalho de Melo
2015-04-27 5:08 ` Naveen N. Rao
2014-12-15 14:50 ` [PATCHv2 6/8] perf tools powerpc: Fix PPC64 ELF ABIv2 symbol decoding Naveen N. Rao
2015-03-12 20:35 ` Arnaldo Carvalho de Melo
2014-12-15 14:50 ` [PATCHv2 7/8] perf probe powerpc: Use DWARF info only if necessary Naveen N. Rao
2014-12-15 14:50 ` [PATCHv2 8/8] perf probe powerpc: Fixup function entry if using kallsyms lookup Naveen N. Rao
2015-03-12 20:37 ` Arnaldo Carvalho de Melo
2015-01-28 5:42 ` [PATCHv2 0/8] Fix perf probe issues on powerpc Naveen N. Rao
2015-01-28 6:14 ` Michael Ellerman
2015-01-28 6:43 ` Naveen N. Rao
2015-01-30 2:19 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1422584378.13284.3.camel@ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=acme@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=naveen.n.rao@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).