From: Scott Wood <scottwood@freescale.com>
To: Xie Shaohui-B21989 <Shaohui.Xie@freescale.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
Medve Emilian-EMMEDVE1 <Emilian.Medve@freescale.com>
Subject: Re: [PATCH][v4] power/fsl: add MDIO dt binding for FMan
Date: Thu, 29 Jan 2015 20:43:40 -0600 [thread overview]
Message-ID: <1422585820.10544.146.camel@freescale.com> (raw)
In-Reply-To: <DM2PR0301MB0864EF866EFDEB634BED54E5E2310@DM2PR0301MB0864.namprd03.prod.outlook.com>
On Thu, 2015-01-29 at 20:38 -0600, Xie Shaohui-B21989 wrote:
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Friday, January 30, 2015 8:54 AM
> > To: shh.xie@gmail.com
> > Cc: linuxppc-dev@lists.ozlabs.org; devicetree@vger.kernel.org; Medve
> > Emilian-EMMEDVE1; Xie Shaohui-B21989
> > Subject: Re: [PATCH][v4] power/fsl: add MDIO dt binding for FMan
> >
> > On Wed, 2015-01-28 at 19:54 +0800, shh.xie@gmail.com wrote:
> > > +- interrupts
> > > + Usage: required
> > > + Value type: <prop-encoded-array>
> > > + Definition: Event interrupt of external MDIO controller.
> >
> > What if this MDIO controller is not "external"? Should Usage say
> > "required for external MDIO"?
> [S.H] I thought the definition can tell the interrupt is for external MDIO,
> I can change the Usage to "required for external MDIO" in next version.
> how about other parts, are they OK?
Yes. I'll fix it up when applying.
-Scott
next prev parent reply other threads:[~2015-01-30 2:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-28 11:54 [PATCH][v4] power/fsl: add MDIO dt binding for FMan shh.xie
2015-01-30 0:54 ` Scott Wood
2015-01-30 2:38 ` Shaohui Xie
2015-01-30 2:43 ` Scott Wood [this message]
2015-01-30 3:04 ` Shaohui Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1422585820.10544.146.camel@freescale.com \
--to=scottwood@freescale.com \
--cc=Emilian.Medve@freescale.com \
--cc=Shaohui.Xie@freescale.com \
--cc=devicetree@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).