From: Michael Ellerman <mpe@ellerman.id.au>
To: Colin King <colin.king@canonical.com>
Cc: Michael Neuling <mikey@neuling.org>,
linuxppc-dev@lists.ozlabs.org, Ian Munsie <imunsie@au1.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cxl: remove redundant increment of hwirq
Date: Mon, 02 Feb 2015 12:01:22 +1100 [thread overview]
Message-ID: <1422838882.11325.1.camel@ellerman.id.au> (raw)
In-Reply-To: <1422826808-31363-1-git-send-email-colin.king@canonical.com>
On Sun, 2015-02-01 at 21:40 +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Recent commit 80fa93fce37d3490f
> ("cxl: Name interrupts in /proc/interrupt") introduced a
> redundant increment of hwirq which is not used or even
> initialised at the point it is incremented. Detected by
> cppcheck:
>
> [drivers/misc/cxl/irq.c:439]: (error) Uninitialized
> variable: hwirq
>
> Simple fix, remove the redundant increment.
This looks more or less the same as the previous patch you sent? The one which
has been in my next branch for 11 days?
cheers
next prev parent reply other threads:[~2015-02-02 1:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-01 21:40 [PATCH] cxl: remove redundant increment of hwirq Colin King
2015-02-02 1:01 ` Michael Ellerman [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-01-08 22:36 Colin King
2015-01-08 22:42 ` Michael Neuling
2015-01-09 2:20 ` Ian Munsie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1422838882.11325.1.camel@ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=colin.king@canonical.com \
--cc=imunsie@au1.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).