From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (ozlabs.org [103.22.144.67]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 40EFB1A028F for ; Tue, 10 Feb 2015 10:33:48 +1100 (AEDT) Message-ID: <1423524827.19657.1.camel@ellerman.id.au> Subject: Re: [PATCH 1/1] powerpc: fix missing L2 cache size in /sys/devices/system/cpu From: Michael Ellerman To: Dave Olson Date: Tue, 10 Feb 2015 10:33:47 +1100 In-Reply-To: <20150209221421.GA22286@cumulusnetworks.com> References: <20150209221421.GA22286@cumulusnetworks.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Cc: Paul Mackerras , linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, 2015-02-09 at 14:14 -0800, Dave Olson wrote: > From: Dave Olson > > Fix missing L2 cache size in /sys/devices/system/cpu/cpu0/cache/index2/size > This bug appears to be introduced in 2.6.29 by 93197a36a9c16a85fb24cf5a8639f7bf9af838a3. > The missing entry caused lscpu to error out on e500v2 devices, and probably others > error: cannot open /sys/devices/system/cpu/cpu0/cache/index2/size: No such file or directory > The DTS files we see use cache-size for the unified L2 cache size, not d-cache-size Can you convince me that this is not going to break other machines that have "d-cache-size" but not "cache-size"? cheers