From: Stewart Smith <stewart@linux.vnet.ibm.com>
To: mpe@ellerman.id.au
Cc: Stewart Smith <stewart@linux.vnet.ibm.com>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/3] powerpc/powernv: only call OPAL_ELOG_RESEND if firmware supports it
Date: Wed, 18 Feb 2015 11:03:43 +1100 [thread overview]
Message-ID: <1424217824-30596-3-git-send-email-stewart@linux.vnet.ibm.com> (raw)
In-Reply-To: <1424217824-30596-1-git-send-email-stewart@linux.vnet.ibm.com>
Otherwise firmware complains: "OPAL: Called with bad token 74 !"
as not all OPAL systems have the ability to resend error logs.
Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
---
arch/powerpc/platforms/powernv/opal-elog.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/powernv/opal-elog.c b/arch/powerpc/platforms/powernv/opal-elog.c
index 518fe95..38ce757 100644
--- a/arch/powerpc/platforms/powernv/opal-elog.c
+++ b/arch/powerpc/platforms/powernv/opal-elog.c
@@ -313,7 +313,8 @@ int __init opal_elog_init(void)
}
/* We are now ready to pull error logs from opal. */
- opal_resend_pending_logs();
+ if (opal_check_token(OPAL_ELOG_RESEND))
+ opal_resend_pending_logs();
return 0;
}
--
1.7.10.4
next prev parent reply other threads:[~2015-02-18 0:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-18 0:03 [PATCH 0/3] powerpc/powernv: Correctly detect optional OPAL calls Stewart Smith
2015-02-18 0:03 ` [PATCH 1/3] powerpc/powernv: only register log if OPAL supports doing so Stewart Smith
2015-02-18 0:03 ` Stewart Smith [this message]
2015-02-18 0:03 ` [PATCH 3/3] powerpc/powernv: only call OPAL_RESEND_DUMP if firmware supports it Stewart Smith
2015-02-18 7:57 ` [PATCH 0/3] powerpc/powernv: Correctly detect optional OPAL calls Vasant Hegde
2015-02-19 0:43 ` Stewart Smith
-- strict thread matches above, loose matches on Subject: below --
2015-02-12 5:25 [PATCH 0/3] Silence "OPAL called with invalid token" errors Stewart Smith
2015-02-12 5:25 ` [PATCH 2/3] powerpc/powernv: only call OPAL_ELOG_RESEND if firmware supports it Stewart Smith
2015-02-12 9:46 ` Vasant Hegde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1424217824-30596-3-git-send-email-stewart@linux.vnet.ibm.com \
--to=stewart@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).