From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: "Suresh E. Warrier" <warrier@linux.vnet.ibm.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc: Export __spin_yield
Date: Wed, 25 Feb 2015 08:11:51 +1100 [thread overview]
Message-ID: <1424812311.12891.51.camel@kernel.crashing.org> (raw)
In-Reply-To: <54ECA8DB.9000707@linux.vnet.ibm.com>
On Tue, 2015-02-24 at 10:37 -0600, Suresh E. Warrier wrote:
> On 02/23/2015 09:38 PM, Benjamin Herrenschmidt wrote:
> > On Mon, 2015-02-23 at 18:10 -0600, Suresh E. Warrier wrote:
> >> Export __spin_yield so that the arch_spin_unlock() function
> >> can be invoked from a module.
> >
> > Make it EXPORT_SYMBOL_GPL. Also explain why a module might need it
> >
>
> Sure, I will change that to EXPORT_SYMBOL_GPL. Just curious, though,
> there is another symbol arch_spin_unlock_wait that is exported from
> the file without the _GPL prefix. Any idea why?
Nope. Not sure how come we did that.
> I have mentioned that this needs to be exported to call the
> arch_spin_unlock() function from a module. What additional information
> do you think will be useful here ? Are you looking at something
> that explains why a module might need to call arch_spin_unlock()?
What kind of module might need it...
Cheers,
Ben.
next prev parent reply other threads:[~2015-02-24 21:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1424477465-9199-2-git-send-email-warrier@linux.vnet.ibm.com>
2015-02-24 0:10 ` [PATCH] powerpc: Export __spin_yield Suresh E. Warrier
2015-02-24 3:38 ` Benjamin Herrenschmidt
2015-02-24 16:37 ` Suresh E. Warrier
2015-02-24 21:11 ` Benjamin Herrenschmidt [this message]
2015-02-25 23:23 Suresh E. Warrier
2015-03-19 23:08 ` Paul Mackerras
2015-03-30 10:17 ` Geert Uytterhoeven
2015-03-30 10:57 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1424812311.12891.51.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=warrier@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).