From: Scott Wood <scottwood@freescale.com>
To: Dongsheng Wang <dongsheng.wang@freescale.com>
Cc: linuxppc-dev@lists.ozlabs.org, hongtao.jia@freescale.com,
jason.jin@freescale.com
Subject: Re: [PATCH] powerpc/fsl: add power_off support for fsl platform
Date: Tue, 24 Feb 2015 20:29:45 -0600 [thread overview]
Message-ID: <1424831385.4698.53.camel@freescale.com> (raw)
In-Reply-To: <1423032421-31561-1-git-send-email-dongsheng.wang@freescale.com>
On Wed, 2015-02-04 at 14:47 +0800, Dongsheng Wang wrote:
> +void ppc_md_fixup(void)
> +{
This name is way too generic (though it's moot since you shouldn't use
ppc_md for this).
> + struct device_node *np;
> +
> + np = of_find_compatible_node(NULL, NULL, "fsl,fpga-qixis");
> + if (!np)
> + return;
> +
> + of_node_put(np);
> +
> + pm_power_off = fsl_power_off;
> + ppc_md.halt = fsl_power_off;
> +}
Please implement this as a drivers/power/reset driver, and consider
basing on top of
http://lists.infradead.org/pipermail/linux-arm-kernel/2014-October/293089.html
-Scott
next prev parent reply other threads:[~2015-02-25 2:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-04 6:47 [PATCH] powerpc/fsl: add power_off support for fsl platform Dongsheng Wang
2015-02-25 2:29 ` Scott Wood [this message]
2015-02-26 7:54 ` Dongsheng.Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1424831385.4698.53.camel@freescale.com \
--to=scottwood@freescale.com \
--cc=dongsheng.wang@freescale.com \
--cc=hongtao.jia@freescale.com \
--cc=jason.jin@freescale.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).