Re: [PATCH 2/3] powerpc/85xx: Create dts of each core in CAMP mode for P1021RDB-PC

[Scott Wood <scottwood@freescale.com>]

On Thu, 2015-03-26 at 17:15 +0800, ying.zhang@freescale.com wrote:
> From: Ying Zhang <b40530@freescale.com>
> 
> Create the dts files for each core and splits the devices between
> the two cores for P1021RDB-PC.
> 
> Core0 has l2, serial0, i2c, spi, gpio, tdm,dma, usb, eth0, eth1,
> sdhc, crypto, global-util, message, pci0, pci1, msi, crypto.
> Core1 has l2, serial1, eth2.

Are we going to have this split for every board (I hope not)?  We
already have a couple examples of CAMP; why do we need p1021
specifically?

> Signed-off-by: Ying Zhang <b40530@freescale.com>
> Change-Id: I92614abdca3db3ab6083c4443ad563fd687050ec
> Reviewed-on: http://git.am.freescale.net:8181/1179
> Reviewed-by: Fleming Andrew-AFLEMING <AFLEMING@freescale.com>
> Tested-by: Fleming Andrew-AFLEMING <AFLEMING@freescale.com>

Get rid of the gerrit stuff.

> +		mpic: pic@40000 {
> +			protected-sources = <
> +			42		/* serial1 */
> +			31 32 33	/* enet2-queue-group0 */
> +			25 26 27	/* enet2-queue-group1 */
> +			>;
> +			pic-no-reset;
> +		};

If you have pic-no-reset you don't strictly need protected-sources.
Having it can protect against some relatively unlikely software errors,
at the expense of allowing more likely device tree errors.  Or at least,
it makes it harder to modify the device tree to assign devices
differently.

-Scott