From: "Cédric Le Goater" <clg@fr.ibm.com>
To: linuxppc-dev@lists.ozlabs.org
Cc: "Stewart Smith" <stewart@linux.vnet.ibm.com>,
benh@au1.ibm.com, "Cédric Le Goater" <clg@fr.ibm.com>,
"Neelesh Gupta" <neelegup@linux.vnet.ibm.com>,
skiboot@lists.ozlabs.org
Subject: [PATCH v3 1/3] powerpc/powernv: convert codes returned by OPAL calls
Date: Fri, 27 Mar 2015 17:39:19 +0100 [thread overview]
Message-ID: <1427474362-3903-1-git-send-email-clg@fr.ibm.com> (raw)
In-Reply-To: <20150327095936.50A921400A0@ozlabs.org>
OPAL has its own list of return codes. The patch provides a translation
of such codes in errnos for the opal_sensor_read call, and possibly
others if needed.
Signed-off-by: Cédric Le Goater <clg@fr.ibm.com>
---
Changes since v2 :
- renamed and moved the routine to opal.[ch]
- changed default value to ERANGE like rtas
arch/powerpc/include/asm/opal.h | 2 ++
arch/powerpc/platforms/powernv/opal-sensor.c | 6 ++++--
arch/powerpc/platforms/powernv/opal.c | 17 +++++++++++++++++
3 files changed, 23 insertions(+), 2 deletions(-)
Index: linux.git/arch/powerpc/platforms/powernv/opal-sensor.c
===================================================================
--- linux.git.orig/arch/powerpc/platforms/powernv/opal-sensor.c
+++ linux.git/arch/powerpc/platforms/powernv/opal-sensor.c
@@ -46,8 +46,10 @@ int opal_get_sensor_data(u32 sensor_hndl
mutex_lock(&opal_sensor_mutex);
ret = opal_sensor_read(sensor_hndl, token, &data);
- if (ret != OPAL_ASYNC_COMPLETION)
+ if (ret != OPAL_ASYNC_COMPLETION) {
+ ret = opal_error_code(ret);
goto out_token;
+ }
ret = opal_async_wait_response(token, &msg);
if (ret) {
@@ -57,7 +59,7 @@ int opal_get_sensor_data(u32 sensor_hndl
}
*sensor_data = be32_to_cpu(data);
- ret = be64_to_cpu(msg.params[1]);
+ ret = opal_error_code(be64_to_cpu(msg.params[1]));
out_token:
mutex_unlock(&opal_sensor_mutex);
Index: linux.git/arch/powerpc/include/asm/opal.h
===================================================================
--- linux.git.orig/arch/powerpc/include/asm/opal.h
+++ linux.git/arch/powerpc/include/asm/opal.h
@@ -983,6 +983,8 @@ struct opal_sg_list *opal_vmalloc_to_sg_
unsigned long vmalloc_size);
void opal_free_sg_list(struct opal_sg_list *sg);
+extern int opal_error_code(int rc);
+
/*
* Dump region ID range usable by the OS
*/
Index: linux.git/arch/powerpc/platforms/powernv/opal.c
===================================================================
--- linux.git.orig/arch/powerpc/platforms/powernv/opal.c
+++ linux.git/arch/powerpc/platforms/powernv/opal.c
@@ -894,6 +894,23 @@ void opal_free_sg_list(struct opal_sg_li
}
}
+int opal_error_code(int rc)
+{
+ switch (rc) {
+ case OPAL_SUCCESS: return 0;
+ case OPAL_PARAMETER: return -EINVAL;
+ case OPAL_UNSUPPORTED: return -ENOSYS;
+ case OPAL_ASYNC_COMPLETION: return -EAGAIN;
+ case OPAL_BUSY_EVENT: return -EBUSY;
+ case OPAL_NO_MEM: return -ENOMEM;
+ case OPAL_HARDWARE: return -ENOENT;
+ case OPAL_INTERNAL_ERROR: return -EIO;
+ default:
+ pr_err("%s: unexpected OPAL error %d\n", __func__, rc);
+ return -ERANGE;
+ }
+}
+
EXPORT_SYMBOL_GPL(opal_poll_events);
EXPORT_SYMBOL_GPL(opal_rtc_read);
EXPORT_SYMBOL_GPL(opal_rtc_write);
next prev parent reply other threads:[~2015-03-27 16:39 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-25 17:50 [PATCH] powerpc/powernv: handle OPAL_SUCCESS return in opal_sensor_read Cédric Le Goater
2015-03-25 23:07 ` Stewart Smith
2015-03-26 9:44 ` Cedric Le Goater
2015-03-26 12:58 ` Cedric Le Goater
2015-03-26 16:04 ` [PATCH v2 1/3] powerpc/powernv: convert codes returned by OPAL calls Cédric Le Goater
2015-03-26 16:04 ` [PATCH v2 2/3] powerpc/powernv: handle OPAL_SUCCESS return in opal_sensor_read Cédric Le Goater
2015-03-26 16:04 ` [PATCH v2 3/3] powerpc/powernv: remove opal_sensor_mutex Cédric Le Goater
2015-03-27 9:59 ` [v2,1/3] powerpc/powernv: convert codes returned by OPAL calls Michael Ellerman
2015-03-27 10:36 ` [Skiboot] [v2, 1/3] " Benjamin Herrenschmidt
2015-03-27 10:39 ` Cedric Le Goater
2015-03-27 10:45 ` [v2,1/3] " Cedric Le Goater
2015-03-27 16:39 ` Cédric Le Goater [this message]
2015-03-30 2:05 ` [PATCH v3 1/3] " Michael Ellerman
2015-03-30 6:37 ` Cedric Le Goater
2015-03-30 6:54 ` Michael Ellerman
2015-03-30 6:56 ` Cedric Le Goater
2015-03-30 10:06 ` [PATCH v4 1/2] " Cédric Le Goater
2015-03-30 10:06 ` [PATCH v4 2/2] powerpc/powernv: handle OPAL_SUCCESS return in opal_sensor_read Cédric Le Goater
2015-03-27 16:39 ` [PATCH v3 2/3] " Cédric Le Goater
2015-03-27 16:39 ` [PATCH v3 3/3] powerpc/powernv: remove opal_sensor_mutex Cédric Le Goater
2015-03-30 2:09 ` Michael Ellerman
2015-03-30 6:51 ` Cedric Le Goater
2015-03-30 6:59 ` Michael Ellerman
2015-03-30 10:05 ` Cedric Le Goater
2015-03-27 6:05 ` [PATCH] powerpc/powernv: handle OPAL_SUCCESS return in opal_sensor_read Stewart Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427474362-3903-1-git-send-email-clg@fr.ibm.com \
--to=clg@fr.ibm.com \
--cc=benh@au1.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=neelegup@linux.vnet.ibm.com \
--cc=skiboot@lists.ozlabs.org \
--cc=stewart@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).