From: Michael Ellerman <mpe@ellerman.id.au>
To: Joel Stanley <joel@jms.id.au>
Cc: rusty@rustcorp.com.au, linux-kernel@vger.kernel.org,
fabf@skynet.be, jk@ozlabs.org, akpm@linux-foundation.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 2/2] powerpc/powernv: Reboot when requested by firmware
Date: Mon, 30 Mar 2015 16:32:25 +1100 [thread overview]
Message-ID: <1427693545.28219.1.camel@ellerman.id.au> (raw)
In-Reply-To: <1427681733-25488-2-git-send-email-joel@jms.id.au>
On Mon, 2015-03-30 at 12:45 +1030, Joel Stanley wrote:
> Use orderly_reboot so userspace will to shut itself down via the reboot
> path. This is required for graceful reboot initiated by the BMC, such
> as when a user uses ipmitool to issue a 'chassis power cycle' command.
>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
> arch/powerpc/platforms/powernv/opal-power.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/platforms/powernv/opal-power.c b/arch/powerpc/platforms/powernv/opal-power.c
> index 48bf5b0..ac46c2c 100644
> --- a/arch/powerpc/platforms/powernv/opal-power.c
> +++ b/arch/powerpc/platforms/powernv/opal-power.c
> @@ -29,8 +29,9 @@ static int opal_power_control_event(struct notifier_block *nb,
>
> switch (type) {
> case SOFT_REBOOT:
> - /* Fall through. The service processor is responsible for
> - * bringing the machine back up */
> + pr_info("OPAL: reboot requested\n");
> + orderly_reboot();
> + break;
Acked-by: Michael Ellerman <mpe@ellerman.id.au>
Andrew, do you want to take these 2 via your tree? Assuming folks are OK with
patch 1.
cheers
next prev parent reply other threads:[~2015-03-30 5:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-30 2:15 [PATCH 1/2] kernel/reboot.c: Add orderly_reboot for graceful reboot Joel Stanley
2015-03-30 2:15 ` [PATCH 2/2] powerpc/powernv: Reboot when requested by firmware Joel Stanley
2015-03-30 5:32 ` Michael Ellerman [this message]
2015-03-31 22:39 ` [PATCH 1/2] kernel/reboot.c: Add orderly_reboot for graceful reboot Andrew Morton
2015-04-01 3:17 ` Joel Stanley
2015-04-01 5:05 ` Anshuman Khandual
2015-04-01 4:52 ` Anshuman Khandual
2015-04-01 5:03 ` Andrew Morton
2015-04-01 5:05 ` Andrew Morton
2015-04-01 5:32 ` Joel Stanley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427693545.28219.1.camel@ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=akpm@linux-foundation.org \
--cc=fabf@skynet.be \
--cc=jk@ozlabs.org \
--cc=joel@jms.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).