* [PATCH 00/25] treewide: Use bool function return values of true/false not 1/0
@ 2015-03-30 23:45 Joe Perches
2015-03-30 23:46 ` [PATCH 06/25] powerpc: " Joe Perches
2015-03-31 0:07 ` [PATCH 00/25] treewide: " Casey Schaufler
0 siblings, 2 replies; 6+ messages in thread
From: Joe Perches @ 2015-03-30 23:45 UTC (permalink / raw)
To: linux-kernel, linux-arm-kernel, kvmarm, kvm, linux-omap, kvm-ppc,
virtualization, linux-fsdevel, linux-nfs, linux-ide,
kgdb-bugreport, linux-mm, linux-pm, netdev, alsa-devel, bridge,
netfilter-devel, coreteam, patches
Cc: linux-s390, linux-ia64, linux-scsi, linux-mips, linux-hexagon,
linux-security-module, sparclinux, linuxppc-dev
Joe Perches (25):
arm: Use bool function return values of true/false not 1/0
arm64: Use bool function return values of true/false not 1/0
hexagon: Use bool function return values of true/false not 1/0
ia64: Use bool function return values of true/false not 1/0
mips: Use bool function return values of true/false not 1/0
powerpc: Use bool function return values of true/false not 1/0
s390: Use bool function return values of true/false not 1/0
sparc: Use bool function return values of true/false not 1/0
tile: Use bool function return values of true/false not 1/0
unicore32: Use bool function return values of true/false not 1/0
x86: Use bool function return values of true/false not 1/0
virtio_console: Use bool function return values of true/false not 1/0
csiostor: Use bool function return values of true/false not 1/0
dcache: Use bool function return values of true/false not 1/0
nfsd: nfs4state: Use bool function return values of true/false not 1/0
include/linux: Use bool function return values of true/false not 1/0
sound: Use bool function return values of true/false not 1/0
rcu: tree_plugin: Use bool function return values of true/false not 1/0
sched: Use bool function return values of true/false not 1/0
ftrace: Use bool function return values of true/false not 1/0
slub: Use bool function return values of true/false not 1/0
bridge: Use bool function return values of true/false not 1/0
netfilter: Use bool function return values of true/false not 1/0
security: Use bool function return values of true/false not 1/0
sound: wm5100-tables: Use bool function return values of true/false not 1/0
arch/arm/include/asm/dma-mapping.h | 8 ++--
arch/arm/include/asm/kvm_emulate.h | 2 +-
arch/arm/mach-omap2/powerdomain.c | 14 +++---
arch/arm64/include/asm/dma-mapping.h | 2 +-
arch/hexagon/include/asm/dma-mapping.h | 2 +-
arch/ia64/include/asm/dma-mapping.h | 2 +-
arch/mips/include/asm/dma-mapping.h | 2 +-
arch/powerpc/include/asm/dcr-native.h | 2 +-
arch/powerpc/include/asm/dma-mapping.h | 4 +-
arch/powerpc/include/asm/kvm_book3s_64.h | 4 +-
arch/powerpc/sysdev/dcr.c | 2 +-
arch/s390/include/asm/dma-mapping.h | 2 +-
arch/sparc/mm/init_64.c | 8 ++--
arch/tile/include/asm/dma-mapping.h | 2 +-
arch/unicore32/include/asm/dma-mapping.h | 2 +-
arch/x86/include/asm/archrandom.h | 2 +-
arch/x86/include/asm/dma-mapping.h | 2 +-
arch/x86/include/asm/kvm_para.h | 2 +-
arch/x86/kvm/cpuid.h | 2 +-
arch/x86/kvm/vmx.c | 72 ++++++++++++++--------------
drivers/char/virtio_console.c | 2 +-
drivers/scsi/csiostor/csio_scsi.c | 4 +-
fs/dcache.c | 12 ++---
fs/nfsd/nfs4state.c | 2 +-
include/linux/blkdev.h | 2 +-
include/linux/ide.h | 2 +-
include/linux/kgdb.h | 2 +-
include/linux/mfd/db8500-prcmu.h | 2 +-
include/linux/mm.h | 2 +-
include/linux/power_supply.h | 8 ++--
include/linux/ssb/ssb_driver_extif.h | 2 +-
include/linux/ssb/ssb_driver_gige.h | 16 +++----
include/sound/soc.h | 4 +-
kernel/rcu/tree_plugin.h | 4 +-
kernel/sched/auto_group.h | 2 +-
kernel/sched/completion.c | 16 ++++---
kernel/trace/ftrace.c | 10 ++--
mm/slub.c | 12 ++---
net/bridge/br_private.h | 2 +-
net/ipv4/netfilter/ipt_ah.c | 2 +-
net/netfilter/ipset/ip_set_hash_ip.c | 8 ++--
net/netfilter/ipset/ip_set_hash_ipmark.c | 8 ++--
net/netfilter/ipset/ip_set_hash_ipport.c | 8 ++--
net/netfilter/ipset/ip_set_hash_ipportip.c | 8 ++--
net/netfilter/ipset/ip_set_hash_ipportnet.c | 8 ++--
net/netfilter/ipset/ip_set_hash_net.c | 8 ++--
net/netfilter/ipset/ip_set_hash_netiface.c | 8 ++--
net/netfilter/ipset/ip_set_hash_netport.c | 8 ++--
net/netfilter/ipset/ip_set_hash_netportnet.c | 8 ++--
net/netfilter/xt_connlimit.c | 2 +-
net/netfilter/xt_hashlimit.c | 2 +-
net/netfilter/xt_ipcomp.c | 2 +-
security/apparmor/file.c | 8 ++--
security/apparmor/policy.c | 10 ++--
sound/soc/codecs/wm5100-tables.c | 12 ++---
55 files changed, 178 insertions(+), 176 deletions(-)
--
2.1.2
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 06/25] powerpc: Use bool function return values of true/false not 1/0
2015-03-30 23:45 [PATCH 00/25] treewide: Use bool function return values of true/false not 1/0 Joe Perches
@ 2015-03-30 23:46 ` Joe Perches
2015-03-31 1:49 ` Benjamin Herrenschmidt
2015-03-31 0:07 ` [PATCH 00/25] treewide: " Casey Schaufler
1 sibling, 1 reply; 6+ messages in thread
From: Joe Perches @ 2015-03-30 23:46 UTC (permalink / raw)
To: linux-kernel, Alexander Graf, Gleb Natapov, Paolo Bonzini
Cc: kvm, kvm-ppc, Paul Mackerras, linuxppc-dev
Use the normal return values for bool functions
Signed-off-by: Joe Perches <joe@perches.com>
---
arch/powerpc/include/asm/dcr-native.h | 2 +-
arch/powerpc/include/asm/dma-mapping.h | 4 ++--
arch/powerpc/include/asm/kvm_book3s_64.h | 4 ++--
arch/powerpc/sysdev/dcr.c | 2 +-
4 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/powerpc/include/asm/dcr-native.h b/arch/powerpc/include/asm/dcr-native.h
index 7d2e623..4efc11d 100644
--- a/arch/powerpc/include/asm/dcr-native.h
+++ b/arch/powerpc/include/asm/dcr-native.h
@@ -31,7 +31,7 @@ typedef struct {
static inline bool dcr_map_ok_native(dcr_host_native_t host)
{
- return 1;
+ return true;
}
#define dcr_map_native(dev, dcr_n, dcr_c) \
diff --git a/arch/powerpc/include/asm/dma-mapping.h b/arch/powerpc/include/asm/dma-mapping.h
index 894d538..9103687 100644
--- a/arch/powerpc/include/asm/dma-mapping.h
+++ b/arch/powerpc/include/asm/dma-mapping.h
@@ -191,11 +191,11 @@ static inline bool dma_capable(struct device *dev, dma_addr_t addr, size_t size)
struct dev_archdata *sd = &dev->archdata;
if (sd->max_direct_dma_addr && addr + size > sd->max_direct_dma_addr)
- return 0;
+ return false;
#endif
if (!dev->dma_mask)
- return 0;
+ return false;
return addr + size - 1 <= *dev->dma_mask;
}
diff --git a/arch/powerpc/include/asm/kvm_book3s_64.h b/arch/powerpc/include/asm/kvm_book3s_64.h
index 2d81e20..2a244bf 100644
--- a/arch/powerpc/include/asm/kvm_book3s_64.h
+++ b/arch/powerpc/include/asm/kvm_book3s_64.h
@@ -335,7 +335,7 @@ static inline bool hpte_read_permission(unsigned long pp, unsigned long key)
{
if (key)
return PP_RWRX <= pp && pp <= PP_RXRX;
- return 1;
+ return true;
}
static inline bool hpte_write_permission(unsigned long pp, unsigned long key)
@@ -373,7 +373,7 @@ static inline bool slot_is_aligned(struct kvm_memory_slot *memslot,
unsigned long mask = (pagesize >> PAGE_SHIFT) - 1;
if (pagesize <= PAGE_SIZE)
- return 1;
+ return true;
return !(memslot->base_gfn & mask) && !(memslot->npages & mask);
}
diff --git a/arch/powerpc/sysdev/dcr.c b/arch/powerpc/sysdev/dcr.c
index 2d8a101..121e26f 100644
--- a/arch/powerpc/sysdev/dcr.c
+++ b/arch/powerpc/sysdev/dcr.c
@@ -54,7 +54,7 @@ bool dcr_map_ok_generic(dcr_host_t host)
else if (host.type == DCR_HOST_MMIO)
return dcr_map_ok_mmio(host.host.mmio);
else
- return 0;
+ return false;
}
EXPORT_SYMBOL_GPL(dcr_map_ok_generic);
--
2.1.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 06/25] powerpc: Use bool function return values of true/false not 1/0
2015-03-30 23:46 ` [PATCH 06/25] powerpc: " Joe Perches
@ 2015-03-31 1:49 ` Benjamin Herrenschmidt
2015-03-31 1:57 ` Joe Perches
0 siblings, 1 reply; 6+ messages in thread
From: Benjamin Herrenschmidt @ 2015-03-31 1:49 UTC (permalink / raw)
To: Joe Perches
Cc: kvm, Gleb Natapov, linux-kernel, kvm-ppc, Alexander Graf,
Paul Mackerras, Paolo Bonzini, linuxppc-dev
On Mon, 2015-03-30 at 16:46 -0700, Joe Perches wrote:
> Use the normal return values for bool functions
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Should we merge it or will you ?
Cheers,
Ben.
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> arch/powerpc/include/asm/dcr-native.h | 2 +-
> arch/powerpc/include/asm/dma-mapping.h | 4 ++--
> arch/powerpc/include/asm/kvm_book3s_64.h | 4 ++--
> arch/powerpc/sysdev/dcr.c | 2 +-
> 4 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/powerpc/include/asm/dcr-native.h b/arch/powerpc/include/asm/dcr-native.h
> index 7d2e623..4efc11d 100644
> --- a/arch/powerpc/include/asm/dcr-native.h
> +++ b/arch/powerpc/include/asm/dcr-native.h
> @@ -31,7 +31,7 @@ typedef struct {
>
> static inline bool dcr_map_ok_native(dcr_host_native_t host)
> {
> - return 1;
> + return true;
> }
>
> #define dcr_map_native(dev, dcr_n, dcr_c) \
> diff --git a/arch/powerpc/include/asm/dma-mapping.h b/arch/powerpc/include/asm/dma-mapping.h
> index 894d538..9103687 100644
> --- a/arch/powerpc/include/asm/dma-mapping.h
> +++ b/arch/powerpc/include/asm/dma-mapping.h
> @@ -191,11 +191,11 @@ static inline bool dma_capable(struct device *dev, dma_addr_t addr, size_t size)
> struct dev_archdata *sd = &dev->archdata;
>
> if (sd->max_direct_dma_addr && addr + size > sd->max_direct_dma_addr)
> - return 0;
> + return false;
> #endif
>
> if (!dev->dma_mask)
> - return 0;
> + return false;
>
> return addr + size - 1 <= *dev->dma_mask;
> }
> diff --git a/arch/powerpc/include/asm/kvm_book3s_64.h b/arch/powerpc/include/asm/kvm_book3s_64.h
> index 2d81e20..2a244bf 100644
> --- a/arch/powerpc/include/asm/kvm_book3s_64.h
> +++ b/arch/powerpc/include/asm/kvm_book3s_64.h
> @@ -335,7 +335,7 @@ static inline bool hpte_read_permission(unsigned long pp, unsigned long key)
> {
> if (key)
> return PP_RWRX <= pp && pp <= PP_RXRX;
> - return 1;
> + return true;
> }
>
> static inline bool hpte_write_permission(unsigned long pp, unsigned long key)
> @@ -373,7 +373,7 @@ static inline bool slot_is_aligned(struct kvm_memory_slot *memslot,
> unsigned long mask = (pagesize >> PAGE_SHIFT) - 1;
>
> if (pagesize <= PAGE_SIZE)
> - return 1;
> + return true;
> return !(memslot->base_gfn & mask) && !(memslot->npages & mask);
> }
>
> diff --git a/arch/powerpc/sysdev/dcr.c b/arch/powerpc/sysdev/dcr.c
> index 2d8a101..121e26f 100644
> --- a/arch/powerpc/sysdev/dcr.c
> +++ b/arch/powerpc/sysdev/dcr.c
> @@ -54,7 +54,7 @@ bool dcr_map_ok_generic(dcr_host_t host)
> else if (host.type == DCR_HOST_MMIO)
> return dcr_map_ok_mmio(host.host.mmio);
> else
> - return 0;
> + return false;
> }
> EXPORT_SYMBOL_GPL(dcr_map_ok_generic);
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 06/25] powerpc: Use bool function return values of true/false not 1/0
2015-03-31 1:49 ` Benjamin Herrenschmidt
@ 2015-03-31 1:57 ` Joe Perches
0 siblings, 0 replies; 6+ messages in thread
From: Joe Perches @ 2015-03-31 1:57 UTC (permalink / raw)
To: Benjamin Herrenschmidt
Cc: kvm, Gleb Natapov, linux-kernel, kvm-ppc, Alexander Graf,
Paul Mackerras, Paolo Bonzini, linuxppc-dev
On Tue, 2015-03-31 at 12:49 +1100, Benjamin Herrenschmidt wrote:
> On Mon, 2015-03-30 at 16:46 -0700, Joe Perches wrote:
> > Use the normal return values for bool functions
>
> Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>
> Should we merge it or will you ?
Hey Ben.
I don't merge stuff. I just send patches.
So, it'll be better if you do it.
I'll resend whatever doesn't get picked up in
the next couple months on to Andrew Morton.
cheers. Joe
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 00/25] treewide: Use bool function return values of true/false not 1/0
2015-03-30 23:45 [PATCH 00/25] treewide: Use bool function return values of true/false not 1/0 Joe Perches
2015-03-30 23:46 ` [PATCH 06/25] powerpc: " Joe Perches
@ 2015-03-31 0:07 ` Casey Schaufler
2015-03-31 0:14 ` Joe Perches
1 sibling, 1 reply; 6+ messages in thread
From: Casey Schaufler @ 2015-03-31 0:07 UTC (permalink / raw)
To: Joe Perches, linux-kernel, linux-arm-kernel, kvmarm, kvm,
linux-omap, kvm-ppc, virtualization, linux-fsdevel, linux-nfs,
linux-ide, kgdb-bugreport, linux-mm, linux-pm, netdev, alsa-devel,
bridge, netfilter-devel, coreteam, patches
Cc: linux-s390, linux-ia64, linux-scsi, linux-mips, linux-hexagon,
linux-security-module, sparclinux, linuxppc-dev
On 3/30/2015 4:45 PM, Joe Perches wrote:
> Joe Perches (25):
> arm: Use bool function return values of true/false not 1/0
> arm64: Use bool function return values of true/false not 1/0
> hexagon: Use bool function return values of true/false not 1/0
> ia64: Use bool function return values of true/false not 1/0
> mips: Use bool function return values of true/false not 1/0
> powerpc: Use bool function return values of true/false not 1/0
> s390: Use bool function return values of true/false not 1/0
> sparc: Use bool function return values of true/false not 1/0
> tile: Use bool function return values of true/false not 1/0
> unicore32: Use bool function return values of true/false not 1/0
> x86: Use bool function return values of true/false not 1/0
> virtio_console: Use bool function return values of true/false not 1/0
> csiostor: Use bool function return values of true/false not 1/0
> dcache: Use bool function return values of true/false not 1/0
> nfsd: nfs4state: Use bool function return values of true/false not 1/0
> include/linux: Use bool function return values of true/false not 1/0
> sound: Use bool function return values of true/false not 1/0
> rcu: tree_plugin: Use bool function return values of true/false not 1/0
> sched: Use bool function return values of true/false not 1/0
> ftrace: Use bool function return values of true/false not 1/0
> slub: Use bool function return values of true/false not 1/0
> bridge: Use bool function return values of true/false not 1/0
> netfilter: Use bool function return values of true/false not 1/0
> security: Use bool function return values of true/false not 1/0
> sound: wm5100-tables: Use bool function return values of true/false not 1/0
>
> arch/arm/include/asm/dma-mapping.h | 8 ++--
> arch/arm/include/asm/kvm_emulate.h | 2 +-
> arch/arm/mach-omap2/powerdomain.c | 14 +++---
> arch/arm64/include/asm/dma-mapping.h | 2 +-
> arch/hexagon/include/asm/dma-mapping.h | 2 +-
> arch/ia64/include/asm/dma-mapping.h | 2 +-
> arch/mips/include/asm/dma-mapping.h | 2 +-
> arch/powerpc/include/asm/dcr-native.h | 2 +-
> arch/powerpc/include/asm/dma-mapping.h | 4 +-
> arch/powerpc/include/asm/kvm_book3s_64.h | 4 +-
> arch/powerpc/sysdev/dcr.c | 2 +-
> arch/s390/include/asm/dma-mapping.h | 2 +-
> arch/sparc/mm/init_64.c | 8 ++--
> arch/tile/include/asm/dma-mapping.h | 2 +-
> arch/unicore32/include/asm/dma-mapping.h | 2 +-
> arch/x86/include/asm/archrandom.h | 2 +-
> arch/x86/include/asm/dma-mapping.h | 2 +-
> arch/x86/include/asm/kvm_para.h | 2 +-
> arch/x86/kvm/cpuid.h | 2 +-
> arch/x86/kvm/vmx.c | 72 ++++++++++++++--------------
> drivers/char/virtio_console.c | 2 +-
> drivers/scsi/csiostor/csio_scsi.c | 4 +-
> fs/dcache.c | 12 ++---
> fs/nfsd/nfs4state.c | 2 +-
> include/linux/blkdev.h | 2 +-
> include/linux/ide.h | 2 +-
> include/linux/kgdb.h | 2 +-
> include/linux/mfd/db8500-prcmu.h | 2 +-
> include/linux/mm.h | 2 +-
> include/linux/power_supply.h | 8 ++--
> include/linux/ssb/ssb_driver_extif.h | 2 +-
> include/linux/ssb/ssb_driver_gige.h | 16 +++----
> include/sound/soc.h | 4 +-
> kernel/rcu/tree_plugin.h | 4 +-
> kernel/sched/auto_group.h | 2 +-
> kernel/sched/completion.c | 16 ++++---
> kernel/trace/ftrace.c | 10 ++--
> mm/slub.c | 12 ++---
> net/bridge/br_private.h | 2 +-
> net/ipv4/netfilter/ipt_ah.c | 2 +-
> net/netfilter/ipset/ip_set_hash_ip.c | 8 ++--
> net/netfilter/ipset/ip_set_hash_ipmark.c | 8 ++--
> net/netfilter/ipset/ip_set_hash_ipport.c | 8 ++--
> net/netfilter/ipset/ip_set_hash_ipportip.c | 8 ++--
> net/netfilter/ipset/ip_set_hash_ipportnet.c | 8 ++--
> net/netfilter/ipset/ip_set_hash_net.c | 8 ++--
> net/netfilter/ipset/ip_set_hash_netiface.c | 8 ++--
> net/netfilter/ipset/ip_set_hash_netport.c | 8 ++--
> net/netfilter/ipset/ip_set_hash_netportnet.c | 8 ++--
> net/netfilter/xt_connlimit.c | 2 +-
> net/netfilter/xt_hashlimit.c | 2 +-
> net/netfilter/xt_ipcomp.c | 2 +-
> security/apparmor/file.c | 8 ++--
> security/apparmor/policy.c | 10 ++--
> sound/soc/codecs/wm5100-tables.c | 12 ++---
Why, and why these in particular?
> 55 files changed, 178 insertions(+), 176 deletions(-)
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 00/25] treewide: Use bool function return values of true/false not 1/0
2015-03-31 0:07 ` [PATCH 00/25] treewide: " Casey Schaufler
@ 2015-03-31 0:14 ` Joe Perches
0 siblings, 0 replies; 6+ messages in thread
From: Joe Perches @ 2015-03-31 0:14 UTC (permalink / raw)
To: Casey Schaufler
Cc: linux-mips, alsa-devel, patches, linux-ia64, kvm, kgdb-bugreport,
virtualization, linux-mm, sparclinux, kvmarm, linux-s390,
linux-scsi, linux-hexagon, bridge, coreteam, linux-pm, kvm-ppc,
linux-omap, linux-arm-kernel, linux-nfs, linux-ide, netdev,
linux-kernel, linux-security-module, netfilter-devel,
linux-fsdevel, linuxppc-dev
On Mon, 2015-03-30 at 17:07 -0700, Casey Schaufler wrote:
> On 3/30/2015 4:45 PM, Joe Perches wrote:
> > Joe Perches (25):
> > arm: Use bool function return values of true/false not 1/0
[etc...]
> Why, and why these in particular?
bool functions are probably better returning
bool values instead of 1 and 0.
Especially when the functions intermix returning
returning 1/0 and true/false.
(there are only a couple of those though)
These are all the remaining instances in the
kernel tree.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-03-31 1:57 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-30 23:45 [PATCH 00/25] treewide: Use bool function return values of true/false not 1/0 Joe Perches
2015-03-30 23:46 ` [PATCH 06/25] powerpc: " Joe Perches
2015-03-31 1:49 ` Benjamin Herrenschmidt
2015-03-31 1:57 ` Joe Perches
2015-03-31 0:07 ` [PATCH 00/25] treewide: " Casey Schaufler
2015-03-31 0:14 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).