From: Daniel Axtens <dja@axtens.net>
To: linuxppc-dev@lists.ozlabs.org
Cc: Daniel Axtens <dja@axtens.net>
Subject: [PATCH v2 00/19] Refactor PCI controller operations
Date: Tue, 31 Mar 2015 16:00:38 +1100 [thread overview]
Message-ID: <1427778057-9505-1-git-send-email-dja@axtens.net> (raw)
This patch set moves some PCI controller operations out of ppc_md and
into a new pci_controller_ops struct.
This is desirable for systems with more than one type of PCI
controller. In particular, it's intended that this new interface will
be used by the CXL (aka CAPI) driver.
The design tries to balance a desire to avoid having yet another
abstraction layer with a desire to make it easy for vendor kernels to
pull in as little or as much as they are comfortable with.
To this end, it's in 3 main parts:
1) Set up the pci_controller_ops structure. For each function we add
to the structure, set up a shim that calls the controller_ops
function if it exists, or the ppc_md function otherwise. Modify
callsites to use the shims.
2) Move each affected platform over from using ppc_md to using the
controller_ops structure.
3) Take out the shims and the ppc_md entries. Modify the callsites to
use the controller_ops calls.
MSI and some legacy functions have been deliberately deferred, and
will be to be tackled at a later point.
The set has been build tested for PowerNV, pSeries, Power Mac, Maple,
Cell, PaSemi and Corenet 64 (for fsl_pci). It builds at every point in
the series.
The set depends on mpe's two recent cleanup patches to remove powernv
RTAS support [1] and drop celleb [2].
Thanks for feedback from mpe, there is one functional change since v1,
and a number of cosmetic ones.
Functionally:
- A mistake was made regarding in fsl_pci/swiotlb. I though that
setting ppc_swiotlb_enable in fsl_pci.c couldn't have an effect,
and removed it in patch #4. This was wrong. Drop the offending
patch. In the patch that ports fsl_pci/swiotlb to the new
structure, move the hook around so that it always has the correct
value.
Cosmetically:
- Prefer "phb" over "hose" whenever possible.
- Drop an unnecessary renaming patch. (prev #3)
- Squash all the shim removal.
- Squash the creation of the struct with the addition of the first
member.
- Better commit messages. (Thanks sfr & mpe)
- Shims now have names that (where possible) match the ppc_md names,
rather than the new, non-namespaced names.
The series has also been rebased onto -rc6; no changes were necessary.
The full breakdown of the patches is as follows:
Patches 1 - 3: minor necessary cleanups
Patches 4 - 9: Introduce struct and shims
Patches 10 - 17: Platform specific migrations
Patch 18: Remove shims
Patch 19: Final cleanup
Daniel Axtens (19):
powerpc: move find_and_init_phbs() to pSeries specific code
powerpc/powermac: move pmac_pci_probe_mode from setup.c to pci.c
powerpc: pcibios_enable_device_hook: return bool rather than int
powerpc: Create pci_controller_ops.dma_dev_setup and shims
powerpc: Create pci_controller_ops.dma_bus_setup and shim
powerpc: Create pci_controller_ops.probe_mode and shim
powerpc: Create pci_controller_ops.enable_device_hook and shim
powerpc: Create pci_controller_ops.window_alignment and shim
powerpc: Create pci_controller_ops.reset_secondary_bus and shim
powerpc: dart_iommu: optionally populate controller_ops on init
powerpc/powermac: Move controller ops from ppc_md to controller_ops
powerpc/pseries: Move controller ops from ppc_md to controller_ops
powerpc/powernv: Move controller ops from ppc_md to controller_ops
powerpc/pasemi: Move controller ops from ppc_md to controller_ops
powerpc/maple: Move controller ops from ppc_md to controller_ops
powerpc: fsl_pci, swiotlb: Move controller ops from ppc_md to
controller_ops
powerpc/cell: Move controller ops from ppc_md to controller_ops
powerpc: Remove shims for pci_controller_ops operations
powerpc: dart_iommu: Remove check for controller_ops == NULL case
arch/powerpc/include/asm/iommu.h | 3 +-
arch/powerpc/include/asm/machdep.h | 14 --------
arch/powerpc/include/asm/pci-bridge.h | 19 +++++++++++
arch/powerpc/include/asm/pci.h | 2 +-
arch/powerpc/include/asm/ppc-pci.h | 3 --
arch/powerpc/kernel/dma-swiotlb.c | 11 +++---
arch/powerpc/kernel/pci-common.c | 35 ++++++++++++-------
arch/powerpc/kernel/pci-hotplug.c | 7 ++--
arch/powerpc/kernel/pci_of_scan.c | 7 ++--
arch/powerpc/kernel/rtas_pci.c | 47 -------------------------
arch/powerpc/platforms/cell/cell.h | 24 +++++++++++++
arch/powerpc/platforms/cell/iommu.c | 7 ++--
arch/powerpc/platforms/cell/setup.c | 5 +++
arch/powerpc/platforms/maple/maple.h | 2 ++
arch/powerpc/platforms/maple/pci.c | 4 +++
arch/powerpc/platforms/maple/setup.c | 2 +-
arch/powerpc/platforms/pasemi/iommu.c | 6 ++--
arch/powerpc/platforms/pasemi/pasemi.h | 1 +
arch/powerpc/platforms/pasemi/pci.c | 5 +++
arch/powerpc/platforms/powermac/pci.c | 38 ++++++++++++++++++---
arch/powerpc/platforms/powermac/pmac.h | 3 +-
arch/powerpc/platforms/powermac/setup.c | 22 +-----------
arch/powerpc/platforms/powernv/pci-ioda.c | 15 ++++----
arch/powerpc/platforms/powernv/pci-p5ioc2.c | 1 +
arch/powerpc/platforms/powernv/pci.c | 5 ++-
arch/powerpc/platforms/powernv/powernv.h | 2 ++
arch/powerpc/platforms/pseries/iommu.c | 9 ++---
arch/powerpc/platforms/pseries/pseries.h | 2 ++
arch/powerpc/platforms/pseries/setup.c | 53 ++++++++++++++++++++++++++++-
arch/powerpc/sysdev/dart_iommu.c | 10 +++---
arch/powerpc/sysdev/fsl_pci.c | 19 +++++++++++
31 files changed, 244 insertions(+), 139 deletions(-)
create mode 100644 arch/powerpc/platforms/cell/cell.h
--
2.1.4
next reply other threads:[~2015-03-31 5:01 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-31 5:00 Daniel Axtens [this message]
2015-03-31 5:00 ` [PATCH v2 01/19] powerpc: move find_and_init_phbs() to pSeries specific code Daniel Axtens
2015-03-31 5:00 ` [PATCH v2 02/19] powerpc/powermac: move pmac_pci_probe_mode from setup.c to pci.c Daniel Axtens
2015-03-31 5:00 ` [PATCH v2 03/19] powerpc: pcibios_enable_device_hook: return bool rather than int Daniel Axtens
2015-03-31 5:00 ` [PATCH v2 04/19] powerpc: Create pci_controller_ops.dma_dev_setup and shim Daniel Axtens
2015-04-02 14:13 ` Arnd Bergmann
2015-04-07 0:31 ` Daniel Axtens
2015-04-07 7:44 ` Arnd Bergmann
2015-04-08 3:31 ` Michael Ellerman
2015-03-31 5:00 ` [PATCH v2 05/19] powerpc: Create pci_controller_ops.dma_bus_setup " Daniel Axtens
2015-03-31 5:00 ` [PATCH v2 06/19] powerpc: Create pci_controller_ops.probe_mode " Daniel Axtens
2015-03-31 5:00 ` [PATCH v2 07/19] powerpc: Create pci_controller_ops.enable_device_hook " Daniel Axtens
2015-03-31 5:00 ` [PATCH v2 08/19] powerpc: Create pci_controller_ops.window_alignment " Daniel Axtens
2015-03-31 5:00 ` [PATCH v2 09/19] powerpc: Create pci_controller_ops.reset_secondary_bus " Daniel Axtens
2015-03-31 5:00 ` [PATCH v2 10/19] powerpc: dart_iommu: optionally populate controller_ops on init Daniel Axtens
2015-03-31 5:00 ` [PATCH v2 11/19] powerpc/powermac: Move controller ops from ppc_md to controller_ops Daniel Axtens
2015-03-31 5:00 ` [PATCH v2 12/19] powerpc/pseries: " Daniel Axtens
2015-04-02 3:21 ` [PATCH v3 " Daniel Axtens
2015-03-31 5:00 ` [PATCH v2 13/19] powerpc/powernv: " Daniel Axtens
2015-03-31 5:00 ` [PATCH v2 14/19] powerpc/pasemi: " Daniel Axtens
2015-03-31 5:00 ` [PATCH v2 15/19] powerpc/maple: " Daniel Axtens
2015-03-31 5:00 ` [PATCH v2 16/19] powerpc: fsl_pci, swiotlb: " Daniel Axtens
2015-04-10 0:11 ` [PATCH v3 " Daniel Axtens
2015-04-10 1:28 ` Scott Wood
2015-04-10 2:36 ` Daniel Axtens
2015-04-10 3:15 ` [PATCH v4 " Daniel Axtens
2015-04-10 3:18 ` Scott Wood
2015-03-31 5:00 ` [PATCH v2 17/19] powerpc/cell: " Daniel Axtens
2015-03-31 5:00 ` [PATCH v2 18/19] powerpc: Remove shims for pci_controller_ops operations Daniel Axtens
2015-03-31 5:00 ` [PATCH v2 19/19] powerpc: dart_iommu: Remove check for controller_ops == NULL case Daniel Axtens
2015-04-07 7:51 ` [PATCH v2 00/19] Refactor PCI controller operations Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427778057-9505-1-git-send-email-dja@axtens.net \
--to=dja@axtens.net \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).