From: Paul Bolle <pebolle@tiscali.nl>
To: "Filip Brozović" <fbrozovic@gmail.com>
Cc: scottwood@freescale.com, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] powerpc/83xx: add support for mpc8306
Date: Fri, 03 Apr 2015 23:31:00 +0200 [thread overview]
Message-ID: <1428096660.7898.27.camel@x220> (raw)
In-Reply-To: <551E8B65.5010400@gmail.com>
On Fri, 2015-04-03 at 14:45 +0200, Filip Brozović wrote:
> The idea was that boards in the Kconfig file would select these symbols
> in order to enable support for the 8306. I mainly wanted to get this
> patch into mainline in order to make kernel maintenance for a couple of
> custom in-house developed boards easier.
The trouble with this patch is that, without some follow up patch, it
adds Kconfig symbols and preprocessor checks that are pointless for
mainline. I think we should not do that. (I'm also not sure how having
those bits in mainline substantially benefits out of tree development.)
But if you would put this in a series that also adds the code using
these bits, than I'd have no reason to object (and neither would, I
guess, the bots checking the tree for issues like that).
Thanks,
Paul Bolle
prev parent reply other threads:[~2015-04-03 21:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-03 10:44 [PATCH v2] powerpc/83xx: add support for mpc8306 Filip Brozovic
2015-04-03 12:01 ` Paul Bolle
2015-04-03 12:45 ` Filip Brozović
2015-04-03 20:24 ` Scott Wood
2015-04-08 12:24 ` Filip Brozović
2015-04-03 21:31 ` Paul Bolle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1428096660.7898.27.camel@x220 \
--to=pebolle@tiscali.nl \
--cc=fbrozovic@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).