linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: Shengzhou Liu <Shengzhou.Liu@freescale.com>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 3/4] powerpc/fsl-booke: Add T1024 RDB board support
Date: Tue, 7 Apr 2015 18:45:26 -0500	[thread overview]
Message-ID: <1428450326.22867.486.camel@freescale.com> (raw)
In-Reply-To: <1428057350-33553-3-git-send-email-Shengzhou.Liu@freescale.com>

On Fri, 2015-04-03 at 18:35 +0800, Shengzhou Liu wrote:

> +		board-control@2,0 {
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +			compatible = "fsl,t1024-cpld", "fsl,deepsleep-cpld";

No "fsl,deepsleep-cpld".  Just have the driver recognize the compatibles
for the chips that have deep sleep.

Even if you were to do this, it would need to be documented in a
binding, and you'd need to be more specific about what CPLD family
you're talking about.

> +		tdma: ucc@2000 {
> +			compatible = "fsl,ucc-tdm";
> +			rx-clock-name = "clk8";
> +			tx-clock-name = "clk9";
> +			fsl,rx-sync-clock = "rsync_pin";
> +			fsl,tx-sync-clock = "tsync_pin";
> +			fsl,tx-timeslot = <0xfffffffe>;
> +			fsl,rx-timeslot = <0xfffffffe>;
> +			fsl,tdm-framer-type = "e1";
> +			fsl,tdm-mode = "normal";
> +			fsl,tdm-id = <0>;
> +			fsl,siram-entry-id = <0>;
> +		};

Binding?

-Scott

  reply	other threads:[~2015-04-07 23:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-03 10:35 [PATCH 1/4] powerpc/fsl-booke: Add device tree support for T1024/T1023 SoC Shengzhou Liu
2015-04-03 10:35 ` [PATCH 2/4] powerpc/fsl-booke: Add T1024 QDS board support Shengzhou Liu
2015-04-03 10:35 ` [PATCH 3/4] powerpc/fsl-booke: Add T1024 RDB " Shengzhou Liu
2015-04-07 23:45   ` Scott Wood [this message]
2015-04-03 10:35 ` [PATCH 4/4] powerpc/fsl-booke: Add T1023 " Shengzhou Liu
2015-04-07 23:49 ` [PATCH 1/4] powerpc/fsl-booke: Add device tree support for T1024/T1023 SoC Scott Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1428450326.22867.486.camel@freescale.com \
    --to=scottwood@freescale.com \
    --cc=Shengzhou.Liu@freescale.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).