From: Scott Wood <scottwood@freescale.com>
To: Shengzhou Liu <Shengzhou.Liu@freescale.com>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 1/4] powerpc/fsl-booke: Add device tree support for T1024/T1023 SoC
Date: Tue, 7 Apr 2015 18:49:09 -0500 [thread overview]
Message-ID: <1428450549.22867.487.camel@freescale.com> (raw)
In-Reply-To: <1428057350-33553-1-git-send-email-Shengzhou.Liu@freescale.com>
On Fri, 2015-04-03 at 18:35 +0800, Shengzhou Liu wrote:
> + rcpm: global-utilities@e2000 {
> + compatible = "fsl,t1023-rcpm", "fsl,qoriq-rcpm-2.0";
> + reg = <0xe2000 0x1000>;
> + };
> +
> + sfp: sfp@e8000 {
> + compatible = "fsl,t1023-sfp";
> + reg = <0xe8000 0x1000>;
> + };
> +
> + serdes: serdes@ea000 {
> + compatible = "fsl,t1023-serdes";
> + reg = <0xea000 0x4000>;
> + };
Consistent whitespace please. Just one space after "reg".
> +/include/ "qoriq-esdhc-0.dtsi"
> + sdhc@114000 {
> + compatible = "fsl,t1023-esdhc", "fsl,esdhc";
> + fsl,iommu-parent = <&pamu0>;
> + fsl,liodn-reg = <&guts 0x530>; /* eSDHCLIODNR */
> + sdhci,auto-cmd12;
> + no-1-8-v;
> + sleep = <&rcpm 0x00000080>;
Get rid of "sleep" -- it's undocumented copy-and-paste from something
that was never finished.
-Scott
next prev parent reply other threads:[~2015-04-07 23:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-03 10:35 [PATCH 1/4] powerpc/fsl-booke: Add device tree support for T1024/T1023 SoC Shengzhou Liu
2015-04-03 10:35 ` [PATCH 2/4] powerpc/fsl-booke: Add T1024 QDS board support Shengzhou Liu
2015-04-03 10:35 ` [PATCH 3/4] powerpc/fsl-booke: Add T1024 RDB " Shengzhou Liu
2015-04-07 23:45 ` Scott Wood
2015-04-03 10:35 ` [PATCH 4/4] powerpc/fsl-booke: Add T1023 " Shengzhou Liu
2015-04-07 23:49 ` Scott Wood [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-01-29 7:52 [PATCH 1/4] powerpc/fsl-booke: Add device tree support for T1024/T1023 SoC Shengzhou Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1428450549.22867.487.camel@freescale.com \
--to=scottwood@freescale.com \
--cc=Shengzhou.Liu@freescale.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).