Re: [PATCH 1/4 v2] powerpc/fsl-booke: Add device tree support for T1024/T1023 SoC

[Scott Wood <scottwood@freescale.com>]

On Wed, 2015-04-08 at 18:46 +0800, Shengzhou Liu wrote:
> +	clockgen: global-utilities@e1000 {
> +		compatible = "fsl,t1023-clockgen", "fsl,qoriq-clockgen-2.0",
> +				   "fixed-clock";
> +		reg = <0xe1000 0x1000>;
> +		clock-output-names = "sysclk";
> +		#clock-cells = <0>;

Why aren't you using qoriq-clockgen2.dtsi?  Where is ranges?

We've been putting the sysclk in its own node, though even after reading
the discussion in http://patchwork.ozlabs.org/patch/274134/ and
http://patchwork.ozlabs.org/patch/290226/ I still don't know what was
wrong with the unified approach.


> +		data-only@0 {
> +			compatible = "fsl,qe-muram-data",
> +			"fsl,cpm-muram-data";
> +			reg = <0x0 0x6000>;

Whitespace.

-Scott