[v2] dt/bindings: fsl/guts: Added global-utilities compatibles

[v2] dt/bindings: fsl/guts: Added global-utilities compatibles

[Igal.Liberman]

From: Igal Liberman <Igal.Liberman@freescale.com>

v2 - Addressed Scott's feedback

Signed-off-by: Igal Liberman <Igal.Liberman@freescale.com>
---
 .../devicetree/bindings/powerpc/fsl/guts.txt       |    4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/powerpc/fsl/guts.txt b/Documentation/devicetree/bindings/powerpc/fsl/guts.txt
index 7f150b5..69644e6 100644
--- a/Documentation/devicetree/bindings/powerpc/fsl/guts.txt
+++ b/Documentation/devicetree/bindings/powerpc/fsl/guts.txt
@@ -9,6 +9,10 @@ Required properties:
 
  - compatible : Should define the compatible device type for
    global-utilities.
+   Possible compatibles:
+	"fsl,qoriq-device-config-1.0"
+	"fsl,qoriq-device-config-2.0"
+	"fsl,<chip>-device-config"
  - reg : Offset and length of the register set for the device.
 
 Recommended properties:
-- 
1.7.9.5

Re: [v2] dt/bindings: fsl/guts: Added global-utilities compatibles

[Scott Wood]

On Tue, 2015-04-14 at 13:12 +0300, Igal.Liberman wrote:
> From: Igal Liberman <Igal.Liberman@freescale.com>
> 
> v2 - Addressed Scott's feedback
> 
> Signed-off-by: Igal Liberman <Igal.Liberman@freescale.com>
> ---
>  .../devicetree/bindings/powerpc/fsl/guts.txt       |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/powerpc/fsl/guts.txt b/Documentation/devicetree/bindings/powerpc/fsl/guts.txt
> index 7f150b5..69644e6 100644
> --- a/Documentation/devicetree/bindings/powerpc/fsl/guts.txt
> +++ b/Documentation/devicetree/bindings/powerpc/fsl/guts.txt
> @@ -9,6 +9,10 @@ Required properties:
>  
>   - compatible : Should define the compatible device type for
>     global-utilities.
> +   Possible compatibles:
> +	"fsl,qoriq-device-config-1.0"
> +	"fsl,qoriq-device-config-2.0"
> +	"fsl,<chip>-device-config"

fsl,<chip>-guts is also possible on non-corenet chips.

-Scott

RE: [v2] dt/bindings: fsl/guts: Added global-utilities compatibles

[Igal.Liberman]

DQoNClJlZ2FyZHMsDQpJZ2FsIExpYmVybWFuLg0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0t
LS0tDQo+IEZyb206IFdvb2QgU2NvdHQtQjA3NDIxDQo+IFNlbnQ6IFR1ZXNkYXksIEFwcmlsIDE0
LCAyMDE1IDExOjA5IFBNDQo+IFRvOiBMaWJlcm1hbiBJZ2FsLUIzMTk1MA0KPiBDYzogZGV2aWNl
dHJlZUB2Z2VyLmtlcm5lbC5vcmc7IGxpbnV4cHBjLWRldkBsaXN0cy5vemxhYnMub3JnDQo+IFN1
YmplY3Q6IFJlOiBbdjJdIGR0L2JpbmRpbmdzOiBmc2wvZ3V0czogQWRkZWQgZ2xvYmFsLXV0aWxp
dGllcyBjb21wYXRpYmxlcw0KPiANCj4gT24gVHVlLCAyMDE1LTA0LTE0IGF0IDEzOjEyICswMzAw
LCBJZ2FsLkxpYmVybWFuIHdyb3RlOg0KPiA+IEZyb206IElnYWwgTGliZXJtYW4gPElnYWwuTGli
ZXJtYW5AZnJlZXNjYWxlLmNvbT4NCj4gPg0KPiA+IHYyIC0gQWRkcmVzc2VkIFNjb3R0J3MgZmVl
ZGJhY2sNCj4gPg0KPiA+IFNpZ25lZC1vZmYtYnk6IElnYWwgTGliZXJtYW4gPElnYWwuTGliZXJt
YW5AZnJlZXNjYWxlLmNvbT4NCj4gPiAtLS0NCj4gPiAgLi4uL2RldmljZXRyZWUvYmluZGluZ3Mv
cG93ZXJwYy9mc2wvZ3V0cy50eHQgICAgICAgfCAgICA0ICsrKysNCj4gPiAgMSBmaWxlIGNoYW5n
ZWQsIDQgaW5zZXJ0aW9ucygrKQ0KPiA+DQo+ID4gZGlmZiAtLWdpdCBhL0RvY3VtZW50YXRpb24v
ZGV2aWNldHJlZS9iaW5kaW5ncy9wb3dlcnBjL2ZzbC9ndXRzLnR4dA0KPiBiL0RvY3VtZW50YXRp
b24vZGV2aWNldHJlZS9iaW5kaW5ncy9wb3dlcnBjL2ZzbC9ndXRzLnR4dA0KPiA+IGluZGV4IDdm
MTUwYjUuLjY5NjQ0ZTYgMTAwNjQ0DQo+ID4gLS0tIGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVl
L2JpbmRpbmdzL3Bvd2VycGMvZnNsL2d1dHMudHh0DQo+ID4gKysrIGIvRG9jdW1lbnRhdGlvbi9k
ZXZpY2V0cmVlL2JpbmRpbmdzL3Bvd2VycGMvZnNsL2d1dHMudHh0DQo+ID4gQEAgLTksNiArOSwx
MCBAQCBSZXF1aXJlZCBwcm9wZXJ0aWVzOg0KPiA+DQo+ID4gICAtIGNvbXBhdGlibGUgOiBTaG91
bGQgZGVmaW5lIHRoZSBjb21wYXRpYmxlIGRldmljZSB0eXBlIGZvcg0KPiA+ICAgICBnbG9iYWwt
dXRpbGl0aWVzLg0KPiA+ICsgICBQb3NzaWJsZSBjb21wYXRpYmxlczoNCj4gPiArCSJmc2wscW9y
aXEtZGV2aWNlLWNvbmZpZy0xLjAiDQo+ID4gKwkiZnNsLHFvcmlxLWRldmljZS1jb25maWctMi4w
Ig0KPiA+ICsJImZzbCw8Y2hpcD4tZGV2aWNlLWNvbmZpZyINCj4gDQo+IGZzbCw8Y2hpcD4tZ3V0
cyBpcyBhbHNvIHBvc3NpYmxlIG9uIG5vbi1jb3JlbmV0IGNoaXBzLg0KPiANCg0KSSBhZGRlZCBj
b21wYXRpYmxlcyB3aGljaCBhcmUgdXNlZCBmb3IgRk1hbiBDbG9jayBvbmx5Lg0KRG8geW91IHdh
bnQgdG8gYWRkIG90aGVyIGNvbXBhdGlibGVzIHRvbz8gV2hpY2g/IE9yIGp1c3QgbWVudGlvbiB0
aGF0IHRoZSAzIGNvbXBhdGlibGVzIEkndmUgYWRkZWQgZG9lc24ndCBjb3ZlciBhbGwgYXZhaWxh
YmxlIG9wdGlvbnM/DQoNCj4gLVNjb3R0DQo+IA0KDQpJZ2FsDQoNCg==

Re: [v2] dt/bindings: fsl/guts: Added global-utilities compatibles

[Scott Wood]

On Wed, 2015-04-15 at 03:43 -0500, Liberman Igal-B31950 wrote:
> 
> 
> Regards,
> Igal Liberman.
> 
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Tuesday, April 14, 2015 11:09 PM
> > To: Liberman Igal-B31950
> > Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org
> > Subject: Re: [v2] dt/bindings: fsl/guts: Added global-utilities compatibles
> > 
> > On Tue, 2015-04-14 at 13:12 +0300, Igal.Liberman wrote:
> > > From: Igal Liberman <Igal.Liberman@freescale.com>
> > >
> > > v2 - Addressed Scott's feedback
> > >
> > > Signed-off-by: Igal Liberman <Igal.Liberman@freescale.com>
> > > ---
> > >  .../devicetree/bindings/powerpc/fsl/guts.txt       |    4 ++++
> > >  1 file changed, 4 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/powerpc/fsl/guts.txt
> > b/Documentation/devicetree/bindings/powerpc/fsl/guts.txt
> > > index 7f150b5..69644e6 100644
> > > --- a/Documentation/devicetree/bindings/powerpc/fsl/guts.txt
> > > +++ b/Documentation/devicetree/bindings/powerpc/fsl/guts.txt
> > > @@ -9,6 +9,10 @@ Required properties:
> > >
> > >   - compatible : Should define the compatible device type for
> > >     global-utilities.
> > > +   Possible compatibles:
> > > +	"fsl,qoriq-device-config-1.0"
> > > +	"fsl,qoriq-device-config-2.0"
> > > +	"fsl,<chip>-device-config"
> > 
> > fsl,<chip>-guts is also possible on non-corenet chips.
> > 
> 
> I added compatibles which are used for FMan Clock only.
> Do you want to add other compatibles too? Which? Or just mention that the 3 compatibles I've added doesn't cover all available options?

You're changing the binding from one that doesn't list compatibles to
one that does -- so please get all of them.

-Scott