From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-bl2-obe.outbound.protection.outlook.com (mail-bl2on0108.outbound.protection.outlook.com [65.55.169.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id C80BF1A0028 for ; Tue, 21 Apr 2015 09:57:04 +1000 (AEST) Message-ID: <1429574206.4352.53.camel@freescale.com> Subject: Re: [RFC,1/8] soc/fman: Add FMan MURAM support From: Scott Wood To: Liberman Igal-B31950 Date: Mon, 20 Apr 2015 18:56:46 -0500 In-Reply-To: References: <1426050469-12507-1-git-send-email-igal.liberman@freescale.com> <32CF85E2-A8AA-454D-A46F-0E778DAF97ED@kernel.crashing.org> Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Cc: "netdev@vger.kernel.org" , Bucur Madalin-Cristian-B32716 , "linuxppc-dev@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, 2015-04-20 at 03:58 -0500, Liberman Igal-B31950 wrote: > > Regards, > Igal Liberman. > > > -----Original Message----- > > From: Kumar Gala [mailto:galak@kernel.crashing.org] > > Sent: Thursday, March 12, 2015 5:57 PM > > To: Liberman Igal-B31950 > > Cc: linuxppc-dev@lists.ozlabs.org; netdev@vger.kernel.org; linux- > > kernel@vger.kernel.org; Wood Scott-B07421 > > Subject: Re: [RFC,1/8] soc/fman: Add FMan MURAM support > > > > > > On Mar 11, 2015, at 12:07 AM, Igal.Liberman > > wrote: > > > > > From: Igal Liberman > > > > > > Add Frame Manager Multi-User RAM support. > > > > > > Signed-off-by: Igal Liberman > > > --- > > > drivers/soc/fsl/fman/Kconfig | 1 + > > > drivers/soc/fsl/fman/Makefile | 5 +- > > > drivers/soc/fsl/fman/fm_muram.c | 174 > > +++++++++++++++++++++++++++++++ > > > drivers/soc/fsl/fman/inc/fm_muram_ext.h | 98 +++++++++++++++++ > > > 4 files changed, 276 insertions(+), 2 deletions(-) create mode 100644 > > > drivers/soc/fsl/fman/fm_muram.c create mode 100644 > > > drivers/soc/fsl/fman/inc/fm_muram_ext.h > > > > > > > use lib/genalloc instead of rheap > > > > Hi Kumar, > I looked into lib/genalloc allocator. > As far as I see, the genalloc allocator doesn't allow to control the memory alignment when you allocate a chunk of memory. > Two important notes regarding MURAM memory: > - The allocated memory chunks should have specific alignment (might be different in each chunk). > - The allocations must be efficient, we don't want to "waste" MURAM due to alignment issues. If the requirement is that allocations must be size-aligned, use gen_pool_first_fit_order_align. Otherwise, improve genalloc to do what you need. -Scott