From: Scott Wood <scottwood@freescale.com>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: linuxppc-dev@ozlabs.org, sam.mj@au1.ibm.com,
Anton Blanchard <anton@samba.org>
Subject: Re: [PATCH 2/2] powerpc: Disable building the 32-bit VDSO on little endian
Date: Tue, 21 Apr 2015 13:36:49 -0500 [thread overview]
Message-ID: <1429641409.4352.110.camel@freescale.com> (raw)
In-Reply-To: <1429609312-32638-2-git-send-email-mpe@ellerman.id.au>
On Tue, 2015-04-21 at 19:41 +1000, Michael Ellerman wrote:
> diff --git a/arch/powerpc/platforms/Kconfig.cputype b/arch/powerpc/platforms/Kconfig.cputype
> index 12fc443b9d54..1324f589f43a 100644
> --- a/arch/powerpc/platforms/Kconfig.cputype
> +++ b/arch/powerpc/platforms/Kconfig.cputype
> @@ -405,6 +405,16 @@ config PPC_DOORBELL
>
> endmenu
>
> +config VDSO32
> + def_bool y
> + depends on PPC32 || CPU_BIG_ENDIAN
> + help
> + This symbol controls whether we build the 32-bit VDSO. We obviously
> + want to do that if we're building a 32-bit kernel. If we're building
> + a 64-bit kernel then we only want a 32-bit VDSO if we're building for
> + big endian. That is because the only little endian configuration we
> + support is ppc64le which is 64-bit only.
Shouldn't this depend on COMPAT, and COMPAT depend on CPU_BIG_ENDIAN?
-Scott
next prev parent reply other threads:[~2015-04-21 18:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-21 9:41 [PATCH 1/2] powerpc: Little endian should depend on PPC64 Michael Ellerman
2015-04-21 9:41 ` [PATCH 2/2] powerpc: Disable building the 32-bit VDSO on little endian Michael Ellerman
2015-04-21 18:36 ` Scott Wood [this message]
2015-04-22 0:30 ` Michael Ellerman
2015-04-21 22:23 ` Stephen Rothwell
2015-04-21 18:33 ` [PATCH 1/2] powerpc: Little endian should depend on PPC64 Scott Wood
2015-04-22 0:27 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1429641409.4352.110.camel@freescale.com \
--to=scottwood@freescale.com \
--cc=anton@samba.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=sam.mj@au1.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).