linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
To: linuxppc-dev@ozlabs.org
Cc: aik@ozlabs.ru, thuth@redhat.com, nikunj@linux.vnet.ibm.com,
	david@gibson.dropbear.id.au
Subject: [PATCH 1/2] pci-phb: check for the 32-bit overflow
Date: Wed, 22 Apr 2015 16:27:19 +0530	[thread overview]
Message-ID: <1429700240-32373-1-git-send-email-nikunj@linux.vnet.ibm.com> (raw)

With the addition of 64-bit BARS and increase in the mmio address
space, the code was hitting this limit. The memory of pci devices
across the bridges were not accessible due to which the drivers
failed.

Signed-off-by: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
---
 board-qemu/slof/pci-phb.fs | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/board-qemu/slof/pci-phb.fs b/board-qemu/slof/pci-phb.fs
index 529772f..e307d95 100644
--- a/board-qemu/slof/pci-phb.fs
+++ b/board-qemu/slof/pci-phb.fs
@@ -258,7 +258,8 @@ setup-puid
             decode-64 2 / dup >r                \ Decode and calc size/2
             pci-next-mem @ + dup pci-max-mem !  \ and calc max mem address
             dup pci-next-mmio !                 \ which is the same as MMIO base
-            r> + pci-max-mmio !                 \ calc max MMIO address
+            r> + FFFFFFFF min pci-max-mmio !    \ calc max MMIO address and
+                                                \ check the 32-bit boundary
          ENDOF
          3000000 OF                             \ 64-bit memory space?
 	    decode-64 pci-next-mem64 !
-- 
1.8.3.1

             reply	other threads:[~2015-04-22 10:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-22 10:57 Nikunj A Dadhania [this message]
2015-04-23 13:43 ` [PATCH 1/2] pci-phb: check for the 32-bit overflow Thomas Huth
2015-04-24  3:52   ` Nikunj A Dadhania
2015-04-24 10:56     ` Thomas Huth
2015-04-24 11:06       ` Thomas Huth
2015-04-27  5:00         ` Nikunj A Dadhania
2015-04-27  5:41         ` Nikunj A Dadhania
2015-04-27  4:58       ` Nikunj A Dadhania

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1429700240-32373-1-git-send-email-nikunj@linux.vnet.ibm.com \
    --to=nikunj@linux.vnet.ibm.com \
    --cc=aik@ozlabs.ru \
    --cc=david@gibson.dropbear.id.au \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).