From: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
To: linuxppc-dev@ozlabs.org
Cc: aik@ozlabs.ru, thuth@redhat.com, nikunj@linux.vnet.ibm.com,
david@gibson.dropbear.id.au
Subject: [PATCH 2/2] pci: Use Qemu created PCI device nodes
Date: Wed, 22 Apr 2015 16:27:20 +0530 [thread overview]
Message-ID: <1429700240-32373-2-git-send-email-nikunj@linux.vnet.ibm.com> (raw)
PCI Enumeration has been part of SLOF. Now with hotplug code addition
in Qemu, it makes more sense to have this code a one place, i.e. Qemu.
Adding routines to walk through the device nodes created by Qemu. SLOF
will configure the device/bridges and program the BARs for
communicating with the devices.
Signed-off-by: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
---
board-qemu/slof/pci-phb.fs | 44 +++++++++++++++++++++++++++++++++++++++++++-
slof/fs/pci-properties.fs | 6 +++++-
2 files changed, 48 insertions(+), 2 deletions(-)
diff --git a/board-qemu/slof/pci-phb.fs b/board-qemu/slof/pci-phb.fs
index e307d95..30b7443 100644
--- a/board-qemu/slof/pci-phb.fs
+++ b/board-qemu/slof/pci-phb.fs
@@ -283,6 +283,41 @@ setup-puid
THEN
;
+: phb-pci-walk-bridge ( -- )
+ phb-debug? IF ." Calling pci-walk-bridge " pwd cr THEN
+
+ get-node child ?dup 0= IF EXIT THEN \ get and check if we have children
+ BEGIN
+ dup \ Continue as long as there are children
+ WHILE
+ \ Set child node as current node:
+ dup set-node
+ my-space pci-set-slot \ set the slot bit
+ my-space pci-htype@ \ read HEADER-Type
+ 7f and \ Mask bit 7 - multifunction device
+ CASE
+ 0 OF my-space pci-device-setup ENDOF \ | set up the device
+ 1 OF my-space pci-bridge-setup ENDOF \ | set up the bridge
+ dup OF my-space pci-htype@ pci-out ENDOF
+ ENDCASE
+ peer
+ REPEAT drop
+ get-parent set-node
+;
+
+\ Landing routing to probe the popuated device tree
+: phb-pci-probe-bus ( busnr -- )
+ drop phb-pci-walk-bridge
+;
+
+\ Stub routine, as qemu has enumerated, we already have the device
+\ properties set.
+: phb-pci-device-props ( addr -- )
+ dup pci-class-name device-name
+ dup pci-device-assigned-addresses-prop
+ drop
+;
+
\ Scan the child nodes of the pci root node to assign bars, fixup
\ properties etc.
: phb-setup-children
@@ -290,7 +325,14 @@ setup-puid
my-puid TO puid \ Set current puid
phb-parse-ranges
1 TO pci-hotplug-enabled
- 1 0 (probe-pci-host-bridge)
+ s" qemu,phb-enumerated" get-node get-property 0<> IF
+ 1 0 (probe-pci-host-bridge)
+ ELSE
+ 2drop
+ ['] phb-pci-probe-bus TO func-pci-probe-bus
+ ['] phb-pci-device-props TO func-pci-device-props
+ phb-pci-walk-bridge \ PHB device tree is already populated.
+ THEN
r> TO puid \ Restore previous puid
;
phb-setup-children
diff --git a/slof/fs/pci-properties.fs b/slof/fs/pci-properties.fs
index 9efa87e..4f13402 100644
--- a/slof/fs/pci-properties.fs
+++ b/slof/fs/pci-properties.fs
@@ -651,6 +651,8 @@
r> TO pci-device-slots \ and reset the slot array
;
+DEFER func-pci-device-props
+
\ used for an gerneric device set up
\ if a device has no special handling for setup
\ the device file (pci-device_VENDOR_DEVICE.fs) can call
@@ -659,6 +661,8 @@
dup assign-all-device-bars \ calc all BARs
dup pci-set-irq-line \ set the interrupt pin
dup pci-set-capabilities \ set up the capabilities
- dup pci-device-props \ and generate all properties
+ dup func-pci-device-props \ and generate all properties
drop \ forget the config-addr
;
+
+' pci-device-props TO func-pci-device-props
--
1.8.3.1
next reply other threads:[~2015-04-22 10:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-22 10:57 Nikunj A Dadhania [this message]
2015-04-24 19:30 ` [PATCH 2/2] pci: Use Qemu created PCI device nodes Thomas Huth
2015-04-25 7:31 ` Alexey Kardashevskiy
2015-04-25 11:25 ` Benjamin Herrenschmidt
2015-04-27 4:47 ` Nikunj A Dadhania
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1429700240-32373-2-git-send-email-nikunj@linux.vnet.ibm.com \
--to=nikunj@linux.vnet.ibm.com \
--cc=aik@ozlabs.ru \
--cc=david@gibson.dropbear.id.au \
--cc=linuxppc-dev@ozlabs.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).