linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Joakim Tjernlund <joakim.tjernlund@transmode.se>
To: "arnd@arndb.de" <arnd@arndb.de>
Cc: "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH 1/2] sdhci-of-esdhc: Support 8BIT bus width.
Date: Mon, 4 May 2015 21:49:54 +0000	[thread overview]
Message-ID: <1430776194.27859.64.camel@transmode.se> (raw)
In-Reply-To: <1430774247.27859.62.camel@transmode.se>

On Mon, 2015-05-04 at 21:17 +0000, Joakim Tjernlund wrote:
> On Mon, 2015-05-04 at 19:31 +0200, Arnd Bergmann wrote:
> > On Monday 04 May 2015 18:31:31 Joakim Tjernlund wrote:
> > > @@ -252,6 +260,8 @@ static void esdhc_of_platform_init(struct sdhci_h=
ost *host)
> > > =20
> > >         if (vvn > VENDOR_V_22)
> > >                 host->quirks &=3D ~SDHCI_QUIRK_NO_BUSY_IRQ;
> > > +
> > > +       host->mmc->caps |=3D MMC_CAP_8_BIT_DATA;
> > >  }
> > >=20
> >=20
> > Shouldn't this check the "bus-width" property before setting the width?
> >=20
> > There might be an eMMC or SDIO with 4-bit interface connected.
>=20
> This is for an eMMC chip we got and I THINK(this is new to me) that
> this only allows 8 bit negotiation but I might be way off.
> =20
> Anyone knows for sure?

hmm, I need to look some more at this. There is bus-with/8BIT all over mmc =
and I
have probably missed something.

       Jocke

  reply	other threads:[~2015-05-04 21:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-04 16:31 [PATCH 1/2] sdhci-of-esdhc: Support 8BIT bus width Joakim Tjernlund
2015-05-04 16:31 ` [PATCH 2/2] sdhci-of-esdhc: Pre divider starts at 1 Joakim Tjernlund
2015-05-04 17:31 ` [PATCH 1/2] sdhci-of-esdhc: Support 8BIT bus width Arnd Bergmann
2015-05-04 21:17   ` Joakim Tjernlund
2015-05-04 21:49     ` Joakim Tjernlund [this message]
2015-05-05 10:03     ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1430776194.27859.64.camel@transmode.se \
    --to=joakim.tjernlund@transmode.se \
    --cc=arnd@arndb.de \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).