From: Scott Wood <scottwood@freescale.com>
To: Pledge Roy-R01356 <roy.pledge@freescale.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
Bucur Madalin-Cristian-B32716 <madalin.bucur@freescale.com>
Subject: Re: [PATCH 1/2] powerpc/qman: Change fsl,qman-channel-id to cell-index
Date: Tue, 5 May 2015 15:45:34 -0500 [thread overview]
Message-ID: <1430858734.16357.256.camel@freescale.com> (raw)
In-Reply-To: <BN3PR0301MB126796C0EC18EEBB26702C588CD10@BN3PR0301MB1267.namprd03.prod.outlook.com>
On Tue, 2015-05-05 at 11:04 -0500, Pledge Roy-R01356 wrote:
> Sorry for the slow reply.
>
> I don't believe this is correct - let me explain the rational why we had two properties in the QMan portal to begin with.
>
> The two properties in question are cell-index and fsl,qman-channel-id.
>
> The cell-index property is used in u-boot as an index for the software portal ID when adding the fsl,liodn from the U-boot table into the device tree.
The device tree is not supposed to contain arbitrary software
identifiers.
> The fsl,qman-channel-id property is used in Linux and corresponds to a
> hardware value that indicates which channel is dedicated to the
> software portal.
>
> While I'm not aware of a current SoC where the channel ID for a
> software portal does not match the index (i.e. SWP 0 uses channel 0,
> etc.)
Thus there's no backward compatibility issue with redefining cell-index
to mean the channel ID.
> it is possible that future SoCs could stray from this model,
> there is no reason for portal index to equal channel ID at all times.
How can future SoCs dictate how we assign a software-defined identifier?
If software wants it to be the same as the channel id, then it will be.
If there is some aspect of the hardware itself (not the documentation)
that cell-index currently corresponds to, other than the channel id,
please make that clear.
-Scott
next prev parent reply other threads:[~2015-05-05 20:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-17 22:53 [PATCH 1/2] powerpc/qman: Change fsl,qman-channel-id to cell-index Scott Wood
2015-04-17 22:53 ` [PATCH 2/2] powerpc/mpc85xx: Add FSL QorIQ DPAA QMan support to device tree(s) Scott Wood
2015-05-05 16:04 ` [PATCH 1/2] powerpc/qman: Change fsl,qman-channel-id to cell-index Roy Pledge
2015-05-05 20:45 ` Scott Wood [this message]
2015-05-12 21:19 ` Roy Pledge
2015-05-12 22:46 ` Scott Wood
2015-08-19 20:52 ` Roy Pledge
2015-08-19 21:30 ` Scott Wood
2015-08-20 14:52 ` Roy Pledge
2015-08-20 16:53 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1430858734.16357.256.camel@freescale.com \
--to=scottwood@freescale.com \
--cc=devicetree@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=madalin.bucur@freescale.com \
--cc=roy.pledge@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).